Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

2014-10-07 Thread Justin Mclean
Hi, > I¹m confused. Why doesn¹t fixer/assignee resolve and reporter close to > confirm the resolver¹s decision? You can do (and certainly nothing wrong in working that way) but it's not enforced by the current workflow and it's certainly not common practice as shown by previous JIRA entries. I

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

2014-10-07 Thread Alex Harui
I¹m confused. Why doesn¹t fixer/assignee resolve and reporter close to confirm the resolver¹s decision? On 10/7/14, 6:23 PM, "Justin Mclean" wrote: >Hi, > >Our workflow on closed and resolved. Note that you can skip the resolved >step altogether and if resolved the close step is optional. >http

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

2014-10-07 Thread Justin Mclean
Hi, Our workflow on closed and resolved. Note that you can skip the resolved step altogether and if resolved the close step is optional. https://issues.apache.org/jira/plugins/servlet/project-config/FLEX/workflows# Thanks, Justin

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

2014-10-07 Thread OmPrakash Muppirala
On Oct 7, 2014 6:18 PM, "Justin Mclean" wrote: > > Hi, > > > Did not want to close it without you getting a chance to verify it. > > Issue hadn't been resolved so I assumed you wanted me to resolve it. > > > Usually fixer resolves the issue, and the reporter closes the issue > > Generally not the

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

2014-10-07 Thread Justin Mclean
Hi, > Did not want to close it without you getting a chance to verify it. Issue hadn't been resolved so I assumed you wanted me to resolve it. > Usually fixer resolves the issue, and the reporter closes the issue Generally not the case in our bug base, resolved is not used that often, 1596 in

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

2014-10-07 Thread OmPrakash Muppirala
On Oct 7, 2014 6:01 PM, "Justin Mclean" wrote: > > Hi, > > > Justin, see if you can close the JIRA ticket you opened for this. > > Done. BTW Not sure why you are asking me to close it as anyone with the right JIRA permissions (ie you) could close it. Did not want to close it without you getting a

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

2014-10-07 Thread Justin Mclean
Hi, > Justin, see if you can close the JIRA ticket you opened for this. Done. BTW Not sure why you are asking me to close it as anyone with the right JIRA permissions (ie you) could close it. Justin

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

2014-10-07 Thread OmPrakash Muppirala
Justin, see if you can close the JIRA ticket you opened for this. Thanks, Om On Tue, Oct 7, 2014 at 3:11 PM, bigosmallm wrote: > Github user bigosmallm commented on the pull request: > > https://github.com/apache/flex-utilities/pull/1#issuecomment-58271561 > > Thanks, trimedia! > > > --

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

2014-10-07 Thread OmPrakash Muppirala
Hi, The patch has been accepted and committed. Please close the Pull Request (you have to close it manually) Thanks for the contribution! Regards, Om On Tue, Oct 7, 2014 at 10:06 AM, trimedia wrote: > GitHub user trimedia opened a pull request: > > https://github.com/apache/flex-utilitie