Re: [GitHub] flex-asjs pull request: sortOn

2016-05-11 Thread Harbs
I noticed the tags, but I was too lazy to do anything about it (as I personally don’t care very much). Do you want to remove the tag? Harbs On May 11, 2016, at 10:50 AM, Justin Mclean wrote: > Hi, > > Author tags are generally frowned upon at the ASF, it would be best if they > are removed.

Re: [GitHub] flex-asjs pull request: sortOn

2016-05-11 Thread Justin Mclean
Hi, Author tags are generally frowned upon at the ASF, it would be best if they are removed. Thanks, Justin

Re: [GitHub] flex-asjs pull request: sortOn

2016-05-10 Thread Harbs
run the tests before committing >> ... If I broke something, I'll look into it. >> >> Chris >> >> Von: Harbs >> Gesendet: Dienstag, 10. Mai 2016 13:31:41 >> An: dev@flex.apache.org >> Betreff: Re: [GitHub

Re: [GitHub] flex-asjs pull request: sortOn

2016-05-10 Thread Harbs
"chris"? ... me? I thought I always run the tests before committing ... > If I broke something, I'll look into it. > > Chris > > Von: Harbs > Gesendet: Dienstag, 10. Mai 2016 13:31:41 > An: dev@flex.apache.org > Betreff

Re: [GitHub] flex-asjs pull request: sortOn

2016-05-10 Thread Harbs
I tried merging it in, but the last commit by Chris seems to have broken the build. I think this is going to have to wait until Chris fixes his commit. Harbs On May 10, 2016, at 6:48 AM, lizhi wrote: > pls close it > > > > -- > View this message in context: > http://apache-flex-developmen

Re: [GitHub] flex-asjs pull request: sortOn

2016-05-09 Thread lizhi
pls close it -- View this message in context: http://apache-flex-development.247.n4.nabble.com/GitHub-flex-asjs-pull-request-sortOn-tp52862p52935.html Sent from the Apache Flex Development mailing list archive at Nabble.com.