We may still need that somewhere. You may need to set the dataProvider to
null in order to allow for garbage collection. But yes, in general, we
want to avoid defensive code.
-Alex
On 7/10/17, 8:17 AM, "piotrz" wrote:
>I think we should raise jira for DropDownList improvement. Once it will be
I think we should raise jira for DropDownList improvement. Once it will be
done we won't need
if(!value)return; :)
Thanks,
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/FlexJS-DropDownList-dataProv
I agree with Piotr about moving the removal of the elements to the view.
But really, the binding subsystem should have caught this error. That's
part of the "Payment" for using binding.
My 2 cents,
-Alex
On 7/9/17, 11:50 AM, "piotrz" wrote:
>I think this Option generation shouldn't be really
I think this Option generation shouldn't be really happen inside DropDownList
but rather in DropDownListView.
Maybe when Peter get back from vacation will get a chance refactor that
part. It could be done similar as I did it in MDL or even merge everything
together.
Thanks,
Piotr
-
Apache
I fixed it. If someone feels that it’s not a bug we can revert the commit...
Next issue… ;-)
> On Jul 9, 2017, at 9:27 PM, Harbs wrote:
>
> It was always like that, but I think it’s incorrect.
>
> You can go back in the history, but you need to follow the changes across the
> rename from HTML
It was always like that, but I think it’s incorrect.
You can go back in the history, but you need to follow the changes across the
rename from HTML. SourceTree makes that pretty easy.
> On Jul 9, 2017, at 9:00 PM, piotrz wrote:
>
> I cannot check when those changes was introduced, cause for so
I cannot check when those changes was introduced, cause for some reason I
don't see history of that file.
I think it was before dual, cause this model was moved from HTML module to
Basic during dual changes.
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context
Yeah. I noticed that too.
> On Jul 9, 2017, at 8:20 PM, piotrz wrote:
>
> Additionally I see in ArraySelectionModel which has been used in DropDownList
> in dataProvider setter this one:
>
> if (value === this._dataProvider)
>return;
>
> Piotr
>
>
>
> -
> Apache Flex PMC
> piotrzarz
Additionally I see in ArraySelectionModel which has been used in DropDownList
in dataProvider setter this one:
if (value === this._dataProvider)
return;
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
http://apache-flex-development.247.n4.nabble.
Harbs,
What do you exactly see in the console ? I just tried your example and I
don't see any RTE there. Do you see it in SWF version ?
Thanks,
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/FlexJS-Dr
I was trying to create a JIRA, but JIRA keeps freezing my browsers. I finally
managed to get in using Safari and using a direct URL, I managed to open a page
in Chrome. I disabled the “new project navigation” which seems to have brought
JIRA back to life for me.
Anyway here’s the JIRA:
https://
Yes. I’ll try to put together a test case.
> On Jul 9, 2017, at 6:57 PM, piotrz wrote:
>
> Actually could you provide small example ? I would like to make sure myself
> that is a bug.
>
> Thanks,
> Piotr
>
>
>
> -
> Apache Flex PMC
> piotrzarzyck...@gmail.com
> --
> View this message in
Actually could you provide small example ? I would like to make sure myself
that is a bug.
Thanks,
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/FlexJS-DropDownList-dataProvider-tp62984p62986.html
Sen
Hi Harbs,
I think it's a bug. I'm wondering whether MDL DropDownList react same.
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/FlexJS-DropDownList-dataProvider-tp62984p62985.html
Sent from the Apache
14 matches
Mail list logo
