Re: [FlexJS] Summary of Changes

2017-03-29 Thread Peter Ent
Harbs - I have to rollback the setting of position="absolute" (when setting .x or .y properties) on my next commit. This is causing other examples to behave weirdly in situations where the parent of the element whose position is being set does not itself have a position set. After talking with A

Re: [FlexJS] Summary of Changes

2017-03-28 Thread Peter Ent
I just pushed a change to the tour code. It should be better. We should be able to do this with the regular horizontal and vertical layouts with % sizing, I think, and not just with Flexbox layouts. One thing I changed was to remove the grow="1" on the layouts. I put that in there to make it easy

Re: [FlexJS] Summary of Changes

2017-03-28 Thread piotrz
Peter, Could you look into TourJS, maybe there you also found some issue with layout there. I'm really interesting how to resolve it there. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Summar

Re: [FlexJS] Summary of Changes

2017-03-28 Thread Peter Ent
Here is a link to a Pasteboard [1] that should help. It is a set of nested Panels. If you run this on both SWF and HTML, you'll see differences due to the fact that the SWF side does not yet handle all of the CSS. The HTML should be a nesting of hideously colored boxes with their content centered.

Re: [FlexJS] Summary of Changes

2017-03-28 Thread Peter Ent
I forgot to add that "align-items:center" is not supported on the SWF side yet. The Flexbox has a number of properties that I still have to implement on the flex side. On 3/28/17, 8:11 AM, "Peter Ent" wrote: >The HorizontalLayout and VerticalLayout do not center their content >because the equiva

Re: [FlexJS] Summary of Changes

2017-03-28 Thread Peter Ent
The HorizontalLayout and VerticalLayout do not center their content because the equivalent code on the JS side does not do that (at least it did not do that for me in the tests I ran). I think setting margin:auto is supposed to help with that. On the other hand, you can switch to HorizontalFlexLay

Re: [FlexJS] Summary of Changes

2017-03-28 Thread Peter Ent
I just built another test where I nested Panels in Panels in Panels (since they are compound components) and found some of the layouts still not working right on the JS side. It looks to me like the problem is not setting the style attributes right using Flexbox. While I spent a good deal of time

Re: [FlexJS] Summary of Changes

2017-03-27 Thread Harbs
Yes. I think the problem is that the size is not being set. > On Mar 27, 2017, at 11:58 PM, Alex Harui wrote: > > For #2, again, what does the DOM look like? Did the margins get set > properly?

Re: [FlexJS] Summary of Changes

2017-03-27 Thread Greg Dove
I've just done a sweep through one project fixing our 'borked' stuff, I guess the latest change might re-'bork' some of the fixes, but I think at least these changes should be easier to address. Sometimes I needed to swap a Container to a Group and other times not, because of the relative/absolute

Re: [FlexJS] Summary of Changes

2017-03-27 Thread Harbs
I probably need to examine the new “flex” layouts. Is there a way to have content centered using those? > On Mar 27, 2017, at 11:35 PM, Harbs wrote: > > Better, but I still have some problems (there’s probably more): > > > >

Re: [FlexJS] Summary of Changes

2017-03-27 Thread Peter Ent
Does the HTML look OK - the structure. Is there anything missing? You should see a simplified nesting of DIVs. If that's the case, then maybe there is more work to do with the layouts. The topmost Container, outer controls, doesn't look like it has a layout, so with Container that should default t

Re: [FlexJS] Summary of Changes

2017-03-27 Thread Alex Harui
Harbs, For #1, that sounds like a problem with deferred loading of images. What is in the DOM? Are heights still being set on the containers? Also, Peter, should Harbs switch from Container to Group? For #2, again, what does the DOM look like? Did the margins get set properly? Thanks, -Alex

Re: [FlexJS] Summary of Changes

2017-03-27 Thread Harbs
Better, but I still have some problems (there’s probably more):

Re: [FlexJS] Summary of Changes

2017-03-27 Thread Peter Ent
Hi, I just pushed a change to UIBase to set position="absolute" when setting x or y. I think this is perfectly safe and if someone does set x and y and then tries to use a layout where that would be a conflict, they will get have to avoid setting those properties. I figured this would eventually

Re: [FlexJS] Summary of Changes

2017-03-27 Thread Harbs
Peter, I just tried loading my app with your changes, and everything is totally borked. We rely a lot on absolute positioning and transformations. We really need the old behavior in some components. Is there any components which work the same as they used to? Harbs > On Mar 26, 2017, at 6:55

Re: [FlexJS] Summary of Changes

2017-03-26 Thread piotrz
Thanks Peter for the tips. Digging into TourJS I learned couple of things. :) Just committed my final changes for today with still unresolved issues: - For some reason ButtonBar change event not working - Layout for displaying example application is still broken (I mean here Panel with SubAppLoade

Re: [FlexJS] Summary of Changes

2017-03-26 Thread Peter Ent
For the time being, the Tour main view should have a width and a height: Then in the style section, give everything flex-grow: 1; and it should look better. I think some padding and/or margins might be needed, but I think I have more work do with the layouts. I'll bump getting the tour to the to

Re: [FlexJS] Summary of Changes

2017-03-26 Thread Peter Ent
I'm looking at the Tour right now. When you use the Flexbox layouts, you need to specify flex-grow:1 for anything you want to grow to fill the remaining space; otherwise it uses its native or explicit size. You could try to switch over to the normal horizontal and vertical layouts and see if they w

Re: [FlexJS] Summary of Changes

2017-03-26 Thread piotrz
Peter, I've started to experiment with your new classes in TourJS and I think I've achieved some good look, but not everything is working as expected. For some reason code of examples has not been loaded properly. If you could review my changes and give some feedback, whether I used your new cla

Re: [FlexJS] Summary of Changes

2017-03-26 Thread piotrz
Peter, I think I have found why layout look like this. We have following structure: Generated HTML: If I change contentTree CSS to position:relative I will see "span" with "Everytgh

Re: [FlexJS] Summary of Changes

2017-03-26 Thread piotrz
Hi Peter, I just looked into TourJS and refreshed poms of Maven build. I think after your changes Tree component is being broken. Could you build TourJS and confirm. Maybe I'm doing something wrong, but I see that content.json is being loaded.

Re: [FlexJS] Summary of Changes

2017-03-24 Thread Peter Ent
Updates to examples. I just pushed changes to two of the examples: DataBindingExample and DataGridExample. Use these examples to provide some guidance when making your own changes: - Change Container to Group if you can, although on the JS side, Container and Group are the same. - Employ the Vert

Re: [FlexJS] Summary of Changes

2017-03-24 Thread piotrz
Thanks Peter! I will try MDLExamples over the weekend and see whether everything is working as it was. :) For sure some interfaces cleanup would be awesome. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabbl

Re: [FlexJS] Summary of Changes

2017-03-24 Thread Peter Ent
Amendment to these changes: Charts: This package should compile now, but will probably not work completely. Next on my list. MDL: This package compiles and runs the main example for me. For those of you who use MDL, I changed the classes that extended ContainerBase to extend Group instead. Since

Re: [FlexJS] Summary of Changes

2017-03-23 Thread Harbs
For full constrained layouts like we had in regular Flex, we’re probably going to need to use absolute positioning and JS to set the top/left values. But I’d love to see how far we can get with just CSS... > On Mar 23, 2017, at 8:13 PM, Peter Ent wrote: > > I want to make a layout that uses le

Re: [FlexJS] Summary of Changes

2017-03-23 Thread Peter Ent
I want to make a layout that uses left, top, right, bottom for positioning. The JS side is easy of course, you do nothing! On 3/23/17, 2:11 PM, "Harbs" wrote: >The changes look like they should be over-all improvements. Like you say, >we will have to see how they play out. > >There might be a ne

Re: [FlexJS] Summary of Changes

2017-03-23 Thread Harbs
The changes look like they should be over-all improvements. Like you say, we will have to see how they play out. There might be a need to easily flip position between absolute and relative, but we’ll see. I’m looking forward to seeing how the changes behave. :-) Harbs > On Mar 23, 2017, at 7: