Re: [FlexJS] Problems with custom events in IE11

2017-01-18 Thread Alex Harui
On 1/17/17, 10:40 PM, "piotrz" wrote: >Alex, > >It make sense. This inject_html_ie is something which is written in pure >JS >as I think yes or it can be in AS then compiled to JS ? Actually, I think you may have a better idea. If we create a bead called InternetExplorerSupport, we could writ

Re: [FlexJS] Problems with custom events in IE11

2017-01-17 Thread piotrz
Alex, It make sense. This inject_html_ie is something which is written in pure JS as I think yes or it can be in AS then compiled to JS ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Problems

Re: [FlexJS] Problems with custom events in IE11

2017-01-17 Thread Alex Harui
On 1/17/17, 2:08 PM, "piotrz" wrote: >Alex, > >initEvent is the way which some day may be dropped from support in some >browsers. - That's how I'm thinking reading that is deprecated. > >inject_html_ie - hmm...How it could work if I have in some of my function: > >var ev:window.Event = new wind

Re: [FlexJS] Problems with custom events in IE11

2017-01-17 Thread Clint M
Thought this might help. http://caniuse.com/#feat=customevent If you click the "Show All" button on the link you can see a broader range of device support. On Tue, Jan 17, 2017 at 1:55 PM, Alex Harui wrote: > Hi Piotr, > > Thanks for working on it. I'm wondering, is the "old way" of > createEve

Re: [FlexJS] Problems with custom events in IE11

2017-01-17 Thread piotrz
Alex, initEvent is the way which some day may be dropped from support in some browsers. - That's how I'm thinking reading that is deprecated. inject_html_ie - hmm...How it could work if I have in some of my function: var ev:window.Event = new window.Event() - it will replace this line ? Piotr

Re: [FlexJS] Problems with custom events in IE11

2017-01-17 Thread Alex Harui
Hi Piotr, Thanks for working on it. I'm wondering, is the "old way" of createEvent/initEvent not work in some browsers? Otherwise, we should just use that one code path. And if I understand correctly that only IE doesn't support "new Event", then we should remember to re-visit this code in the

Re: [FlexJS] Problems with custom events in IE11

2017-01-17 Thread piotrz
I think I have fixed event creation. Now everything is working in IE11 :) I've introduced util for JS events creation -> org.apache.flex.events.utils.EventUtils - createEvent - createMouseEvent Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apac

Re: [FlexJS] Problems with custom events in IE11

2017-01-17 Thread piotrz
Hi Carlos, I just commit it and then saw your email. I think I did it with backward compatibility - if you look what I've changed you will see. I will provide also method for create MouseEvent. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apach

Re: [FlexJS] Problems with custom events in IE11

2017-01-17 Thread Carlos Rovira
Maybe for this kind of cases, better to make a branch and ask people to check and test against that branch. Right? 2017-01-17 16:14 GMT+01:00 Harbs : > We have had issues with mouse events. I don’t think we’re doing anything > super-special there. > > We have not done enough testing in IE. If you

Re: [FlexJS] Problems with custom events in IE11

2017-01-17 Thread Harbs
We have had issues with mouse events. I don’t think we’re doing anything super-special there. We have not done enough testing in IE. If you break something, we’ll know soon enough. ;-) > On Jan 17, 2017, at 4:28 PM, piotrz wrote: > > This low level events has been used in the back stage in ou

Re: [FlexJS] Problems with custom events in IE11

2017-01-17 Thread piotrz
This low level events has been used in the back stage in our framework. Look into the MouseEvent for example. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Problems-with-custom-events-in-IE11-t

Re: [FlexJS] Problems with custom events in IE11

2017-01-17 Thread yishayw
We don't use low level events in our app, so theoretically we should be indifferent to the implementation. If it solves an IE issue, it should only have a positive effect on us. -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Problems-with-custom-eve

Re: [FlexJS] Problems with custom events in IE11

2017-01-17 Thread piotrz
I would like to hear more feedback on this one. Maybe Harbs or Yishay will share their thoughts - cause they rewriting Flex app to FlexJS - If I change our creation of events from new window.Event to something like that [1]. Will it impact them ? [1] https://developer.mozilla.org/en-US/docs/Web/

Re: [FlexJS] Problems with custom events in IE11

2017-01-16 Thread Alex Harui
On 1/16/17, 10:59 PM, "piotrz" wrote: >Alex, > >The problem is with window.Event. We are creating it in couple of places >ElementWrapper->dispatchEvent [1]. Not sure whether we can change it to >something else. Hmm. I guess we haven't been doing enough testing on IE. If document.createEvent

Re: [FlexJS] Problems with custom events in IE11

2017-01-16 Thread piotrz
Alex, The problem is with window.Event. We are creating it in couple of places ElementWrapper->dispatchEvent [1]. Not sure whether we can change it to something else. It's failing on creation: [1] https://p

Re: [FlexJS] Problems with custom events in IE11

2017-01-16 Thread Alex Harui
Were you trying to make a DOM CustomEvent or an org.apache.flex.events.CustomEvent? The latter should work. -Alex On 1/16/17, 10:15 PM, "piotrz" wrote: >Hi All, > >I was trying to test something in IE11, but it's completely failed on >problem with custom events [1]. The solution is probably he