Re: [FlexJS] PAYG and dataGroups

Framework convention is generally to leave out the braces and indent the line like this: if (ir) ir.selected = true; > On Jul 24, 2017, at 2:54 PM, piotrz wrote: > > I meant this kind of lines somewhere inside method: > > ir = dataGroup.getItemRendererForIndex(listModel.selectedIndex) as > I

Re: [FlexJS] PAYG and dataGroups

I meant this kind of lines somewhere inside method: ir = dataGroup.getItemRendererForIndex(listModel.selectedIndex) as ISelectableItemRenderer; if (ir != null) ir.selected = true; I would change it to: ir = dataGroup.getItemRendererForIndex(listModel.selectedIndex) as ISelectableItemRenderer; if

Re: [FlexJS] PAYG and dataGroups

I’m not sure what you mean. If you mean braces for single-line statements, I actually use those in my personal projects, but I leave them out in Flex code because that’s alway been the convention in the Flex Framework. Thanks, Harbs > On Jul 24, 2017, at 2:32 PM, piotrz wrote: > > Thanks! I

Re: [FlexJS] PAYG and dataGroups

Thanks! I saw your changes and it look better. Btw: I really would like to see in your commits more curly brackets - especially when you are doing some changes down into the methods. - It's lot easier to catch eventually bugs. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this

Re: [FlexJS] PAYG and dataGroups

I spent quite a bit of time looking into this. I came to the conclusion that there likely needs to be beads with more interop for modifying data content, but I don’t think I need that for right now. After finding my way through the classes, I realized that dataGroup.getItemRendererForIndex() ha

Re: [FlexJS] PAYG and dataGroups

Hi Harbs, In such cases where you preventing from RTE I'm thinking that having bead would be weird. PreventDataGroupFromRte? Cause you do not do anything more adding such just-in-case code. Maybe this case is one of those when we should have that code? Piotr - Apache Flex PMC piotrzarzyck

Re: [FlexJS] PAYG and dataGroups

Different variants of datagroup listview etc can be smarter about data changes. The listview could also share its index properties with beads that know? how to deal with data changes. Get Outlook for Android From: Harbs Sent: Sunday, Jul