Re: [FlexJS] Merge feature/chart-work into develop

2017-04-06 Thread piotrz
Hi Peter, If you stack with something let me know I will look into that. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Merge-feature-chart-work-into-develop-tp61019p61034.html Sent from the Ap

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-06 Thread Peter Ent
I fixed the missing piece for the text fields example. Still looking into the tabs. ‹peter On 4/5/17, 5:46 PM, "piotrz" wrote: >Peter, > >I just tried your changes and check MDLExample and MDLDynamicTabsExample. > >In MDLExample: >TextFields are not displayed > >In MDLDynamicTabsExample: >I see

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread Alex Harui
On 4/5/17, 10:03 AM, "Harbs" wrote: >That would be great. > >We need better test coverage. If we could get easy test setup for FlexJS, >that would be a huge win. Not sure how you define "easy" but we've had mustella running on FlexJS for quite a while now. It allows you to write the tests in

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread piotrz
Peter, I just tried your changes and check MDLExample and MDLDynamicTabsExample. In MDLExample: TextFields are not displayed In MDLDynamicTabsExample: I see that switching between tabs, once I add Tab dynamically is broken. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread Peter Ent
I have decided not to merge today. I ran an example with DataGrid embedded within a Container and sized to width="100%" and it did not respond properly to the resize. I know what happened, just working on how to make it work correctly. ‹peter On 4/5/17, 1:35 PM, "piotrz" wrote: >Peter I just me

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread piotrz
Peter I just merged falcon develop branch to your chart-work. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Merge-feature-chart-work-into-develop-tp61019p61027.html Sent from the Apache Flex De

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread piotrz
Thanks Peter. I'm ok with merge then. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Merge-feature-chart-work-into-develop-tp61019p61026.html Sent from the Apache Flex Development mailing list a

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread Peter Ent
I just changed Menu to extend DataContainer and now that works fine, for me, in MDLExample. Thank you for reminding me. ‹peter On 4/5/17, 11:37 AM, "piotrz" wrote: >Hi Peter, > >I didn't check MDLExample after your last push, but didn't you mention >that >MDL Menu is blank ? >If it's not workin

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread Christofer Dutz
Hi Harbs, Have you had a look at the Integration Test project in FlexJS? I doubt it would get much simpler: - The Maven build automatically: o Downloads, configures and starts a tomcat server o Deploys all examples as web applications o As soon as the server is up and the applications as running

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread Harbs
That would be great. We need better test coverage. If we could get easy test setup for FlexJS, that would be a huge win. > On Apr 5, 2017, at 12:33 PM, Christofer Dutz > wrote: > > I would start writing some simple Selenium Tests for these applications

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread Christofer Dutz
Hi Peter, If it improves things, I am fine with this merge. If it adds more areas that need fixing then I don’t. As soon as things start to work again, I would start writing some simple Selenium Tests for these applications to ensure they are tested in the future. Chris Am 05.04.17, 17:37 sch

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread piotrz
Hi Peter, I didn't check MDLExample after your last push, but didn't you mention that MDL Menu is blank ? If it's not working I would say -1 till we have it look ok. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n