Re: [FlexJS] Container and Layout Progress

Things should build now. Charts will not work yet, but MDL example (at least one) now runs for me. ‹peter On 3/24/17, 2:58 AM, "Christofer Dutz" wrote: >Hi Guys, > >Well I am expecting to be able to build develop Š if there are changes >that break things, these belong in a feature branch until

Re: [FlexJS] Container and Layout Progress

Hi Guys, Well I am expecting to be able to build develop … if there are changes that break things, these belong in a feature branch until they are sorted out and merged to develop as soon as things are finished. Now please fix the things that are broken in develop this time, but make sure to us

Re: [FlexJS] Container and Layout Progress

I've committed and pushed changes to MDL that should make it compile. I don't think it will work - I'll be doing that next but I wanted to get the project to compile. Basically, all of the List-like MDL classes now extends Group rather than ContainerBase, which I should delete. Then I needed to ma

Re: [FlexJS] Container and Layout Progress

I should have committed a change to the build to exclude charts. Hmm. Peter > On Mar 23, 2017, at 12:57 PM, Christofer Dutz > wrote: > > Well I guess things are broken now ( > > I just updated and ran a new build and Charts is exploding at the moment … > > Chris > > > > Am 23.03.17, 1

Re: [FlexJS] Container and Layout Progress

Yes, Chris does have a good point and from now on* I will definitely use feature branches. I thought I could squeeze this through. I checked in changes to Chart that should make it compile. I doubt it will run, but that is on the list. I will look into MDL now. That will take longer. I am leary a

Re: [FlexJS] Container and Layout Progress

I guess I should have used a feature branch. I'm not sure how long Charts will take. I wrote most of that code and it got pretty gnarly using List as a basis. It probably is better to use a feature branch. Let me see if I understand the rollback process and can get that going. Definitely a lesson l

Re: [FlexJS] Container and Layout Progress

Sure. Including me. But Chris does have a point that we should be using feature branches more than we are. The tone of my question might have not come across correctly. I meant to ask how difficult it would be to move all changes to a feature branch and push the feature branch. If it’s too dif

Re: [FlexJS] Container and Layout Progress

But it was expected. I can help with MDL if you will need. Just let me know. If fixes will be today, there is no point to revert anything. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Contai

Re: [FlexJS] Container and Layout Progress

Peter warned the list that his changes would break some things temporarily, and he asked if he should proceed. Everyone who responded said that it was okay. - Josh On Thu, Mar 23, 2017 at 10:11 AM, Harbs wrote: > Very good question. > > Peter, is there any chance to roll back containers and lay

Re: [FlexJS] Container and Layout Progress

Very good question. Peter, is there any chance to roll back containers and layouts and move all the changes to a feature branch until things are stable? > On Mar 23, 2017, at 7:58 AM, Christofer Dutz > wrote: > > Why don't you guys use feature branches?

Re: [FlexJS] Container and Layout Progress

Well I guess things are broken now ( I just updated and ran a new build and Charts is exploding at the moment … Chris Am 23.03.17, 17:02 schrieb "Peter Ent" : Hi, I've committed the changes!! The build should skip, MDL, Charts, and Basic projects. I will get MDL and Charts r

Re: [FlexJS] Container and Layout Progress

Hi, I've committed the changes!! The build should skip, MDL, Charts, and Basic projects. I will get MDL and Charts running next. But before that, I will have an email out with a breakdown of the changes I've made. Look for that in the next couple of hours. Good luck! Please let me know what break

Re: [FlexJS] Container and Layout Progress

Peter, I think you should commit and try to fix at first MDL - If you have any problems let me know I will help you. As for the content of Basic - I think Alex know what changes will have place in Basic due to "dual" branch. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this m

Re: [FlexJS] Container and Layout Progress

Update: I'm 99% ready to commit. I will do this tomorrow morning, my time. I've spent today fixing some last issues in HTML package, while cosmetic, just didn't make things look too good. There are a couple more but I'll do them later. I did a local merge of the latest FlexJS code and my changes a

Re: [FlexJS] Container and Layout Progress

Yes. Commit. Right now we need to use an earlier version because the current status is broken. > On Mar 22, 2017, at 4:37 PM, OK wrote: > > In case if something is broken for somebody maybe one option is to just check > out a previous revision by using the particular commit hash? > > Olaf >

Re: [FlexJS] Container and Layout Progress

In case if something is broken for somebody maybe one option is to just check out a previous revision by using the particular commit hash? Olaf -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60673.html Sent fro

Re: [FlexJS] Container and Layout Progress

Hi Peter, +1 for commit, than fix Charts. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60672.html Sent from the Apache Flex Development mailing list arch

Re: [FlexJS] Container and Layout Progress

Hi, One more thing: When I make this commit, I'm pretty sure Charts will be broken until I address it. I can hold off the commit and address Charts first, but I would prefer to commit Core and HTML and then fix Charts and anything else. Would that strategy (commit first, fix Charts etc after) im

Re: [FlexJS] Container and Layout Progress

Hi Peter, Thank you for a hard work. I'm concerning about one thing. Alex mentioned that he will merge soon dual branch to develop - It will be tons of conflicts - Maybe it would be good to look also into that problem. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this messag

Re: [FlexJS] Container work status

Hi, I've fixed a number of layout issues. I'm still putting things together and testing, but this problem should be addressed in my next commit. ‹peter On 3/20/17, 3:26 AM, "yishayw" wrote: >I think some of your changes in BasicLayout have broken some layout >behavior >on the JS side. In this

Re: [FlexJS] Container work status

I think some of your changes in BasicLayout have broken some layout behavior on the JS side. In this [1] app the blue container ("myFlex") doesn't stretch to screen size. After debugging this behavior for quite a while I came to the conclusion that BasicLayout no longer calls child.dispatchEvent("s

Re: [FlexJS] Container work status

Peter, can I test this in FlexJs nightly build? On 16-Mar-2017 5:38 PM, "Peter Ent [via Apache Flex Development]" < ml-node+s247n60509...@n4.nabble.com> wrote: Thanks for letting me know. I will try to be quick. ‹peter On 3/16/17, 4:11 AM, "Justin Mclean" <[hidden email]

Re: [FlexJS] Container work status

Thanks for letting me know. I will try to be quick. ‹peter On 3/16/17, 4:11 AM, "Justin Mclean" wrote: >Hi, > >The current changes have broken the layout in our application (not >unexpected). When you feel it at a stable state just say so and we set if >we can fix it up and report back any issu

Re: [FlexJS] Container work status

Hi, The current changes have broken the layout in our application (not unexpected). When you feel it at a stable state just say so and we set if we can fix it up and report back any issues. Thanks, Justin

Re: [FlexJS] Container work status

Hi Peter, Thanks for reporting progress! I'm looking forward to your changes! :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Container-work-status-tp60417p60452.html Sent from the Apache Fle

Re: [FlexJS] Container

Hi Peter, 2017-02-27 23:13 GMT+01:00 Peter Ent : > > QUESTION: In your Flex apps, do you need to place chrome elements besides > using a Panel? > As you and Peter think, is rare. This should be implemented in an extended or different component. -- Carlos Rovira http://about.me/carlosrovira

Re: [FlexJS] Container

Hi, > QUESTION: In your Flex apps, do you need to place chrome elements besides > using a Panel? A few times but reasonably rare. Think the last time was a little “x" that showed up when mouse was in the corner. > I'm getting hung up with the nesting of the containing elements and I think >