Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-12 Thread Carlos Rovira
Yeah, really good! Good work! :) 2017-01-12 11:54 GMT+01:00 piotrz : > Carlos, > > But one thing which is really good, that we partially support this cause of > our implementation of dataProvider API. :) - One type of Tabs is working > really good if you can see in the examples. :) > > Piotr > >

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-12 Thread piotrz
Carlos, But one thing which is really good, that we partially support this cause of our implementation of dataProvider API. :) - One type of Tabs is working really good if you can see in the examples. :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: ht

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-12 Thread piotrz
Exactly. The component itself is working fine. Google MDL not only do not support nested tabs, but also do not recommend do such UX-es. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-MDL-Discuss

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-12 Thread Carlos Rovira
Hi Piotr, ok I think I understand you now. You mean that as we are nesting tabs in the MDLExample (Main Navigation > Tabs) we have problems due to Google not supporting nesting. So the component is ok right? 2017-01-12 6:26 GMT+01:00 piotrz : > Yes and it will be working in the main. Problem is

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-11 Thread piotrz
Yes and it will be working in the main. Problem is started you put into one of the Tab - another Tab-Navigation layout structure. Do following test: 1) Launch MDL Example and being on first tab check in "Tabs" how Html structure look like - first tab for Game of Throne tabs is selected. 2) Click o

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-11 Thread Carlos Rovira
Hi Piotr 2017-01-08 15:40 GMT+01:00 piotrz : > > 2) > > > 2 - But this one won't work too good. If you jump into Tabs example you > will > see that first Tab "starks" is selected, but his content not. > That was the problem you said some days ago about a problem with "isActive"? But in the mai

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-11 Thread Carlos Rovira
Great, That's makes MDL more close to Flex style! :) 2017-01-08 0:43 GMT+01:00 piotrz : > You are right. Maybe there is also other scenarios. > One think which I'm going to do for TabBar and Tabs is expose set for > selectedIndex - it gives possibility select some TabBarButton on startup. > > Pio

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-08 Thread piotrz
Carlos, I was reading on MDL github that nested tab is not supported. [1][2] In our example we have: 1) 2) 1 - In somehow it is working, so if you are using 1 in your application where outher Tabs are based on NavigationLayout - it will work. :) 2 - But this one won't work too good. If yo

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-07 Thread piotrz
You are right. Maybe there is also other scenarios. One think which I'm going to do for TabBar and Tabs is expose set for selectedIndex - it gives possibility select some TabBarButton on startup. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apa

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-07 Thread Carlos Rovira
mmm...maybe someone could need it to select content vía code? I think we should think if people could needed in some way... 2017-01-07 19:50 GMT+01:00 piotrz : > Carlos, > > I did notice that haven't handle default selection for Tab. I have to fix > it, but I was wondering - What is the purpose o

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-07 Thread piotrz
Carlos, I did notice that haven't handle default selection for Tab. I have to fix it, but I was wondering - What is the purpose of have isActive property for TabBarPanel. I think it's good to have getter for this one, but setter is redundant - I think. Basically TabBarButton should have isActive

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-06 Thread piotrz
Hi Alex, Thank you for suggestion. I just did it and now everything is working fine and It look cleaner. Tabs now has TabBar as sub components. I'm creating and adding TabBar in TabsView. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-fle

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-05 Thread Alex Harui
On 1/5/17, 12:10 AM, "piotrz" wrote: >Currently MDL Tabs example suffer with bug. If you go to example and >started >to play with Tab One, Tab Two you will notice that content >(CustomTabBarPanelItemRenderer) is displaying above TabBar. > >Current usage [1]. Tabs will be rendered first, later T

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-05 Thread piotrz
Currently MDL Tabs example suffer with bug. If you go to example and started to play with Tab One, Tab Two you will notice that content (CustomTabBarPanelItemRenderer) is displaying above TabBar. Current usage [1]. Tabs will be rendered first, later TabBar so in the results in HTML code we have st

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-05 Thread piotrz
Hi Guys, Let's leave for a moment isActive property. I've just pushed portion of code related to Tabs to example: 1) Tabs ("mdl-tabs__tab-bar") -> TabBarPanelItemRenderer TabBar ("mdl-tabs__tab") ->TabBarButtonTabsItemRenderer 2) Second case is more specific cause container of tabs is Navigation

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-04 Thread piotrz
Carlos, Om, I go with option 2. I just pushed first initial version, but without update example. I have to figure out how can I tell other tabs unselect. I mean when I click on tab, the rest one should unselect - If anyone has some ide on this one I would be appreciated. I think that it should be

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-03 Thread Alex Harui
IMO, there is no right answer and there doesn't really need to be. There can be many variants of Tabs and TabBars in a component set. Folks will choose the right one for their needs if properly documented. My 2 cents, -Alex On 1/3/17, 3:56 AM, "piotrz" wrote: >Hi, > >I've started to think abo