Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-21 Thread Justin Mclean
Hi, > I went through the RC. Checked in a bunch of spelling errors in SWC > names, README, RELEASE_NOTES. IMO, it wouldn’t be right to release a > Spell Checker with spelling errors in the supporting documentation ;-). We released 1.0 with similar "issues". You could think of it as data to test

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-21 Thread Alex Harui
I went through the RC. Checked in a bunch of spelling errors in SWC names, README, RELEASE_NOTES. IMO, it wouldn’t be right to release a Spell Checker with spelling errors in the supporting documentation ;-). Everything else (LICENSE, NOTICE, build, RAT) all looks fine so I would likely vote to

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-21 Thread Chris Martin
> That incorrect you should only have one of ApacheFlexSpellingUI.swc or ApacheFlexSpellingUIEx.swc, for spark controls you need ApacheFlexSpellingUIEx.swc. These swcs define the same classes so you can only use one at a time. Ahh good to know! Then i'd adjust my first suggested change to the READ

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-21 Thread Justin Mclean
Hi, > Per the README I also have ApacheSpellingUI.swc in my src folder. Is that > right? That incorrect you should only have one of ApacheFlexSpellingUI.swc or ApacheFlexSpellingUIEx.swc, for spark controls you need ApacheFlexSpellingUIEx.swc. These swcs define the same classes so you can onl

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-21 Thread Chris Martin
Justin, Okay after reviewing your email. I was able to get this to work. I took the ApacheSpellingUI.swc out of the src folder, so I only have ApacheSpellingUIEx.swc in my libs folder. And I've added the ApackeFlexLinguisticUtils.swc into my libs folder. After that everything works great! Prop

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-21 Thread Chris Martin
Justin, I also have the following in my lib folder: ApacheSpellingEngine.swc ApacheSpellingUIEx.swc Per the README I also have ApacheSpellingUI.swc in my src folder. Is that right? I noted above you mentioned that it was included in the libs folder. Also you said that you have either ApacheSp

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-21 Thread Justin Mclean
Hi, > Yep, included that in my libs folder per the README. What other swcs do you have in your lib directory? I think you need a minimum of SpellingEngine.swc, SpellingFramework.swc, LinguisticUtils.swf (?) and SpellingUI.swf or SpellingUIEx.swf depending if you have mx or spark controls. I've

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-21 Thread Chris Martin
Justin, >As per the README I think you need to add ApacheFlexSpellingUIEx.swc for it to work with spark >components. Yep, included that in my libs folder per the README. Chris On Mon, Oct 20, 2014 at 2:36 PM, Justin Mclean wrote: > Hi, > > > After including the ApacheFlexSpellingFramework.s

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-21 Thread Justin Mclean
Hi, > Having said that, the consensus within the PMC was to first do a few rounds > of QA without calling a vote for each build. That's the whole point of CTR (commit then review). > Justin didn’t agree and as Release Manager, he is free to handle a release > as he sees fit, however. It not tha

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-21 Thread Erik de Bruin
There has to be at least one vote in order for something to become a release. Having said that, the consensus within the PMC was to first do a few rounds of QA without calling a vote for each build. That way, if a few people ironed out the wrinkles first, likely only one round of voting would be n

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-21 Thread Justin Mclean
Hi, > I thought we were going to skip votes for release candidates ? You need to vote on a RC in order to make it a official release, there's no way that Apache policy (for good reasons). Plus I can't see this release having a large number of RCs unless there's something obvious I'm missing as

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-21 Thread Tom Chiverton
I thought we were going to skip votes for release candidates ? Tom On 20/10/14 04:00, Justin Mclean wrote: Hi, Please place any discussion here and not in the vote thread. Thanks, Justin __ This email has been scanned by the

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-20 Thread Justin Mclean
Hi, > After including the ApacheFlexSpellingFramework.swc in my lib I got past > that error. Maybe we need to add that into the README? As per the README I think you need to add ApacheFlexSpellingUIEx.swc for it to work with spark components. Thanks, Justin

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-20 Thread Chris Martin
Heyo, Trying to test this out in a simple app. I use the same code as above, and I got the following error: VerifyError: Error #1014: Class com.adobe.linguistics.spelling.framework.ui::IHighlighter could not be found. at SquigglyTest/btnCheck_clickHandler()[C:\Users\cmartin\Documents\Adobe Flas

Re: [DISCUSSION] Squiggly 1.1 release candidate 0

2014-10-19 Thread Justin Mclean
Hi, Here's a sample to test out spelling working in spark components: http://ns.adobe.com/mxml/2009"; xmlns:s="library://ns.adobe.com/flex/spark" xmlns:mx="library://ns.adobe.com/flex/mx"> You'll need to add the en_GB dictionary to your project and set up the spelling co