RE: Question about mobile StageText pool

2014-04-24 Thread Maurice Amsellem
igine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : jeudi 24 avril 2014 08:59 À : dev@flex.apache.org Objet : Re: Question about mobile StageText pool I looked a quick look at the commit email. I'll take a look with a real diff tool tomorrow. The only thing I wondered is if savedStage

Re: Question about mobile StageText pool

2014-04-24 Thread Alex Harui
ssed something: >Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/36cece0d > >Maurice > >-Message d'origine- >De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] >Envoyé : mercredi 23 avril 2014 02:12 >À : dev@flex.apache.org >Objet : RE: Question ab

RE: Question about mobile StageText pool

2014-04-23 Thread Maurice Amsellem
llem [mailto:maurice.amsel...@systar.com] Envoyé : mercredi 23 avril 2014 02:12 À : dev@flex.apache.org Objet : RE: Question about mobile StageText pool > I'm surprised that each skin instance doesn't have its own > ScrollableStageText. I would think only the StageText instances are

RE: Question about mobile StageText pool

2014-04-22 Thread Maurice Amsellem
oid having too many savedStageText instances (which would overflow the OS memory). Maybe something like a counter I will sleep on it ... Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mardi 22 avril 2014 19:58 À : dev@flex.apache.org Objet : Re

Re: Question about mobile StageText pool

2014-04-22 Thread Alex Harui
in the pool dictionary. > >Makes sense to you? > >Maurice > >-Message d'origine- >De : Alex Harui [mailto:aha...@adobe.com] >Envoyé : mardi 22 avril 2014 19:20 >À : dev@flex.apache.org >Objet : Re: Question about mobile StageText pool > > > >On

RE: Question about mobile StageText pool

2014-04-22 Thread Maurice Amsellem
referenced in the pool dictionary. Makes sense to you? Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mardi 22 avril 2014 19:20 À : dev@flex.apache.org Objet : Re: Question about mobile StageText pool On 4/22/14 10:07 AM, "Maurice Amsellem&qu

Re: Question about mobile StageText pool

2014-04-22 Thread Alex Harui
On 4/22/14 10:07 AM, "Maurice Amsellem" wrote: >>so detaching skins does not have to be part of the lifecycle. >I agree with that, that's why I was asking about removing listeners, >rather than detaching skins. Is that the same ? >IOW, do you mean that explicitly removing listeners from the sk

RE: Question about mobile StageText pool

2014-04-22 Thread Maurice Amsellem
that principle. But maybe I am too "purist" ;-) WDYT? Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mardi 22 avril 2014 18:34 À  : dev@flex.apache.org Objet : Re: Question about mobile StageText pool I would think that most components do no

RE: Question about mobile StageText pool

2014-04-22 Thread Maurice Amsellem
e I am too "purist" ;-) WDYT? Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mardi 22 avril 2014 18:34 À : dev@flex.apache.org Objet : Re: Question about mobile StageText pool I would think that most components do not use a pool of subcompone

Re: Question about mobile StageText pool

2014-04-22 Thread Alex Harui
closeButton.removeEventListener(MouseEvent.CLICK, >closeButton_clickHandler); >} > >-Message d'origine- >De : Alex Harui [mailto:aha...@adobe.com] >Envoyé : mardi 22 avril 2014 15:12 >À : dev@flex.apache.org >Objet : Re: Question about mobile StageT

RE: Question about mobile StageText pool

2014-04-22 Thread Maurice Amsellem
stance == closeButton) closeButton.removeEventListener(MouseEvent.CLICK, closeButton_clickHandler); } -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mardi 22 avril 2014 15:12 À : dev@flex.apache.org Objet : Re: Question about mobile StageText pool Don't know this cod

Re: Question about mobile StageText pool

2014-04-22 Thread Alex Harui
Don't know this code that well, but when would you trigger detaching of the skin? Doing it on removing from stage would not be right in many cases since the widget could come back on stage later. -Alex On 4/22/14 4:44 AM, "Maurice Amsellem" wrote: >Digging further into TextInput code, I made

RE: Question about mobile StageText pool

2014-04-22 Thread Maurice Amsellem
Digging further into TextInput code, I made some curious findings (at least for me): StageText is not GCed because StyleableStageText sets event listeners on changing, change, enter, events etc... when the skin is attached (in TextInputBase partAdded). 2) these event listeners should be remov