I don’t think those lines would be enough for all MDL controls. We’re only
using a subset.
From: piotrz<mailto:piotrzarzyck...@gmail.com>
Sent: Wednesday, August 2, 2017 2:02 PM
To: dev@flex.apache.org<mailto:dev@flex.apache.org>
Subject: RE: [FlexJS, MDL] Menu with dataProvider and
Yishay,
I think I will create jira and add those css to MDL in order to get rid off
that ugly line with exclusion.
Anyone seeing some danger doing that ?
Thanks,
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
http://apache-flex-development.247.n4.
lt;mailto:dev@flex.apache.org>
Subject: RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API
Hi Yishay,
I've analyzed your stacktrace and I think I understand why it is working in
your app and it is not in MDLExample.
As I remember from Harbs presentation from ApacheCON that your app is us
Hi Yishay,
I've analyzed your stacktrace and I think I understand why it is working in
your app and it is not in MDLExample.
As I remember from Harbs presentation from ApacheCON that your app is using
MDL library along with Basic module.
In general when someone would like to build your applicat
Added the stack trace to the bug.
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/FlexJS-MDL-Menu-with-dataProvider-and-itemRenderer-API-tp57637p63597.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Exact that example is also do not work for me. I don't get change event when
I'm clicking on the item.
It has been swallowed somewhere - That's why I asked you to show me
stacktrace of event.
You can get it once set break point in event handler of change in your menu.
Piotr
-
Apache Flex
Is the example I posted on JIRA working for you?
From: piotrz<mailto:piotrzarzyck...@gmail.com>
Sent: Thursday, July 27, 2017 9:00 AM
To: dev@flex.apache.org<mailto:dev@flex.apache.org>
Subject: RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API
I'm thinking about it
I'm thinking about it more and despite that is working for you I think
something is evidently wrong.
Maybe I have to produce in the MenuView change event. Currently after attach
your ItemRendererMouseController we have click on each renderer.
On the other hand this "change" for some reason do
Yishay,
Could you show me how look like stacktrace in the browser when you click on
the Menu item. I would like to see whole path - who provide you "change"
event in your handler. (myMenu_changeHandler)
Your example is also not working for me.
Thanks,
Piotr
-
Apache Flex PMC
piotrzarzyck.
, thanks.
[1] https://issues.apache.org/jira/browse/FLEX-35344
From: piotrz<mailto:piotrzarzyck...@gmail.com>
Sent: Wednesday, July 26, 2017 11:48 AM
To: dev@flex.apache.org<mailto:dev@flex.apache.org>
Subject: RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API
Ahh...I didn'
Ahh...I didn't understand you then. I thought it is all about click - I
thought that you do not getting "change" event which is suppose to be
reaction on click on item. If I think about it more it could confuse user:
"change" -> "click", but we are using such model in more places, that change
is a
<mailto:piotrzarzyck...@gmail.com>
Sent: Wednesday, July 26, 2017 10:30 AM
To: dev@flex.apache.org<mailto:dev@flex.apache.org>
Subject: Re: [FlexJS, MDL] Menu with dataProvider and itemRenderer API
Yishay,
I did quick look into this problem and not sure what is happening yet.
Please raise
Yishay,
I did quick look into this problem and not sure what is happening yet.
Please raise jira for me where you describe that your code in the example is
working, but this one in MDLExample not.
I will look into that soon.
Thanks,
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
Vi
yishayw wrote
> the example (be051df2bb40fec7d29cf1a934fcbbf19f8d75b7) isn't showing this
> behavior, please have a look
Should be
4eb3eaf38277187919c24b9a6099ec998d4ff627
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/FlexJS-MDL-Menu-with-dataProvider-
Thanks Yishay! I will look into that I hope later today. :)
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/FlexJS-MDL-Menu-with-dataProvider-and-itemRenderer-API-tp57637p63539.html
Sent from the Apache
Piotr,
I changed menu to extend list and am now getting the change event in my test
app [1]. For some reason the example
(be051df2bb40fec7d29cf1a934fcbbf19f8d75b7) isn't showing this behavior,
please have a look if possible.
Peter,
It looks like your change (be051df2bb40fec7d29cf1a934fcbbf19f8d75b
I think that was introduced by Peter after container changes. Could you check
in the history whether earlier Menu extends List ? - If extends earlier
maybe that would be better way to fix that.
Thanks,
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
http:
'change' isn't dispatched. I'll fix it. Can you explain why it extends
DataContainer and not list (which has selectedItem prop and 'change' event)?
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/FlexJS-MDL-Menu-with-dataProvider-and-itemRenderer-API-tp5763
Hi Yishay,
But is it not working when you add "change" handler ? If not try to add to
the Menu class:
[Event(name="change", type="org.apache.flex.events.Event")]
Whatever you are going to do in order to fix that, please update MDLExample
to handle "change" event. If you will not have time to dig
I don't see any event being dispatched by menu. Are we supposed to listen to
the model for events?
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/FlexJS-MDL-Menu-with-dataProvider-and-itemRenderer-API-tp57637p63529.html
Sent from the Apache Flex Developmen
Hi Piotr,
if the Class is the same I don't have any problem to remove the redundant
class. I only was following Peter's ListExample, so If you think is equal
feel free to remove.
Thanks
2017-01-02 15:17 GMT+01:00 piotrz :
> I see only one difference which I think could be moved to
> "DataItemR
I see only one difference which I think could be moved to
"DataItemRendererFactoryForArrayData"
ItemRendererFactoryForArrayData:
var component:UIBase = _strand as UIBase;
ir.labelField = component["labelField"];
DataItemRendererFactoryForArrayData:
labelField = (listView.host as List).labelField;
Carlos,
I just switched your "ItemRendererFactoryForArrayData" to
"DataItemRendererFactoryForArrayData" for list and menu. Everything seems to
be working fine. I think we should use class from core and remove redundant
code.
Maybe try to change it yourself to see whether I didn't miss anything.
Hi Carlos,
I think I have spent enough time yesterday on this. I have removed all code
related to sub menu.
Ad. 1) I just pushed code related to this one
Ad. 2) I have no idea why this started to appear and it's even worst.
Binding is not working totally. I will start separate thread about that -
So cool Piotr :)
if submenus are coming in MDL v2 and now are not supported, I think you
should not spend more time and wait to mdl v2 to implement it and jump to
other thing.
Some things I saw:
1) I didn't see in the new example item "separators" as in the old example.
2) building MDLExample I
Menu has been updated with dataProvider API. :)
Menu class didn't change to much, because it's reusing ListView. I had to
change a bit one place in ListView where there were strand was casted to
List - I saw your comments Carlos in that place - we really need to think
about some interface in the
On Dec 30, 2016 8:31 AM, "Carlos Rovira"
wrote:
In the examples I found there's no sub items, but we should look to see if
there's more. I think that should be supported, if not a menu with only one
level seems very limited to me...
Angular Material has menu with sub menus. We should definit
If I understand correctly it is planned for v2 [1] of MDL. I need to think
about support sub menu. In theory one of my item renderer MenuItem could be
submenu.
[1] https://github.com/google/material-design-lite/issues/4235
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this mess
In the examples I found there's no sub items, but we should look to see if
there's more. I think that should be supported, if not a menu with only one
level seems very limited to me...
2016-12-30 16:54 GMT+01:00 Alex Harui :
>
>
> On 12/30/16, 2:31 AM, "piotrz" wrote:
>
> >In other words our Me
On 12/30/16, 2:31 AM, "piotrz" wrote:
>In other words our Menu will be some kind of MDL List form.
For a simple Menu this should be fine. For a Menu with sub-menus, it will
need many of the things Tree needs. I don't know if MDL has a Tree, or
not.
Just me thinking out loud...
-Alex
Rigth, i'm off and don't hace access to code but I think menu could be a
list and menuitem could be a itemrenderer but be free to experiment :)
El El vie, 30 dic 2016 a las 11:47, piotrz
escribió:
> I went through List implementation and see that contents of data provider
> is
>
> handled
I went through List implementation and see that contents of data provider is
handled by: "IDataProviderItemRendererMapper" implementation. It creates
item renderers for my view.
I think I could go with following implementation:
MenuView will implement IListView or event extends current ListView.
I copied from the Peter example "ListExample"
2016-12-30 11:14 GMT+01:00 piotrz :
> Carlos,
>
> One question why you didn't use "DataItemRendererFactoryForArrayData" from
> core package in List ? You just copied and create new class
> "ItemRendererFactoryForArrayData" - I don't see diffs.
>
> Pio
Carlos,
One question why you didn't use "DataItemRendererFactoryForArrayData" from
core package in List ? You just copied and create new class
"ItemRendererFactoryForArrayData" - I don't see diffs.
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
http://a
2016-12-29 18:41 GMT+01:00 piotrz :
> Hi Carlos,
>
> Since I've finished Snackbar I can take next task. :) I see that Menu need
> to be updated with dataProvider and item renderer API.
> I will probably go same direction as you went with Lists - using
> ISelectionModel. I'm going also introduce in
Hi Alex,
Thanks. That definately make sense to me. I'll try to look deeper into List
or some other component and reuse "selected" or "change". I'm rather
thinking about "change" - cause "selected" brings to mind something which is
constant from UI point of view. When you click on the menu you expe
On 12/29/16, 9:41 AM, "piotrz" wrote:
>Hi Carlos,
>
>Since I've finished Snackbar I can take next task. :) I see that Menu need
>to be updated with dataProvider and item renderer API.
>I will probably go same direction as you went with Lists - using
>ISelectionModel. I'm going also introduce in
37 matches
Mail list logo
