RE: Need advice on patch validation

2013-11-04 Thread Maurice Amsellem
13 09:57 À : dev@flex.apache.org Objet : Re: Need advice on patch validation Hi, > If this is not the general position, we could consider reaching the > same result in some other way? For example, recycling static member > array variables in the helper class to avoid reallocations A g

Re: Need advice on patch validation

2013-11-04 Thread Justin Mclean
Hi, > If this is not the general position, we could consider reaching the same > result in > some other way? For example, recycling static member array variables in the > helper class to avoid reallocations A good suggestion and than would cut down the memory allocation/CG cost, and given that i

RE: Need advice on patch validation

2013-11-04 Thread Maurice Amsellem
ail.com] Envoyé : lundi 4 novembre 2013 09:33 À : Apache Flex Developers ML Objet : Re: Need advice on patch validation Thanks to Benoit, I can see the effort put into these patches. However, in this case, I agree in general with the use of indexOf instead of regexp, and to inlining these meth

RE: Need advice on patch validation

2013-11-04 Thread Maurice Amsellem
FYI, I spent most of my Sunday reviewing the issue... Maurice -Message d'origine- De : Cosma Colanicchia [mailto:cosma...@gmail.com] Envoyé : lundi 4 novembre 2013 09:40 À : Apache Flex Developers ML Objet : Re: Need advice on patch validation ... and also thanks to Justin fo

Re: Need advice on patch validation

2013-11-04 Thread Cosma Colanicchia
for this optimization to happen. >> >> >> (Just my two cents) >> >> [1] http://renaun.com/blog/2012/09/using-the-new-inline-metadata-in-asc2/ >> [2] http://www.bytearray.org/?p=4789 >> >> -- >> Cosma >> >> >> 2013/11/3 Maur

Re: Need advice on patch validation

2013-11-04 Thread Cosma Colanicchia
ttp://www.bytearray.org/?p=4789 > > -- > Cosma > > > 2013/11/3 Maurice Amsellem > >> Thanks Justin >> >> De : Justin Mclean [jus...@classsoftware.com] >> Envoyé : dimanche 3 novembre 2013 22:26 >> À : dev@flex.apache.org >&

Re: Need advice on patch validation

2013-11-04 Thread Cosma Colanicchia
-metadata-in-asc2/ [2] http://www.bytearray.org/?p=4789 -- Cosma 2013/11/3 Maurice Amsellem > Thanks Justin > > De : Justin Mclean [jus...@classsoftware.com] > Envoyé : dimanche 3 novembre 2013 22:26 > À : dev@flex.apache.org > Objet : Re: Ne

Re: Need advice on patch validation

2013-11-03 Thread Justin Mclean
Hi, > What should be the criteria for accepting an optimization proposition ? Does it improve significantly improve performance in real use cases for the majority of users would be at the tip of my list. Calling a method 10,000 times is sometimes not a real use case. > Can we also accept part o

Need advice on patch validation

2013-11-03 Thread Maurice Amsellem
Hi Team, Benoit Wiart has raised the following JIRA : https://issues.apache.org/jira/browse/FLEX-33865 (ConstraintLayout / LayoutElementHelper are memory inefficient and slow) He also proposed a patch to optimize the performance and reduce memory allocations. On behalf on the Apache Flex team