RE: Mustella list tests failing

2013-05-14 Thread Kessler CTR Mark J
Thanks Alex, I was offline a few days. -Mark -Original Message- From: Alex Harui [mailto:aha...@adobe.com] Sent: Sunday, May 12, 2013 2:15 AM To: dev@flex.apache.org Subject: Re: Mustella list tests failing Update: I didn't look into whether validateNow() is truly necessary o

Re: Mustella list tests failing

2013-05-11 Thread Alex Harui
Update: I didn't look into whether validateNow() is truly necessary or not, but in my analysis, it appears that the tests were relying on the list drawing at full alpha before the tween kicks in, which I think would run the risk of a "blink" and Mark's change seems to fix that, so I'm going to go

Re: Mustella list tests failing

2013-05-11 Thread Alex Harui
It was Mark's change for https://issues.apache.org/jira/browse/FLEX-23974 The validateNow() call he added changes the selectiontween timing somehow. The bitmap captures the tween in action which is why the color isn't final. I'll look into it more this evening unless Mark gets to it first. The a

Re: Mustella list tests failing

2013-05-10 Thread Alex Harui
I'm looking into this over the weekend. On 5/1/13 4:27 PM, "Justin Mclean" wrote: > Hi, > >> Well they are all Failed CompareBitmap right? So we just have to track >> down graphical changes? > > > The colour of a selected item seem lighter/more transparent, I had a quick > look through the

Re: Mustella list tests failing

2013-05-01 Thread Justin Mclean
Hi, > Well they are all Failed CompareBitmap right? So we just have to track > down graphical changes? The colour of a selected item seem lighter/more transparent, I had a quick look through the changes and couldn't see anything obvious. I do know it not the Bitmap changes or the 480 dpi chan

Re: Mustella list tests failing

2013-05-01 Thread Mark Kessler
Looking at the images, the only changes seem to be the alpha of the colors? The example one is pure red and the bad one shows the same image except the selection is like 0.10 or such of the alpha? [1] Flex\mustella\tests\components\List\Styles\Baselines\list_listbase_styles_selectionColor_0x.png

Re: Mustella list tests failing

2013-05-01 Thread Mark Kessler
Well they are all Failed CompareBitmap right? So we just have to track down graphical changes? On Wed, May 1, 2013 at 6:11 PM, Justin Mclean wrote: > Hi, > > > = > >Passes: 191 > >Fails: 19 > > =

Re: Mustella list tests failing

2013-05-01 Thread Justin Mclean
Hi, > = >Passes: 191 >Fails: 19 > = Looks like one of the recent changes to the List classes has changed something that the test don't expect. Not sure if it's a real issue or not. Ju

Re: Mustella list tests failing

2013-05-01 Thread Mark Kessler
Ran a mustella test for it [1] and it showed failures [2]. [1] mini_run.sh components/List [2] = Passes: 191 Fails: 19 = components/List/Styles/ListStyleListBaseTester list_listbase_st

Mustella list tests failing

2013-04-30 Thread Justin Mclean
Hi, Just run the list tests like so and I'm getting 19 failures. ./mini_run.sh tests/components/List All are bitmap failures and look like the highlight colour has changed to be lighter. Can anyone confirm these tests pass or fail? Thanks, Justin