Re: FlexJS MXML ids and classNames - FLEX-35310

2017-08-19 Thread piotrz
Alex, Issue #2 is fixed. As for the issue #1 I also don't know how code intelligence is working - maybe Josh will see the post and shed some light on that. Thank you! Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.

Re: FlexJS MXML ids and classNames - FLEX-35310

2017-08-18 Thread Alex Harui
I will have to do more investigation for #1. I don't know if magic properties are the responsibility of the compiler or the IDE's code intelligence. I just pushed a change for #2. It should be using "_id" (with leading underscore) instead of "id". Thanks for catching that, -Alex On 8/17/17, 10

Re: FlexJS MXML ids and classNames - FLEX-35310

2017-08-17 Thread piotrz
Hi Alex, Finally I have found cycle to look into your changes. I've used for tests example from jira. 1) localId is not visible in code completion in Moonshine and Intellij - However everything is building fine. - SDK has been downloaded by installer.

Re: Re: FlexJS MXML ids and classNames - FLEX-35310

2017-08-17 Thread vincent
Bonjour, En congés jusqu'au 4 septembre, je prendrais connaissance de votre message à mon retour. Cordialement, Vincent/AFTER24

Re: FlexJS MXML ids and classNames - FLEX-35310

2017-08-07 Thread Alex Harui
I pushed some code that tries to implement a "localId" property. It seemed to work in a simple test. -Alex On 8/3/17, 10:58 AM, "piotrz" wrote: >Hi All, > >This issue started to be real blocker for my client's application. If we >could ask anyone from compiler sight to try to work on that it w

Re: FlexJS MXML ids and classNames - FLEX-35310

2017-08-03 Thread piotrz
Hi All, This issue started to be real blocker for my client's application. If we could ask anyone from compiler sight to try to work on that it would be awesome and simply help with farther development those app in FlexJS. [1] I think option where we are going with "localID" is ok to me. Alex me

Re: FlexJS MXML ids and classNames - FLEX-35310

2017-07-17 Thread piotrz
Hi Alex, Ok for me personally that's not the problem. I will create that Bead as an addition which helps with that bug. Adding "localId" without touching "id" it can also satisfy my needs and application which was touched by that problem. I would be happy if other opinion appear on that issue.

Re: FlexJS MXML ids and classNames - FLEX-35310

2017-07-17 Thread Alex Harui
Hi Piotr, I still don't think the compiler can tell if you will be using an id more than once. At least not with a lot of flow analysis and even then I think we'd miss cases. You should be able to use the same id more than once. You might be removing the first view and replacing it with a diffe

Re: FlexJS MXML ids and classNames - FLEX-35310

2017-07-17 Thread piotrz
Hi Alex, That's a valid point and I think I'm willing to change my vote to have localId. Let me understand fully this. If we introduce "localId" - - We will be able to have same id in different view - Introducing that new field is less time consuming than doing solution which I vote for ? - Comp

Re: FlexJS MXML ids and classNames - FLEX-35310

2017-07-16 Thread Alex Harui
Well, it makes no sense to me to invent some new property name that sets the "id" of an HTMLElement. I would think we'd get a ton of questions about it. If I"m the only one who thinks that, then I'll stop arguing against it. I thought the consensus upthread was to add localId. -Alex On 7/16/1

Re: FlexJS MXML ids and classNames - FLEX-35310

2017-07-16 Thread piotrz
Josh, In general if I correct understand that was your idea. I think it is the simpler solution where we - Stop set up "id" to HTML id - Introduce new property which will set up it in html +1 for Josh's idea. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message

Re: FlexJS MXML ids and classNames - FLEX-35310

2017-07-15 Thread Josh Tynjala
If we change the behavior of id in MXML, there needs to be a way to force the compiler to make id behave the old way. The compiler is used for more than just compiling FlexJS. For instance, it is used in my VSCode extension, where it provides code intelligence for MXML with the classic Flex SDK and

FlexJS MXML ids and classNames - FLEX-35310

2017-07-15 Thread piotrz
Hi All, I think one of the biggest fish which we should fry is currently issue with duplication id. There need to be changes in compiler which seems to be for someone who really know the code. I would like to get back to the discussion and set up here some final decision. Let's have small vote cau