Re: FlexJS Closure Compiler optimizations

2016-07-20 Thread Harbs
I’m not complaining about the output. I think the work you guys have done with the compiler is superb. :-) However, I do think we should strive to get the output as minified as possible and there’s probably some strategies which we can employ to get the output more compact. I’m not totally cle

Re: FlexJS Closure Compiler optimizations

2016-07-19 Thread Harbs
Yes. It helped a lot! I feel kind of dumb… I was ignoring a runtime error that I thought did not matter. It seems I had a static constant value which relied on a class which was not yet loaded. I made it an instance const instead, and the error went away. The app now loads when minified. What

Re: FlexJS Closure Compiler optimizations

2016-07-19 Thread Alex Harui
On 7/19/16, 1:31 PM, "Harbs" wrote: >I was not getting any errors, but I was getting a lot of warnings. > >I eliminated virtually all the warnings in my code with the exception of >two "WARNING - unreachable code” errors. Eliminating the first one causes >a Falcon compiler error, and the second

Re: FlexJS Closure Compiler optimizations

2016-07-19 Thread Harbs
I was not getting any errors, but I was getting a lot of warnings. I eliminated virtually all the warnings in my code with the exception of two "WARNING - unreachable code” errors. Eliminating the first one causes a Falcon compiler error, and the second appears to be a bug in the Closure compile

Re: FlexJS Closure Compiler optimizations

2016-07-19 Thread Alex Harui
On 7/19/16, 4:19 AM, "Harbs" wrote: >I finally got my app to compile a release version by eliminating my >circular dependencies. So far so good. > >FYI, I fixed this by doing two things: 1. I added a className property >and instead of doing if(this is Sub), I’m using if(this.className == >“Sub”

FlexJS Closure Compiler optimizations

2016-07-19 Thread Harbs
I finally got my app to compile a release version by eliminating my circular dependencies. So far so good. FYI, I fixed this by doing two things: 1. I added a className property and instead of doing if(this is Sub), I’m using if(this.className == “Sub”). 2. I enabled -js-output-optimization=ski