Re: EmailValidator sdk 4.13

2014-08-06 Thread Tom Chiverton
On 06/08/14 01:11, Alex Harui wrote: > All tests pass for me now. That's good news :-) I'll send some example test failures over in a tick, just recompiling the tip of develop here at work. Tom

Re: EmailValidator sdk 4.13

2014-08-05 Thread Alex Harui
All tests pass for me now. Send me a nonsensical bad bitmap off-list and the SWF that produces it so I can see what it looks like. Do you have the embedded font libraries installed in your SDK? -Alex On 8/5/14 2:33 PM, "Tom Chiverton" wrote: >On Tuesday 05 Aug 2014 17:40:37 Alex Harui wrote:

Re: EmailValidator sdk 4.13

2014-08-05 Thread Tom Chiverton
On Tuesday 05 Aug 2014 14:36:38 OmPrakash Muppirala wrote: > for folks to contribute. Please let us know your thoughts on this as > well. I've learnt two things 1) In general, make sure you check the Jenkins Mustella run the day after a checkin. I put the URL on the Wiki just now as I couldn't f

Re: EmailValidator sdk 4.13

2014-08-05 Thread OmPrakash Muppirala
On Tue, Aug 5, 2014 at 2:33 PM, Tom Chiverton wrote: > On Tuesday 05 Aug 2014 17:40:37 Alex Harui wrote: > > Did you update the baseline image for that? It looks like it needs > > updating. > > How's that now ? > I thought I had, but obviously not. > > For some reason here if I run all the Valid

Re: EmailValidator sdk 4.13

2014-08-05 Thread Tom Chiverton
On Tuesday 05 Aug 2014 17:40:37 Alex Harui wrote: > Did you update the baseline image for that? It looks like it needs > updating. How's that now ? I thought I had, but obviously not. For some reason here if I run all the Validator tests, I get nonsensical 'bad' bitmaps e.g. errorTips with no c

Re: EmailValidator sdk 4.13

2014-08-05 Thread Alex Harui
I only got one failure. It was for: Validators/EmailValidator/Properties/Validators_Email_Properties_spark Did you update the baseline image for that? It looks like it needs updating. -Alex On 8/5/14 8:52 AM, "Alex Harui" wrote: >Might be off by only one pixel. There are image compare tools

Re: EmailValidator sdk 4.13

2014-08-05 Thread Alex Harui
Might be off by only one pixel. There are image compare tools in the mustella folder. I just found that by working copy was not syncing. Not sure why. Trying again. -Alex On 8/5/14 8:43 AM, "Tom Chiverton" wrote: >I don't have them, they looked identical though. > >Tom > >On 05/08/14 15:49,

Re: EmailValidator sdk 4.13

2014-08-05 Thread Tom Chiverton
I don't have them, they looked identical though. Tom On 05/08/14 15:49, Alex Harui wrote: > I'm on a Mac, but I tried: > > Managers/StyleManager/AdvancedCSS/descendantSelectors/AdvancedCSS_descendan > tSelectors_RuntimeCSS descendantSelector_basic_noMatch_style_runtimecss > > And > > Validators/E

Re: EmailValidator sdk 4.13

2014-08-05 Thread Alex Harui
I'm on a Mac, but I tried: Managers/StyleManager/AdvancedCSS/descendantSelectors/AdvancedCSS_descendan tSelectors_RuntimeCSS descendantSelector_basic_noMatch_style_runtimecss And Validators/EmailValidator/Properties/Validators_Email_Properties_spark EmailValidator_invalidDomainError_spark And

Re: EmailValidator sdk 4.13

2014-08-05 Thread Tom Chiverton
Did you have any luck ? Last night's Jenkins job exploded early on, but I believe I've fixed the lang pack test failures. Tom On 04/08/14 19:23, Alex Harui wrote: > I'll see if I can repro on my mac. The way handle bitmaps differs based on > the kinds of differences > Sent via the PANTECH Discov

Re: EmailValidator sdk 4.13

2014-08-04 Thread Tom Chiverton
On Monday 04 Aug 2014 10:42:56 OmPrakash Muppirala wrote: > I have relaxed the security settings on the Jenkins instance so that > anonymous users can see the workspace. You should now be able to go to > http://flex-mustella.cloudapp.net/job/flex-sdk_mustella/ws/mustella/ and Much easier, ta. It

Re: EmailValidator sdk 4.13

2014-08-04 Thread Alex Harui
I'll see if I can repro on my mac. The way handle bitmaps differs based on the kinds of differences Sent via the PANTECH Discover, an AT&T 4G LTE smartphone. Tom Chiverton wrote: On Thursday 31 Jul 2014 16:32:01 Alex Harui wrote: > Try using your Linux box. Often there is no difference betwee

Re: EmailValidator sdk 4.13

2014-08-04 Thread OmPrakash Muppirala
I have relaxed the security settings on the Jenkins instance so that anonymous users can see the workspace. You should now be able to go to http://flex-mustella.cloudapp.net/job/flex-sdk_mustella/ws/mustella/ and look through the tests and its folders. I believe you are looking for: http://flex-m

Re: EmailValidator sdk 4.13

2014-08-04 Thread Tom Chiverton
On Thursday 31 Jul 2014 16:32:01 Alex Harui wrote: > Try using your Linux box. Often there is no difference between platforms. > Usually gradients cause the differences so simplifying the graphics may > help. It looks like there are bitmap differences in Jenkins for Validators/EmailValidator/Pr

Re: EmailValidator sdk 4.13

2014-07-31 Thread Alex Harui
Try using your Linux box. Often there is no difference between platforms. Usually gradients cause the differences so simplifying the graphics may help. On 7/31/14 5:42 AM, "Tom Chiverton" wrote: >Changing the EmailValidator causes Mustella test failures; so my change >also needs to update the

Re: EmailValidator sdk 4.13

2014-07-31 Thread Chris Martin
I think that change would be good :) On Thu, Jul 31, 2014 at 5:42 AM, Tom Chiverton wrote: > Changing the EmailValidator causes Mustella test failures; so my change > also needs to update the tests (to expect valid, rather than invalid). > And then I need to save new basline images - Will it be

Re: EmailValidator sdk 4.13

2014-07-31 Thread Tom Chiverton
Changing the EmailValidator causes Mustella test failures; so my change also needs to update the tests (to expect valid, rather than invalid). And then I need to save new basline images - Will it be OK taking these from my Linux box (i.e. rename the .bad.png) or do they have to come from Windows as

Re: EmailValidator sdk 4.13

2014-07-31 Thread Justin Mclean
Hi, > Any objection to that fix ? +1 from me Justin

Re: EmailValidator sdk 4.13

2014-07-31 Thread Tom Chiverton
I've raised a Jira for this issue : https://issues.apache.org/jira/browse/FLEX-34450 Tom On 22/07/14 17:43, Harbs wrote: > Here’s a very good reference on the topic: > http://www.regular-expressions.info/email.html > > On Jul 22, 2014, at 6:24 PM, Alex Harui wrote: > >> We should do both, at som

Re: EmailValidator sdk 4.13

2014-07-31 Thread Tom Chiverton
I've raised a Jira for this issue : I intend to submit a patch that removes this block if (lastDomain.length != 3 && lastDomain.length != 2 && lastDomain.length != 4 &&

Re: EmailValidator sdk 4.13

2014-07-22 Thread Harbs
Here’s a very good reference on the topic: http://www.regular-expressions.info/email.html On Jul 22, 2014, at 6:24 PM, Alex Harui wrote: > We should do both, at some point. > > On 7/22/14 5:30 AM, "Tom Chiverton" wrote: > >> I think we have two choices, either validate to the spec ( RFC 5322,

Re: EmailValidator sdk 4.13

2014-07-22 Thread Alex Harui
We should do both, at some point. On 7/22/14 5:30 AM, "Tom Chiverton" wrote: >I think we have two choices, either validate to the spec ( RFC 5322, >like http://www.ex-parrot.com/~pdw/Mail-RFC822-Address.html ) or use >something more relaxed. > >By more relaxed I mean split('@').length==2 && >spl

Re: EmailValidator sdk 4.13

2014-07-22 Thread Tom Chiverton
I think we have two choices, either validate to the spec ( RFC 5322, like http://www.ex-parrot.com/~pdw/Mail-RFC822-Address.html ) or use something more relaxed. By more relaxed I mean split('@').length==2 && split('@')[1].split('.').length>1 As Wikipedia says "Syntactically correct, verified emai

Re: EmailValidator sdk 4.13

2014-07-22 Thread Justin Mclean
HI, > Does any one know why it isn't just using the proper regular expression ? Because there is no regular expression that validates all email addresses and even if it did they can still be invalid. See [1] for a good discussion - and some scary regular expressions. Justin 1. http://stackov

Re: EmailValidator sdk 4.13

2014-07-22 Thread Tom Chiverton
Does any one know why it isn't just using the proper regular expression ? Tom On 22/07/14 12:19, Justin Mclean wrote: > Hi, > >> mx.validators.EmailValidator does not accept ".email" domain > Want to raise a JIRA? Looks like lines 220-223 cause the issue. > > if (lastDomain.length != 3 && >

Re: EmailValidator sdk 4.13

2014-07-22 Thread Justin Mclean
Hi, > mx.validators.EmailValidator does not accept ".email" domain Want to raise a JIRA? Looks like lines 220-223 cause the issue. if (lastDomain.length != 3 && lastDomain.length != 2 && lastDomain.length != 4 && lastDomain.length != 6) { results.push(new Validati

EmailValidator sdk 4.13

2014-07-22 Thread Jan Komadowski
Hi, mx.validators.EmailValidator does not accept ".email" domain -- View this message in context: http://apache-flex-development.247.n4.nabble.com/EmailValidator-sdk-4-13-tp39263.html Sent from the Apache Flex Development mailing list archive at Nabble.com.