Re: DateField Issues and fixes

2013-04-21 Thread Justin Mclean
Hi, Thanks for that I take a look tomorrow. I have to ask did you write all the code yourself and are able to donate it to Apache Flex? From what I can see it's under a Apache style licence already. https://github.com/JabbyPanda/DateField4/blob/master/LICENSE Thanks, Justin

Re: DateField Issues and fixes

2013-04-21 Thread Andriy Panas
Hi Justin, FYI, few years ago, I did a closer examination of existing limitations of current DateFormatter from Flex3 and suggested a few fixes for the following issues (old JIRA numeration): Fixed SDK-23069 [Localization]: DateFormatter.parseDateStr

Re: DateField Issues and fixes

2013-04-19 Thread Alex Harui
On 4/19/13 5:28 PM, "Justin Mclean" wrote: > > Alex if you could review the tests as I'm not 100% familiar with Mustella I'd > appreciate it. > Looks like the right pattern for testing methods. Good job! -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui

Re: DateField Issues and fixes

2013-04-19 Thread Justin Mclean
Hi, > Thanks. Do you have time to add some more tests? Added 40 odd tests to check various formats and check invalid inputs. https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=commitdiff;h=531f7f2fe7aa72fa3c998d76c2de7b9b1761ee03 All test pass. If anyone can suggest other tests go ahead

Re: DateField Issues and fixes

2013-04-18 Thread Justin Mclean
Hi, > Thanks. Do you have time to add some more tests? Mastella test no as I'm not 100% familiar with them yet. I tested locally with about 50 combinations of formats and dates. I run against 4.9 and 4.10 and diffed the trace output to see what had changed. Here the rough test code I used - i

Re: DateField Issues and fixes

2013-04-18 Thread Alex Harui
Thanks. Do you have time to add some more tests? On 4/18/13 8:42 PM, "Justin Mclean" wrote: > Hi, > > I've been looking at DataField and it has a few problems mostly how it dealing > with format string parsing in stringToDate and dateToString static methods. > > There are several unresolved

DateField Issues and fixes

2013-04-18 Thread Justin Mclean
Hi, I've been looking at DataField and it has a few problems mostly how it dealing with format string parsing in stringToDate and dateToString static methods. There are several unresolved JIRA issues around this component. Some of the issues include. 1. Poor support of "M" and "D" vs "MM" and