Re: Circular dependencies (was: Re: Closure compiler CompilationLevel)

2016-01-04 Thread Alex Harui
FWIW, the compiler currently generates a set of goog.requires based on the set of class dependencies a source file needed to resolve in order to compile a file, but IMO that is often a larger set of requires than is actually needed by the goog.requires subsystem and by the JS runtimes. For example

Re: Circular dependencies (was: Re: Closure compiler CompilationLevel)

2016-01-04 Thread Andy Dufilie
On Thu, Dec 31, 2015 at 2:42 AM, Alex Harui wrote: > > On 12/30/15, 10:31 PM, "Andy Dufilie" wrote: > >- When I run flexjs/js/bin/compc I get a bin-release folder with the JS > >output files. I then try to run closure manually on these files, and I > >get > >circular dependency errors for my co

Re: JS.SWC source (was: Re: Closure compiler CompilationLevel)

2016-01-01 Thread Andy Dufilie
On Fri, Jan 1, 2016 at 3:28 AM, Alex Harui wrote: > The externc.createjs.swc target calls another ant script that munges the > externs. You could try doing that temporarily for the externc.js.swc > target. > > Oops, I was looking at the wrong target. I see the externc.js.swc target now - it comp

Re: JS.SWC source (was: Re: Closure compiler CompilationLevel)

2016-01-01 Thread Alex Harui
On 12/31/15, 8:15 PM, "Andy Dufilie" wrote: > > >I can see that the "externc.js.swc" build target in flex-falcon/build.xml >generates js.swc and that flex-falcon/externs/js/js-compile-config.xml >specifies which google closure extern files to use, but the >closure-compiler files (es3.js, etc) a

JS.SWC source (was: Re: Closure compiler CompilationLevel)

2015-12-31 Thread Andy Dufilie
On Thu, Dec 31, 2015 at 5:41 PM, Andy Dufilie wrote: > Now that I can compile with js.swc, I am getting a lot of errors because > the type information for many JS functions is incorrect. For example, it > says Array's sort() is a void function. Where is the source code for js.swc > so that I can

Re: Closure compiler CompilationLevel

2015-12-31 Thread Andy Dufilie
On Thu, Dec 31, 2015 at 12:17 PM, Josh Tynjala wrote: > You might try using asjsc instead of mxmlc if you want to compile with > JS.swc. > > - Josh > I had tried that before through Flash Builder but it was giving me an error ("Unsupported major.minor version 51.0"). I looked at it again and fo

Re: Closure compiler CompilationLevel

2015-12-31 Thread Josh Tynjala
You might try using asjsc instead of mxmlc if you want to compile with JS.swc. - Josh On Dec 30, 2015 10:32 PM, "Andy Dufilie" wrote: > On Wed, Dec 30, 2015 at 1:05 PM, Alex Harui wrote: > > > Try: -js-compiler-option="--compilation_level WHITESPACE_ONLY" > > > That worked after fixing the spec

Re: Closure compiler CompilationLevel

2015-12-30 Thread Alex Harui
On 12/30/15, 10:31 PM, "Andy Dufilie" wrote: >On Wed, Dec 30, 2015 at 1:05 PM, Alex Harui wrote: > >> Try: -js-compiler-option="--compilation_level WHITESPACE_ONLY" > > >That worked after fixing the special characters. Is there a place that >options like this are documented? Hmm. I guess not

Re: Closure compiler CompilationLevel

2015-12-30 Thread Andy Dufilie
On Wed, Dec 30, 2015 at 1:05 PM, Alex Harui wrote: > Try: -js-compiler-option="--compilation_level WHITESPACE_ONLY" That worked after fixing the special characters. Is there a place that options like this are documented? Now that I'm compiling via flexjs/js/bin/mxmlc using the WHITESPACE_ONLY

Re: Closure compiler CompilationLevel

2015-12-30 Thread Alex Harui
Try: -js-compiler-option=“—compilation_level WHITESPACE_ONLY” On 12/30/15, 9:28 AM, "adufilie" wrote: >The forum formatting in my previous message caused part of the text to be >omitted on the mailing list. The full message is below. If the forum >interface happens to omit the quoted text then

Re: Closure compiler CompilationLevel

2015-12-30 Thread adufilie
tput-type=FLEXJS -sdk-js-lib=C:\flexjs\js\bin\..\..\frameworks\js\FlexJS\src -js-closure-compilation-level=WHITESPACE_ONLY -fb C:\Weave\WeaveJS/src/WeaveJS.as command line unknown configuration variable 'js-closure-compilation-level'. -- View this message in context: http://apa

Re: Closure compiler CompilationLevel

2015-12-30 Thread adufilie
lation-level> , so I tried adding -js-closure-compilation-level=WHITESPACE_ONLY to my mxmlc build command. This is the result: -- View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Closure-compiler-CompilationLevel-tp49289p50865.html Sent from the Apache

Re: Closure compiler CompilationLevel

2015-09-22 Thread Josh Tynjala
I think a prefix is acceptable. - Josh On Tue, Sep 22, 2015 at 8:34 AM, Alex Harui wrote: > > > On 9/22/15, 7:25 AM, "Josh Tynjala" wrote: > > >No, this particular option of the Closure compiler is currently > >hard-coded. > > > >As for making it a compile-time option, we should keep in mind t

Re: Closure compiler CompilationLevel

2015-09-22 Thread Alex Harui
On 9/22/15, 7:25 AM, "Josh Tynjala" wrote: >No, this particular option of the Closure compiler is currently >hard-coded. > >As for making it a compile-time option, we should keep in mind that not >all >emitters will necessarily use Closure compiler in the future. This may >affect how the option

Re: Closure compiler CompilationLevel

2015-09-22 Thread Josh Tynjala
No, this particular option of the Closure compiler is currently hard-coded. As for making it a compile-time option, we should keep in mind that not all emitters will necessarily use Closure compiler in the future. This may affect how the option should be named, or how it gets parsed and validated

Re: Closure compiler CompilationLevel

2015-09-22 Thread Harbs
Makes sense to me. Of course I have not deep-dived into this stuff yet. It seems to me that these levels should be a compile-time option which could be easily changed. Is that the case now? Harbs On Sep 22, 2015, at 9:37 AM, Josh Tynjala wrote: > The Closure compiler has three compilation lev

Closure compiler CompilationLevel

2015-09-21 Thread Josh Tynjala
The Closure compiler has three compilation levels. CompilationLevel.WHITESPACE_ONLY CompilationLevel.SIMPLE_OPTIMIZATIONS CompilationLevel.ADVANCED_OPTIMIZATIONS Right now, JSClosureCompilerWrapper specifies the ADVANCED_OPTIMIZATIONS compilation level. This level changes the code the most, but i