Re: [SpriteFlexJS] new Lizhi's SpriteFlexJs branch

2017-02-22 Thread Justin Mclean
Hi, > As I said, hope Lizhi wants to incorporate this folder refactor, license > headers and finaly as it's prepared, come with the project to Apache Flex. > I think it would be a great add to the project. There are some IP issues with that source code they would need to be sorted first. Basica

Re: [SpriteFlexJS] new Lizhi's SpriteFlexJs branch

2017-02-22 Thread Carlos Rovira
Hi, just forked the Lizhi's project in GitHub, created a "maven-refactor" branch in my fork and uploaded what I have done. Then removed the branch in our repo and finaly email Lizhi to let him know about the maven refactor effort and the link with that refactor. Now I still need to end refactor o

Re: [SpriteFlexJS] new Lizhi's SpriteFlexJs branch

2017-02-22 Thread Harbs
Sounds like a good plan. :-) > On Feb 22, 2017, at 7:48 PM, Carlos Rovira > wrote: > > Ok, I'll remove the branch and talk with Lizhi about import my changes in > his repo > > thanks > > 2017-02-22 18:34 GMT+01:00 Harbs : > >> The project needs a full audit before we can import anything. >>

Re: [SpriteFlexJS] new Lizhi's SpriteFlexJs branch

2017-02-22 Thread Carlos Rovira
Ok, I'll remove the branch and talk with Lizhi about import my changes in his repo thanks 2017-02-22 18:34 GMT+01:00 Harbs : > The project needs a full audit before we can import anything. > > It seems like many files came from playerglobal.swc which we cannot use. > > Thanks, > Harbs > > > On F

Re: [SpriteFlexJS] new Lizhi's SpriteFlexJs branch

2017-02-22 Thread Harbs
The project needs a full audit before we can import anything. It seems like many files came from playerglobal.swc which we cannot use. Thanks, Harbs > On Feb 22, 2017, at 7:08 PM, Alex Harui wrote: > > At one point in time, were files in Lizhi's repo like Matrix.as that are > not allowed in ou

Re: [SpriteFlexJS] new Lizhi's SpriteFlexJs branch

2017-02-22 Thread Alex Harui
At one point in time, were files in Lizhi's repo like Matrix.as that are not allowed in our repo because of the way they were "authored". Those files would need to be replaced by correctly authored files before we can import them into one of our repos, and we should get a grant document signed by

Re: [SpriteFlexJS] new Lizhi's SpriteFlexJs branch

2017-02-22 Thread Carlos Rovira
Hi Alex, I uploaded updated repo with license header (so all classes changed) to our repos in order to prepare a possible integration in our branch. The problem is that we can add the code at all in any branch? or we can add this changed codebase in order to see if we can hold it and of course get

Re: [SpriteFlexJS] new Lizhi's SpriteFlexJs branch

2017-02-22 Thread Alex Harui
On 2/22/17, 7:48 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >Hi, > >it seems that with Chris changes Lizhi's SpriteFlexJS project start to >compile without problem. >I imported the lasted codebase and updated all classes with LICENSE >headers >in order to be able to compile

[SpriteFlexJS] new Lizhi's SpriteFlexJs branch

2017-02-22 Thread Carlos Rovira
Hi, it seems that with Chris changes Lizhi's SpriteFlexJS project start to compile without problem. I imported the lasted codebase and updated all classes with LICENSE headers in order to be able to compile. I created a new branch due to problems with the last one: "feature/sprite-refactor" I must