Github user Harbs commented on the issue:
https://github.com/apache/flex-asjs/pull/10
Sounds good. I was going to merge this today, but I'll wait for your
updates.
The only way for me to close pull requests is to add a commit (because this
is just a mirror of the Apache repo)
Github user greg-dove commented on the issue:
https://github.com/apache/flex-asjs/pull/10
Harbs, I have a number of improvements, including performance improvements,
and one bug fix (writeUTF was not respecting the endian setting for the
prepended string length) that supersede this re
Github user greg-dove commented on the issue:
https://github.com/apache/flex-asjs/pull/10
I just read back on the other comments, some of which I had missed seeing
before my earlier reply. If defaulting to big endian is necessary on js for
consistency, that's easy simply by chan
Harbs,
FYI the changes I made do not alter the behavior that was there originally,
but they do provide the user with more information, and also retain the
optimal code path after a BinaryData has had an explicit endian value set.
Flash continues to default to BIG_ENDIAN as before. I don't actual
Github user adufilie commented on the issue:
https://github.com/apache/flex-asjs/pull/10
Thanks for the link, Harbs. I mistakenly thought this code was only related
to ByteArray. Now I see that it's actually writing to an ArrayBuffer in
JavaScript.
---
If your project is set up for
Github user aharui commented on the issue:
https://github.com/apache/flex-asjs/pull/10
Someday, we can have a BinaryDataForGPU class with native defaults. Or
make more classes like BinaryDataLittleEndian and BinaryDataBigEndian. No need
to figure it out all in a single class.
---
Github user Harbs commented on the issue:
https://github.com/apache/flex-asjs/pull/10
The thing is: Endianness based on the hardware was done for a reason:
http://calculist.org/blog/2012/04/24/the-little-endian-web/
Basically, if the data is being used for GPU drawing, it n
Github user adufilie commented on the issue:
https://github.com/apache/flex-asjs/pull/10
The default should be big endian ("network byte order") used by java and
flash.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user Harbs commented on the issue:
https://github.com/apache/flex-asjs/pull/10
I gave this a quick look-over. The only issue that I noticed was that the
default behavior of Endianess is different between Flash and JS.
In Flash, the default is bin endian, while in JS, th
