Re: [FlexJS Typedefs]FileReader

2017-03-18 Thread Josh Tynjala
I'd be cool with that! I don't like adding that extra argument to addEventListener() calls. - Josh On Sat, Mar 18, 2017 at 1:45 PM, Harbs wrote: > Thanks. > > I noticed that it was a general problem after I posted this question. > > Maybe we should patch the extern file? > > > On Mar 18, 2017,

Re: [FlexJS Typedefs]FileReader

2017-03-18 Thread Harbs
Thanks. I noticed that it was a general problem after I posted this question. Maybe we should patch the extern file? > On Mar 18, 2017, at 10:24 PM, Josh Tynjala wrote: > > It's not optional on the base interface where addEventListener() and > removeEventListener() are defined. I think it's Ev

Re: [FlexJS Typedefs]FileReader

2017-03-18 Thread Josh Tynjala
It's not optional on the base interface where addEventListener() and removeEventListener() are defined. I think it's EventTarget. Since subclasses and implementers of interfaces aren't allowed to change the signature of a method in ActionScript, externc uses the original signature and ignores the o

[FlexJS Typedefs]FileReader

2017-03-18 Thread Harbs
I found what looks like a bug in the FileReader typedefs: The following in fileapi.js: /** * @param {boolean=} opt_useCapture * @override * @return {undefined} */ FileReader.prototype.addEventListener = function(type, listener, opt_useCapture) {}; /** * @param {boolean=} opt_useCapture