Re: [FlexJS]Layout redux

2017-02-25 Thread Alex Harui
On 2/25/17, 6:33 AM, "Peter Ent" wrote: >Maybe we need a big refactor. Things like effects are pretty advanced and >maybe they should get coupled with more advanced/complex layouts that are >in a different package than HTML. Well, I don't know how to define "big", but we do need to get it righ

Re: [FlexJS]Layout redux

2017-02-25 Thread Peter Ent
Maybe we need a big refactor. Things like effects are pretty advanced and maybe they should get coupled with more advanced/complex layouts that are in a different package than HTML. The basic packages could be simpler layouts that do minimal settings. The HTML package could be JS only and just

Re: [FlexJS]Layout redux

2017-02-24 Thread Alex Harui
On 2/24/17, 10:37 PM, "Yishay Weiss" wrote: >One more thing to consider is how effects will fit in here. I can imagine >scenarios where items inside of a container need to have an effect >applied to them. Currently, the move effect relies on changing x, y >values, which implies absolute positio

RE: [FlexJS]Layout redux

2017-02-24 Thread Yishay Weiss
Subject: Re: [FlexJS]Layout redux Hi, I've pushed an update to the HorizontalFlexLayout and VerticalFlexLayout that adds code for the SWF side. In general, the SWF and JS sides look the same. There are some differences which I'm working on, but these should be usable. In doing th

Re: [FlexJS]Layout redux

2017-02-24 Thread Alex Harui
On 2/24/17, 11:42 AM, "Peter Ent" wrote: >Hi, > >I've pushed an update to the HorizontalFlexLayout and VerticalFlexLayout >that adds code for the SWF side. In general, the SWF and JS sides look the >same. There are some differences which I'm working on, but these should be >usable. Sounds pro

Re: [FlexJS]Layout redux

2017-02-24 Thread Peter Ent
Hi, I've pushed an update to the HorizontalFlexLayout and VerticalFlexLayout that adds code for the SWF side. In general, the SWF and JS sides look the same. There are some differences which I'm working on, but these should be usable. In doing this I've uncovered some incomplete work and/or expo

Re: [FlexJS]Layout redux

2017-02-23 Thread Peter Ent
On 2/23/17, 1:54 AM, "Alex Harui" wrote: >A few comments/questions: > >What does flex-box do when it runs out of room? Doesn't it wrap to a new >row/column? Or can that be controlled? I think most folks expect >VerticalLayout to not create a new column but to keep going vertically and >be cl

Re: [FlexJS]Layout redux

2017-02-22 Thread Harbs
I just checked. I have 24 classes with position: absolute and 16 classes with position: relative in a responsive app we use for PrintUI. The default for the app is absolute. It also has three media queries to set the percentage size of the main (relative) sections for responsive layout. It also

Re: [FlexJS]Layout redux

2017-02-22 Thread Alex Harui
A few comments/questions: What does flex-box do when it runs out of room? Doesn't it wrap to a new row/column? Or can that be controlled? I think most folks expect VerticalLayout to not create a new column but to keep going vertically and be clipped or scrolled. On the SWF side, I am hopefully

Re: [FlexJS]Layout redux

2017-02-22 Thread Peter Ent
Great. Thanks. I will take a look at these tomorrow. ‹peter On 2/22/17, 5:19 PM, "Harbs" wrote: >This too: >https://philipwalton.github.io/solved-by-flexbox/ > >> On Feb 23, 2017, at 12:16 AM, Harbs wrote: >> >> BTW, this might be useful: >> https://github.com/philipwalton/flexbugs >>

Re: [FlexJS]Layout redux

2017-02-22 Thread Peter Ent
First, I like the idea of moving as much into CSS as possible, at least to the extent we can support in on the SWF side. Secondly, I think the layouts setting the display makes sense in this case, based on what Harbs said. I was thinking of this: A. UIBase does not set position and display. The

Re: [FlexJS]Layout redux

2017-02-22 Thread Harbs
This too: https://philipwalton.github.io/solved-by-flexbox/ > On Feb 23, 2017, at 12:16 AM, Harbs wrote: > > BTW, this might be useful: > https://github.com/philipwalton/flexbugs > > >> On Feb 23, 2017, at 12:08 AM, Harbs >

Re: [FlexJS]Layout redux

2017-02-22 Thread Harbs
BTW, this might be useful: https://github.com/philipwalton/flexbugs > On Feb 23, 2017, at 12:08 AM, Harbs wrote: > > How well do these work in IE? > > It looks like Flexbox is not supported at all in IE prior to IE10 and even in > IE10 and 11, it only has buggy support.[1] > > [1]http://caniu

Re: [FlexJS]Layout redux

2017-02-22 Thread Harbs
For that to work, the bead will need to append the class name of the component. It cannot be applied to the bead itself. Harbs > On Feb 23, 2017, at 12:05 AM, Carlos Rovira > wrote: > > Hi Peter, > > one of the things I'd want to do is remove "styles" in source code and move > to css. > For

Re: [FlexJS]Layout redux

2017-02-22 Thread Harbs
How well do these work in IE? It looks like Flexbox is not supported at all in IE prior to IE10 and even in IE10 and 11, it only has buggy support.[1] [1]http://caniuse.com/#feat=flexbox > On Feb 22, 2017, at 11:40 PM, Peter Ent wrote: > > I just pushed new layouts: VerticalFlexLayout and Hor

Re: [FlexJS]Layout redux

2017-02-22 Thread Carlos Rovira
Hi Peter, one of the things I'd want to do is remove "styles" in source code and move to css. For example: viewBead.contentView.element.style["display"] = "flex"; What do you think about to move this to default.css class, i.e.: HorizontalFlexLayout { display: flex; ... } I think we should m

Re: [FlexJS]Layout redux

2017-02-22 Thread Harbs
I totally agree with this. There should be a simple Container (with H and V variants) and a separate ChromeContainer. The vast majority of Containers do not need the extra div. Moving Panel to Express is an option, but I’m not sure it’s necessary. > On Feb 22, 2017, at 11:40 PM, Peter Ent wrot

Re: [FlexJS]Layout redux

2017-02-22 Thread Carlos Rovira
Hi Peter, although I still not look into the code, that seems very promising. As you say we need a component with just one div, and then we could have more of then for chrome and other things. in old Flex Group was a container that doesn't have the width of subitems into account, so maybe the Flex

Re: [FlexJS]Layout redux

2017-02-22 Thread Peter Ent
Hi, I just pushed new layouts: VerticalFlexLayout and HorizontalFlexLayout as well as a change to DataBindingExample to use them. I consider these temporary and would like to make them be the VerticalLayout and HorizontalLayout in the near future. If you look at their code you will see the COMPIL

Re: [FlexJS]Layout redux

2017-02-22 Thread Carlos Rovira
Hi Peter, that sound very good :) thanks! 2017-02-22 16:53 GMT+01:00 Peter Ent : > That's a good strategy. My experiments this morning look like Flexbox is > the way to go. Its widely supported now and seems pretty easy to use. > > I'm going to create VerticalFlexLayout and HorizontalFlexLayout a

Re: [FlexJS]Layout redux

2017-02-22 Thread Peter Ent
That's a good strategy. My experiments this morning look like Flexbox is the way to go. Its widely supported now and seems pretty easy to use. I'm going to create VerticalFlexLayout and HorizontalFlexLayout and have them extend the current versions just so the SWF side stays the same for right now

Re: [FlexJS]Layout redux

2017-02-22 Thread Carlos Rovira
That looks very promising Peter. Look forward to see some progress :) If flexbox is the future, I think we should always look to go with that specs, and in case that still is not in some browsers, search for a polyfill that could do the job for not supported browsers for now. At the end browsers wi

Re: [FlexJS]Layout redux

2017-02-22 Thread Peter Ent
I'm going to try some experiments in my own space. Basically, figuring out the best way to do simple layouts using CSS - vertical and horizontal with alignment options (center, left, right for vertical, top, middle, bottom for horizontal). Because alignment will probably require more cycles when im

Re: [FlexJS]Layout redux

2017-02-22 Thread Harbs
> On Feb 22, 2017, at 9:46 AM, Alex Harui wrote: > > It is probably time for our annual "revisiting of the layout code". I > think if you look at source code history, Peter or I do this every so > often as we get more examples to work with. > > From memory, there are issues like whether we hav

Re: [FlexJS]Layout redux

2017-02-22 Thread yishayw
using absolute positioning? It would have the benefit of being easier to maintain, as bugs would probably appear in both versions and fixed together. There can also be more code reused across implementations. -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJ

Re: [FlexJS]Layout redux

2017-02-21 Thread Alex Harui
It is probably time for our annual "revisiting of the layout code". I think if you look at source code history, Peter or I do this every so often as we get more examples to work with. From memory, there are issues like whether we have to set position:relative or not that came out of the MDL swc.

Re: [FlexJS]Layout redux

2017-02-21 Thread piotrz
+1 for that. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Layout-redux-tp59725p59736.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS]Layout redux

2017-02-21 Thread Justin Mclean
Hi, > Yishay just mentioned the fact that padding is not working It not working for me either - see https://issues.apache.org/jira/browse/FLEX-35274 > This seems totally wrong. Why is the padding being added when we’re using > box-sizing: border-box? Also seems wrong to me. > 3. Percentage s

Re: [FlexJS]Layout redux

2017-02-21 Thread Peter Ent
I think this is generally a good approach. I've been thinking that we have some refactoring to do which might help. For instance, Core should probably be edited to include interfaces, events, and whatever else works across all packages. HTML should probably be just the HTML classes (Div, H1, TextN

Re: [FlexJS]Layout redux

2017-02-21 Thread Carlos Rovira
Hi Peter, it seems HTML rely for this task heavily on CSS to the point that almost nothing is done in html or js code. So maybe we are not in the right way for HTML platform and we should make our code be mainly CSS. An example is here: https://css-tricks.com/snippets/sass/placing-items-circle/

Re: [FlexJS]Layout redux

2017-02-21 Thread Peter Ent
A lot of this work is mine and it seems to need to be thought through once again. The dichotomy of SWF & JS has presented problems for me in the past. Maybe the layouts, for JS platform, should do as little as possible, replying on CSS as much as possible. Then make the SWF platform mimic that. O

[FlexJS]Layout redux

2017-02-21 Thread Harbs
We’re really struggling with layout. Yishay just mentioned the fact that padding is not working, but the problems seem to go much deeper than that. 1. VerticalLayout has the following code: for (i = 0; i < n; i++) {