Re: [FlexJS] Optimizing the maven build ... success ...

2016-11-04 Thread Alex Harui
All good from the Ant side. Thanks, -Alex On 11/4/16, 2:34 AM, "Christofer Dutz" wrote: >Ok I did the merge and I hopefully fixed an issue Alex mentioned with >„closure/closure“ directory structure. >@Carlos Rovira ... please give it another try (as soon as jenkins is >finished with it) >@Alex

Re: [FlexJS] Optimizing the maven build ... success ...

2016-11-04 Thread Carlos Rovira
Hi Chris, just tried and working again. Thanks for you blazing fast action! :) sweet 4sec builds :) 2016-11-04 10:34 GMT+01:00 Christofer Dutz : > Ok I did the merge and I hopefully fixed an issue Alex mentioned with > „closure/closure“ directory structure. > @Carlos Rovira ... please give it an

Re: [FlexJS] Optimizing the maven build ... success ...

2016-11-04 Thread Christofer Dutz
Ok I did the merge and I hopefully fixed an issue Alex mentioned with „closure/closure“ directory structure. @Carlos Rovira ... please give it another try (as soon as jenkins is finished with it) @Alex Harui ... please give the Ant build another try If the ant issue is fixed, I think I could me

Re: [FlexJS] Optimizing the maven build ... success ...

2016-11-04 Thread Carlos Rovira
Ok Chris, currently the branch is no longer usable due to some changes by Alex yesterday 2c8becbcb22052105d8a614196f1d36db6b909ec if you try to rebase on top of develop it throws 69 conflicts Hope you could get it work again since is hard to get back to 44secs vs 4secs buildings ;) 2016-11-0

Re: [FlexJS] Optimizing the maven build ... success ...

2016-11-03 Thread Christofer Dutz
Hi Carlos, I didn’t want to merge it back without getting confirmation, that it doesn’t break things for all non-maven builds. I think there still is an issue, which I will have to figgure out as soon as I can find the time (Unfortunatlely I currently have a paid-project which I actually have t

Re: [FlexJS] Optimizing the maven build ... success ...

2016-11-03 Thread Carlos Rovira
Hi Chris, I'm using the "closure-classpath-sources" branch, taking into account the fast it makes me build, I was wondering what's the problem to merge it to develop. Hope it was a matter of tiny things and could be integrated soon. Thanks Carlos 2016-10-31 16:40 GMT+01:00 Alex Harui : > > > O

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-31 Thread Alex Harui
On 10/31/16, 8:36 AM, "Christofer Dutz" wrote: >Hi Alex, > >Well I had another look at the original code. Seems I have to include >that commented out line again as this copies the content of closure-lib >into the debug-js directory. This should only be executed in Ant builds. I would think the

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-31 Thread Christofer Dutz
Hi Alex, Well I had another look at the original code. Seems I have to include that commented out line again as this copies the content of closure-lib into the debug-js directory. This should only be executed in Ant builds. I’ll look into this ... currently I’m finishing up the distribution (gen

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-31 Thread Alex Harui
On 10/31/16, 8:01 AM, "Christofer Dutz" wrote: >Hi Alex, > >thanks for your responses. Well I made it check the closureLib as I >wanted to allow users to specify that if they wanted to monkey-patch >stuff. In looking into the Ant scripts, closure-lib is being set. Did setting closureLib resul

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-31 Thread Christofer Dutz
Hi Alex, thanks for your responses. Well I made it check the closureLib as I wanted to allow users to specify that if they wanted to monkey-patch stuff. Well for now I removed the VF2JS stuff in my branch. I think I remember us discussing that and that consensus was to remove the code. At leas

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-31 Thread Alex Harui
On 10/31/16, 1:14 AM, "Christofer Dutz" wrote: >My optimization should have an effect if the closureLib is NOT explicitly >set and the file „goog/deps.js“ is found on the compilers classpath. This >is probably only the case for Maven builds. I think closureLib is sometimes set for me. Any rea

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-31 Thread Christofer Dutz
wondering if my current workflow would somehow be enhanced if I make the switch. -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Optimizing-the-maven-build-success-tp56102p56118.html Sent from the Apache Flex Development maili

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-31 Thread Christofer Dutz
My optimization should have an effect if the closureLib is NOT explicitly set and the file „goog/deps.js“ is found on the compilers classpath. This is probably only the case for Maven builds. I am currently working on cleaning up the MXMLFlexJSPublisher as I noticed a lot of things were done qui

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-30 Thread Alex Harui
On 10/30/16, 9:12 AM, "Christofer Dutz" wrote: >Hi Carlos, > >right now you can try it by switching the branch. I didn’t want to merge >it back to develop untill I get some confirmation from the Ant fraction >that it doesn’t break anything on their side. I built the branch. The build passed.

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-30 Thread yishayw
witch. -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Optimizing-the-maven-build-success-tp56102p56118.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-30 Thread Carlos Rovira
improve on these significantly? Thanks. > > > > *From: *Carlos Rovira > *Sent: *Sunday, October 30, 2016 5:58 PM > *To: *dev@flex.apache.org > *Subject: *Re: [FlexJS] Optimizing the maven build ... success ... > > O_o > > Awesome Chris! > > Can't wait to t

RE: [FlexJS] Optimizing the maven build ... success ...

2016-10-30 Thread Yishay Weiss
improve on these significantly? Thanks. From: Carlos Rovira<mailto:carlos.rov...@codeoscopic.com> Sent: Sunday, October 30, 2016 5:58 PM To: dev@flex.apache.org<mailto:dev@flex.apache.org> Subject: Re: [FlexJS] Optimizing the maven build ... success ... O_o Awesome Chris! Can'

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-30 Thread Carlos Rovira
Just confirm that MDLExample now builds in 8 secs first time and 3'6 second. Awesome! :) 2016-10-30 17:16 GMT+01:00 Carlos Rovira : > Ok Chris, I was just figuring it, thanks to confirm. > Just notice that maybe It would be ok to rebase it on top of develop to > get latest changes? (just figurin

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-30 Thread Carlos Rovira
Ok Chris, I was just figuring it, thanks to confirm. Just notice that maybe It would be ok to rebase it on top of develop to get latest changes? (just figuring) thanks! 2016-10-30 17:12 GMT+01:00 Christofer Dutz : > Hi Carlos, > > right now you can try it by switching the branch. I didn’t want to

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-30 Thread Christofer Dutz
Hi Carlos, right now you can try it by switching the branch. I didn’t want to merge it back to develop untill I get some confirmation from the Ant fraction that it doesn’t break anything on their side. One thing I noticed at the moment is that I can’t seem to be able to run the release compilat

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-30 Thread Carlos Rovira
O_o Awesome Chris! Can't wait to try it! :) 2016-10-29 22:11 GMT+02:00 Josh Tynjala : > Nice. Good work, Chris! > > - Josh > > On Oct 29, 2016 12:37 PM, "Christofer Dutz" > wrote: > > > Hi, > > > > the last few days I invested quite some time in optimizing the > compilation > > for Maven. > > >

Re: [FlexJS] Optimizing the maven build ... success ...

2016-10-29 Thread Josh Tynjala
Nice. Good work, Chris! - Josh On Oct 29, 2016 12:37 PM, "Christofer Dutz" wrote: > Hi, > > the last few days I invested quite some time in optimizing the compilation > for Maven. > > So far the compile-times for the entire framework part including all > examples has dropped from 17:38 to 3:10

[FlexJS] Optimizing the maven build ... success ...

2016-10-29 Thread Christofer Dutz
Hi, the last few days I invested quite some time in optimizing the compilation for Maven. So far the compile-times for the entire framework part including all examples has dropped from 17:38 to 3:10 minutes. And the build time of the Charts examle has dropped from 46,7 to 6,5 seconds. As the c