Re: [FlexJS] FLEX-34544 Preserve ASDoc style comments

2015-05-26 Thread Michael Schmalle
OK my bad! In the EnvProperties you are looking for ASJS_HOME and mine was set to asjs not flex-asjs. Two of the same problems in one day! That is the last time I follow checkout instructions, haha. I originally was going to name the just as the repo names were. Is there any reason they are shor

Re: [FlexJS] FLEX-34544 Preserve ASDoc style comments

2015-05-26 Thread Alex Harui
For compiler.tests get 4 failures relating to Strings that the CI server does not get. I’ve never figured out why. For compiler.jx.tests, they all pass. Which ones are failing for you? -Alex On 5/26/15, 2:45 PM, "Michael Schmalle" wrote: >Yeah, I was about to answer my own question here, I h

Re: [FlexJS] FLEX-34544 Preserve ASDoc style comments

2015-05-26 Thread Michael Schmalle
Yeah, I was about to answer my own question here, I have been testing the code and noticed you have the ASDocComment class that just gets the raw comment. BTW, I have like 6 failing tests, do all the tests pass for you out of the 1100 or so? Mike On Tue, May 26, 2015 at 5:42 PM, Alex Harui wrot

Re: [FlexJS] FLEX-34544 Preserve ASDoc style comments

2015-05-26 Thread Alex Harui
This is working for the purposes we use it for which is to copy the contents from AS to JS, not to create any doc output. I am just grabbing the content in between the comment open and close, I am not tokenizing the contents in any way. On 5/26/15, 2:24 PM, "Michael Schmalle" wrote: >Alex, > >h

[FlexJS] FLEX-34544 Preserve ASDoc style comments

2015-05-26 Thread Michael Schmalle
Alex, https://issues.apache.org/jira/browse/FLEX-34544 Did you ever get this working? I see you have committed some ASDocDelegate stuff which means you "might" be saving the docs, does this work with that commit you implemented? I am guessing you didn't finish it since I ran into that scanner bu