Re: [FlexJS][XML]appending XMLLists

2016-05-15 Thread Alex Harui
I thought I fixed this. Is it not working? Sent from my LG G3, an AT&T 4G LTE smartphone -- Original message-- From: Harbs Date: Sat, May 14, 2016 11:53 PM To: dev@flex.apache.org; Subject:Re: [FlexJS][XML]appending XMLLists Alex, Can you look at this? On May 12, 2016, at 2:5

Re: [FlexJS][XML]appending XMLLists

2016-05-14 Thread Harbs
Alex, Can you look at this? On May 12, 2016, at 2:56 PM, Harbs wrote: > I committed my changes, but I need you to look at it. > > I commented out the test to get it to compile, but besides that, there’s > definitely a problem: > > 198: ERROR - Parse error. invalid assignment target > [j

Re: [FlexJS][XML]appending XMLLists

2016-05-12 Thread Alex Harui
Results should be in compiler-jx/target/junit-results/TEST-org.apache.flex.compiler.internal.cod egen.js.flexjs.TestFlexJSGlobalClasses.xml -Alex On 5/12/16, 3:40 AM, "Harbs" wrote: >Well I tried this, but something is wrong. > >I changed the tests to reflect my changes and I’m getting an error

Re: [FlexJS][XML]appending XMLLists

2016-05-12 Thread Harbs
I committed my changes, but I need you to look at it. I commented out the test to get it to compile, but besides that, there’s definitely a problem: 198: ERROR - Parse error. invalid assignment target [java] this.xml2.child('a') = this.xml2.child('a').plus(new XML( '')); The original co

Re: [FlexJS][XML]appending XMLLists

2016-05-12 Thread Harbs
Well I tried this, but something is wrong. I changed the tests to reflect my changes and I’m getting an error in the tests (in TestFlexJSGlobalClasses). How can I see the results of the test to see what’s wrong? On May 10, 2016, at 6:09 PM, Alex Harui wrote: > > > On 5/10/16, 8:03 AM, "Harb

Re: [FlexJS][XML]appending XMLLists

2016-05-10 Thread Alex Harui
On 5/10/16, 8:03 AM, "Harbs" wrote: >foo = foo.plus(bar); OK, well in theory the compiler generated "foo" and is about to add ".concat(" so you would get "foo.concat(" then "bar" would get emitted. Try replacing ".concat" with: " = " getWalker().walk(node.getLeftOperandNode()); // should re

Re: [FlexJS][XML]appending XMLLists

2016-05-10 Thread Harbs
foo = foo.plus(bar); On May 10, 2016, at 5:58 PM, Alex Harui wrote: > IOW, what is the full JS you want generated for foo += bar?

Re: [FlexJS][XML]appending XMLLists

2016-05-10 Thread Alex Harui
On 5/10/16, 2:40 AM, "Harbs" wrote: >I’m not sure I totally understand the pattern: > > else if (node.getNodeID() == ASTNodeID.Op_AddAssignID) > { > getWalker().walk(xmlNode); > write(".concat("); >

Re: [FlexJS][XML]appending XMLLists

2016-05-10 Thread Harbs
I’m not sure I totally understand the pattern: else if (node.getNodeID() == ASTNodeID.Op_AddAssignID) { getWalker().walk(xmlNode); write(".concat("); getWalker().walk

Re: [FlexJS][XML]appending XMLLists

2016-05-09 Thread Harbs
On May 9, 2016, at 8:21 PM, Alex Harui wrote: > > > On 5/9/16, 9:44 AM, "Harbs" wrote: >>> OK, after more reading, I think section 7.1.2 confirms your assumption. >>> But based on the algorithm and that knowledge, do you see any issues >>> with >>> the Flash implementation? Yes, it is puzzli

Re: [FlexJS][XML]appending XMLLists

2016-05-09 Thread Alex Harui
On 5/9/16, 9:44 AM, "Harbs" wrote: >>OK, after more reading, I think section 7.1.2 confirms your assumption. >> But based on the algorithm and that knowledge, do you see any issues >>with >> the Flash implementation? Yes, it is puzzling that targetObject gets >> assigned before the elements are

Re: [FlexJS][XML]appending XMLLists

2016-05-09 Thread Harbs
On May 9, 2016, at 6:14 PM, Alex Harui wrote: > > > On 5/9/16, 12:00 AM, "Harbs" wrote: > >> >> On May 9, 2016, at 8:10 AM, Alex Harui wrote: >> >>> >>> >>> On 5/8/16, 1:18 AM, "Harbs" wrote: >>> I’m still having trouble with the spec, though. The spec has the following in [

Re: [FlexJS][XML]appending XMLLists

2016-05-09 Thread Alex Harui
On 5/9/16, 12:00 AM, "Harbs" wrote: > >On May 9, 2016, at 8:10 AM, Alex Harui wrote: > >> >> >> On 5/8/16, 1:18 AM, "Harbs" wrote: >> >>> I’m still having trouble with the spec, though. The spec has the >>> following in [[Append]]: >>> >>> 3. If Type(V) is XMLList, >>> a. Let x.[[TargetOb

Re: [FlexJS][XML]appending XMLLists

2016-05-09 Thread Harbs
On May 9, 2016, at 8:10 AM, Alex Harui wrote: > > > On 5/8/16, 1:18 AM, "Harbs" wrote: > >> I’m still having trouble with the spec, though. The spec has the >> following in [[Append]]: >> >> 3. If Type(V) is XMLList, >> a. Let x.[[TargetObject]] = V.[[TargetObject]] >> b. Let x.[[TargetProp

Re: [FlexJS][XML]appending XMLLists

2016-05-08 Thread Alex Harui
On 5/8/16, 1:18 AM, "Harbs" wrote: >I’m still having trouble with the spec, though. The spec has the >following in [[Append]]: > >3. If Type(V) is XMLList, > a. Let x.[[TargetObject]] = V.[[TargetObject]] > b. Let x.[[TargetProperty]] = V.[[TargetProperty]] > c. Let n = V.[[Length]] > d. If

Re: [FlexJS][XML]appending XMLLists

2016-05-08 Thread Harbs
OK. You are right about this. When I do this: list1 += list4 + xml2.z;// leaving out xml2.z prevents the next line from adding to the original xml list1[list1.length()] = ; I get: http://ns.adobe.com/mxml/2009";> hi yeah! So, anything added to the XMLList after

Re: [FlexJS][XML]appending XMLLists

2016-05-07 Thread Alex Harui
On 5/7/16, 11:36 AM, "Harbs" wrote: >Right. I read that. This was what I was referring to in my last email. > >However, the Addition Operator is supposed to call [[Append]] and >[[Append]] is supposed to assign the right side target object and target >property to the left side object. So why do

Re: [FlexJS][XML]appending XMLLists

2016-05-07 Thread Harbs
Right. I read that. This was what I was referring to in my last email. However, the Addition Operator is supposed to call [[Append]] and [[Append]] is supposed to assign the right side target object and target property to the left side object. So why doesn’t the original XML get effected? On Ma

Re: [FlexJS][XML]appending XMLLists

2016-05-06 Thread Alex Harui
I think I found the answer. I was thinking that list1 += list4, which is equivalent to list1 = list1 + list4 would just use the [[Append]] operation. But that isn't true. Further down in the spec (in 11.4) it actually addresses Addition operator. And in there it says:

Re: [FlexJS][XML]appending XMLLists

2016-05-06 Thread Harbs
But, according to how I’m reading the spec, the following should work, but it doesn’t: list4 = new XMLList(); list4[0] = ; list4[1] = ; list4[2] = ; list1 += list4 + xml2.z; On May 6, 2016, at 11:29 AM, Harbs wrote: > I got rid of just about everything and it still was not working. > > I fin

Re: [FlexJS][XML]appending XMLLists

2016-05-06 Thread Harbs
I got rid of just about everything and it still was not working. I finally replaced list1 += list4 with xml2.a += list4 and that works. So the following does not work: list1 = xml2.a; list1 += list4; But the following does: xml2.a += list4 I’m guessing that the reason the second case works is

Re: [FlexJS][XML]appending XMLLists

2016-05-06 Thread Alex Harui
Hmm. Did you try commenting out lines of code in your first example until it looks like this employees example? Maybe one of the lines cause a bug. I wasn't sure what list1[0][0][0] would be, for example. Or comment out the node. I just noticed that the append may have picked up the name() fr

Re: [FlexJS][XML]appending XMLLists

2016-05-06 Thread Harbs
No. That’s not it. For example, this: var e = Joe20 Sue30 ; // append employees 3 and 4 to the end of the employee list var newE:XMLList = new XMLList(); newE[0] = Fred; newE[1] = Carol; e.employee += newE; trace(e); outputs: Joe 20 Sue 30 Fred

Re: [FlexJS][XML]appending XMLLists

2016-05-06 Thread Alex Harui
On 5/5/16, 11:38 PM, "Harbs" wrote: >FWIW, I also tried >list1 += < id=“1”/>; >instead of >list1 += list4 >but that did not work either. > >I re-read the spec and it does look like you are reading it right, but it >does not make sense to me and I don’t know how that jives with the >behavior in

Re: [FlexJS][XML]appending XMLLists

2016-05-05 Thread Harbs
FWIW, I also tried list1 += < id=“1”/>; instead of list1 += list4 but that did not work either. I re-read the spec and it does look like you are reading it right, but it does not make sense to me and I don’t know how that jives with the behavior in other cases. For example (from the spec): > Si

Re: [FlexJS][XML]appending XMLLists

2016-05-05 Thread Alex Harui
Baffling, isn't it? Reading the spec is equally baffling, but I think I see for XMLList Append, that the targetObject of the appended XMLList becomes the targetObject of the destination XMLList! That seems really surprising to me and why they would do that doesn't jump to mind, but I think that's

Re: [FlexJS][XML]appending XMLLists

2016-05-05 Thread Harbs
I’ve tried quite a number of angles on this, and I am just as clueless as when I started. Nothing I do seems to get the a elements added in Flash. I’m really stumped on this. I’m going to leave the JS output as it is until someone can explain to me why it’s wrong… On May 5, 2016, at 10:49 AM,

[FlexJS][XML]appending XMLLists

2016-05-05 Thread Harbs
I have a situation where the FlexJS output is different than the Flash output of XML, but it seems to me like the Flash output is wrong. I’m not sure what I’m missing: Here’s the (stripped down) code: var xml2:XML = new XML('http://ns.adobe.com/mxml/2009";>hiyeah!'); var list1:XMLList = xml2.a;