Now we're on the same page :-)
Happy coding!
EdB
On Tue, Mar 5, 2013 at 12:07 PM, Michael Schmalle
wrote:
> Ha,
>
> Ok another language thing, I did not mean child in respect to inheritance, I
> meant child in respect to who knows about who, which sibling "might" work
> but its not exact sinc
Ha,
Ok another language thing, I did not mean child in respect to
inheritance, I meant child in respect to who knows about who, which
sibling "might" work but its not exact since MXML can 'have' AS
composed in it BUT AS cannot have MXML composed in it. This is where
the parent child thing
I will do it in a moment, but first I must ask: why do you say that
MXML is the 'child' of AS? It is no such thing, it exists (mostly)
separate from AS, all they share are some common ancestors (my now
infamous 'common' stuff). Let's call them brothers ;-)
This latest commit I have lined up allows
DO IT! :)
We will discuss architecture down the road when the dust settles, I
just wanted to make sure the child(MXML) is not telling the parent(AS)
what to do. :)
Mike
Quoting Erik de Bruin :
Also, did you, or did you not want me to commit my latest
contribution, based on the descriptio
Erik,
Here is the misunderstanding in a nut shell.
The commit I got so upset about was mainly knee jerk but is served as
a warning to me. The ONLY time I have a problem with any type of
"commit then review" process is when the changes or refactoring have
to do with the frameworks (existing
Also, did you, or did you not want me to commit my latest
contribution, based on the description I gave?
EdB
On Tue, Mar 5, 2013 at 11:37 AM, Erik de Bruin wrote:
> Mike, I'm confused. I'm sure it's me (being a foreigner and all), but
> I don't understand what you're asking of me...
>
> I did a
Mike, I'm confused. I'm sure it's me (being a foreigner and all), but
I don't understand what you're asking of me...
I did a big commit 'solo', it nearly was vetoed. The suggestion was I
talk about what I plan to change before actually committing next time
I needed to make changes that might influ
We did. :)
I just wanted to see if you were reading every word I write. :)
Mike
Quoting Erik de Bruin :
It's re-renamed (de-named?).
About 'common', I tried to explain that might be a misnomer due to me
not being a native English speaker.
As stated before, I complete stand behind what you
I didn't tell you anything.
I asked if we could discuss changes BEFORE your even wrote anything to commit.
Mike
Quoting Erik de Bruin :
LOL, you told me to discuss first, commit later... which is what I'm doing.
I'm writing a big reply to your comments, just had to get this out of
the way ;
It's re-renamed (de-named?).
About 'common', I tried to explain that might be a misnomer due to me
not being a native English speaker.
As stated before, I complete stand behind what you say about moving
everything (as, js and mxml) into one 'codegen', 'driver' and
'visitor' package. I just though
We're all good. MXML only uses AS, no changes were made - nor am I
planning to make any - to the AS implementation, apart from a minor
refactoring of BlockWalker and BlockVisitor to allow for a shared
ancestor.
EdB
On Mon, Mar 4, 2013 at 10:26 PM, Michael Schmalle
wrote:
> Well,
>
> I purposel
LOL, you told me to discuss first, commit later... which is what I'm doing.
I'm writing a big reply to your comments, just had to get this out of
the way ;-)
EdB
On Mon, Mar 4, 2013 at 10:42 PM, Michael Schmalle
wrote:
> I see your commit with MXML, where is this other changes?
>
>
> Mike
>
>
Just to back up what I am saying about codegen refactor;
Look at 'org.apache.flex.compiler.tree'
and
'org.apache.flex.compiler.internal.tree'
Basically, the are saying we have a bunch of different types of
'trees' but they are all trees so each 'type' of tree gets it's own
sub package in t
Erik;
renamed IASNodeStrategy to INodeStrategy
I disagree, please rename that interface back to IASNodeStrategy.
The only method it has is handle(IASNode node), notice the IASNode. It
is a IASNode handler strategy.
Can we please be a little more pragmatic at this refactoring and
renamin
I see your commit with MXML, where is this other changes?
Mike
Quoting Erik de Bruin :
Mike et al.,
I have a reasonably big commit lined up. To make AS embedded in MXML
work without doing duplicate work, I figured I could best use the
existing ASEmitter and subclases. To make this work, I ne
Well,
I purposely did not want anything ActionScript tied to MXML. There was
a way to invoke the walker within the MXML visitor(... sounds like you
might have done this).
I guess this is what I get for not finishing it to a point of working.
Email is to hard to discuss something like this
Mike et al.,
I have a reasonably big commit lined up. To make AS embedded in MXML
work without doing duplicate work, I figured I could best use the
existing ASEmitter and subclases. To make this work, I needed to add
an ASBlockWalker to the MXMLBlockWalker and make adjustments to some
existing cod
17 matches
Mail list logo
