Re: [FalconJX][FlexJS] Dependency calculations

2013-04-09 Thread Erik de Bruin
I'll try to write some tests that reproduce this. Let's not change any code until we have a way to pinpoint the issue? EdB On Tue, Apr 9, 2013 at 11:24 AM, Alex Harui wrote: > I don't have a test case I can make public. It appears to be ClassA > requires ClassB requires ClassC requires ClassA

Re: [FalconJX][FlexJS] Dependency calculations

2013-04-09 Thread Alex Harui
I don't have a test case I can make public. It appears to be ClassA requires ClassB requires ClassC requires ClassA. Which is all valid because the circularity doesn't involve prototype definitions. When I was working with FalconJS, I tried the calcdeps.py and it kept complaining about circular

Re: [FalconJX][FlexJS] Dependency calculations

2013-04-09 Thread Erik de Bruin
Alex, The current 'publisher' part of FalconJx uses the vanilla 'DepsGenerator' functionality of the Closure Compiler. Do you have a minimal test case of the kind of circular dependency you are talking about? It seems like that should be something that Google should have encountered and be able to

[FalconJX][FlexJS] Dependency calculations

2013-04-08 Thread Alex Harui
Erik, Have you noticed that the google tools seem to be too sensitive to circular dependencies in the goog.requires? Back when I was using FalconJS, I was trying to use the google tools to compute the deps.js files and it kept failing with circular dependencies. I ended up writing my own dep