Re: [FLEXJS-JS] commit or hold, please

2013-05-03 Thread Erik de Bruin
> stuff onto multiple lines just because it came out to 82 chars. BTW, have > you considered trying to hack the python files in the closure linter? Nope, but interesting suggestion... EdB -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl

Re: [FLEXJS-JS] commit or hold, please

2013-05-03 Thread Alex Harui
OK. 4 is fine. I'm ok with a line-length goal, but IMO, sometimes it isn't worth breaking stuff onto multiple lines just because it came out to 82 chars. BTW, have you considered trying to hack the python files in the closure linter? On 5/3/13 9:38 AM, "Erik de Bruin" wrote: > It's the inter

Re: [FLEXJS-JS] commit or hold, please

2013-05-03 Thread Erik de Bruin
It's the internal standard at Google, but almost everywhere else (I know of) uses 4 spaces. JSLint doesn't care. I "grew up" on the Adobe Flex coding conventions and I like 4 spaces from a readability point of view. I also like an 80-ish character line length, for the same reason. I like JSLint as

Re: [FLEXJS-JS] commit or hold, please

2013-05-03 Thread Alex Harui
Is it a "standard" to use 2? If you want to use 2 I'll learn to live with it. I can probably set up one editor for js editing. On 5/3/13 8:37 AM, "Erik de Bruin" wrote: > Ok, how about this: I'll replace all tabs and '4 spaces' with 2 spaces > to satisfy the Closure Linter, run JSLint and jus

Re: [FLEXJS-JS] commit or hold, please

2013-05-03 Thread Erik de Bruin
Ok, how about this: I'll replace all tabs and '4 spaces' with 2 spaces to satisfy the Closure Linter, run JSLint and just before comitting, I'll replace all '2 spaces' with 4 spaces (my favourite also) and not fix the 80 char limit after that change. That way we have a consistent base we all can wo

Re: [FLEXJS-JS] commit or hold, please

2013-05-03 Thread Alex Harui
Ok, I'm all checked in. On 5/3/13 7:50 AM, "Erik de Bruin" wrote: > Hi, > > I will merge the 'goog.events' branch with 'develop' my tonight, so if > everyone can check in their last minute commits to the JS part of > FlexJS before 7 PM CEST (GMT +1; that's 10 AM for the lucky "few" who > live

[FLEXJS-JS] commit or hold, please

2013-05-03 Thread Erik de Bruin
Hi, I will merge the 'goog.events' branch with 'develop' my tonight, so if everyone can check in their last minute commits to the JS part of FlexJS before 7 PM CEST (GMT +1; that's 10 AM for the lucky "few" who live on the US east coast) that would make your lives much easier. Any changes not che