Hi,
Just doing this.
Thanks,
Justin
Great!
Justin, were you planning to merge this PR? Or I can do it within a day or
so.
Thanks,
Om
On Dec 22, 2015 10:22 PM, "OK" wrote:
> OmPrakash Muppirala wrote
> > If you want to be thorough, you can open a JIRA ticket with the details
> > of
> > this enhancement. That will help when we w
OmPrakash Muppirala wrote
> If you want to be thorough, you can open a JIRA ticket with the details
> of
> this enhancement. That will help when we write the Release Notes for
> 4.15.0
> Thanks again for the contribution!
Done, it's a pleasure to help :-)
Olaf
--
View this message in contex
The PR looks good to me. Thanks!
If you want to be thorough, you can open a JIRA ticket with the details of
this enhancement. That will help when we write the Release Notes for 4.15.0
Thanks again for the contribution!
Regards,
Om
On Dec 22, 2015 12:21 PM, "OK" wrote:
> It's done, hope it'
It's done, hope it's ok now ;-)
Olaf
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/4-15-0-Update-FontAwesome-icon-lib-to-4-5-tp50737p50776.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
>The release manager would take care of it.
Makes sense ;-)
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/4-15-0-Update-FontAwesome-icon-lib-to-4-5-tp50737p50761.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
On Mon, Dec 21, 2015 at 10:41 PM, OK wrote:
> >-Fork off of the 4.15.0 branch on github
> >...
> Thanks for help!
> I'll do this in the evening.
>
> >However the release branch can be merged back into develop or vice versa
> if
> needed.
> Who takes care of it?
>
The release manager would take c
>-Fork off of the 4.15.0 branch on github
>...
Thanks for help!
I'll do this in the evening.
>However the release branch can be merged back into develop or vice versa if
needed.
Who takes care of it?
Olaf
--
View this message in context:
http://apache-flex-development.247.n4.nabble.co
Okay, Justin responded at the same time as I sent mine.
Here are the correct instructions:
- Fork off of the 4.15.0 branch on github
- Clone the fork onto your local computer
- Apply the fixes in your local computer (no need to create a new branch)
- Commit and push your changes to your fork on g
I am guessing that the new branch + merging caused this issue
Here is the most straightforward way I would recommend:
- Fork off of the dev branch on github
- Clone the fork onto your local computer
- Apply the fixes in your local computer (no need to create a new branch)
- Commit and push your c
Hi,
If you want it in the release i'd make the pull request on the 4.15 branch.
However the release branch can be merged back into develop or vice versa if
needed.
Thanks,
Justin
I've just seen that my pull request contains 12 commits instead of 2.
Seems that other commits from other users are included in my pull request
cause I target the 4.15.0 branch for merging.
Should I target the develop branch instead of the 4.15.0 branch?
Olaf
--
View this message in context:
I've just created a pull request that contains the update to FontAwesome 4.5.
I'm not sure if I've done it all right. If somebody could merge it I'll test
it by using te latest dev build.
Thanks,
Olaf
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/4-15-0-
That's what I would do, though I hate git with a fair level of passion :-)
Tom
On 21/12/15 13:40, OK wrote:
Is it the right way to fork the github develop branch, create a new brunch,
make the changes and create a pull request for the 4.15.0 branch?
Hi,
it would be nice if we could update the great FontAwesome icon lib to the
recent version 4.5.
To do this it seems that the .otf file itself has to be replaced and the
AwesomeUtils.as has to be modified:
flex-sdk/frameworks/projects/flatspark/src/flatspark/assets/fonts/awesome/FontAwesome.otf
f
15 matches
Mail list logo
