[GitHub] flex-asjs issue #10: Binary data improvement

2016-07-22 Thread aharui
Github user aharui commented on the issue: https://github.com/apache/flex-asjs/pull/10 Someday, we can have a BinaryDataForGPU class with native defaults. Or make more classes like BinaryDataLittleEndian and BinaryDataBigEndian. No need to figure it out all in a single class

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

2016-01-06 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169362450 @Harbs: Yes, that has been working for me, but for some reason, when I pulled the last set of changes there was a merge conflict and after resolving them, the system

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

2016-01-05 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169259473 I think the github integration scripts didn't quite work. Can you manually close the pull request? --- If your project is set up for it, you can reply to this

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

2016-01-05 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169258856 Yes, there some subtle things to the extern compiler. Thanks for sticking with it. Everything passes for me and I pushed it to the repo. --- If your project is set

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

2016-01-05 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169200272 Still not working. Maybe the patches didn't applied correctly, but createjs.Text.toString() is still being generated even though there

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

2016-01-05 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169180297 No, we just want to make sure we have the same behavior that AS coders expect. I'll try to apply the correct set of your patches and see what happens. --- If

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

2016-01-05 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169167331 What happens for some non-dynamic class that extends Object? Does it get a toString() even if it doesn't define a custom toString() function? Does the compile

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

2016-01-05 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169131291 I think where we want to end up is that Number, int and uint have toString(radix) in the AS3 namespace, and Date, Array, etc have toString(). The code may have to

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

2016-01-05 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169119427 I'm pretty sure it is that way so your subclasses of Object can override toString() although they can't add parameters to toString(). --- If your project

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

2016-01-05 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169114711 Also, with the getStaticField/getInstanceField changes, 5 files of unit tests have compile errors. They are: TestAnnotationEnum, TestConstructor, TestExternChrome

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

2016-01-05 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169106519 Wasn't toString() on Object? Then it doesn't need to exist on most other objects. But we do need to allow Number, int and uint to have their own toStr

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

2016-01-05 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169096483 Where was the toString() missing? That change seems to be breaking the CreateJS externs build. The classes generated from the externs generally don't in

[GitHub] flex-asjs pull request: Language.js bug fixes and improvements

2015-12-02 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-asjs/pull/3#issuecomment-161399542 Hi, Thanks for these improvements. It turns out we are refactoring Language.js in the core_js_to_as branch right now. I will fold your changes in after

[GitHub] flex-sdk pull request: Replace string concatenation as argument St...

2015-10-30 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-sdk/pull/24#issuecomment-152585318 Hi SlavaRa, (Apologies if this gets posted twice. I think email replies as comments isn't working) Do you have a link that supports your claim

[GitHub] flex-sdk pull request: Manual array copy replace with System.array...

2015-10-21 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-sdk/pull/33#issuecomment-149923072 Hi, are you subscribed to our developer mailing list (dev@flex.apache.org). If not, please subscribe by sending an email to dev-subscr...@flex.apache.org so we can