[GitHub] flex-utilities issue #8: Correctly locate SCRIPT_HOME even when scripts are ...

Github user adufilie commented on the issue: https://github.com/apache/flex-utilities/pull/8 The updated script has not been published to NPM yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flex-asjs issue #10: Binary data improvement

Github user adufilie commented on the issue: https://github.com/apache/flex-asjs/pull/10 Thanks for the link, Harbs. I mistakenly thought this code was only related to ByteArray. Now I see that it's actually writing to an ArrayBuffer in JavaScript. --- If your project is s

[GitHub] flex-utilities issue #8: Correctly locate SCRIPT_HOME even when scripts are ...

Github user adufilie commented on the issue: https://github.com/apache/flex-utilities/pull/8 We've verified that the changes to work on OS10, Linux, and Windows. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flex-asjs issue #10: Binary data improvement

Github user adufilie commented on the issue: https://github.com/apache/flex-asjs/pull/10 The default should be big endian ("network byte order") used by java and flash. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] flex-asjs pull request: sortOn

Github user adufilie commented on a diff in the pull request: https://github.com/apache/flex-asjs/pull/5#discussion_r62781222 --- Diff: frameworks/projects/Core/src/main/flex/org/apache/flex/utils/Language.as --- @@ -361,5 +370,56 @@ package org.apache.flex.utils

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169368242 Sorry, I meant "git reset", not revert. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169367688 I noticed that there was no merge commit after applying the patch. On the "Git for Apache Flex Guide" (https://cwiki.apache.org/confluence/display/FL

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169336626 The patch didn't apply correctly. Commits were included that should have been replaced. I've created a new pull request to revert the bad commits and re-

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie closed the pull request at: https://github.com/apache/flex-falcon/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flex-falcon pull request: Revert and re-apply https://github.com/a...

GitHub user adufilie opened a pull request: https://github.com/apache/flex-falcon/pull/6 Revert and re-apply https://github.com/apache/flex-falcon/pull/5 The previous patch didn't apply correctly. This new pull request reverts the bad commits and re-applies the previous patch.

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169223531 The one piece I didn't realize before was that since these classes are serving the purpose of an external interface, subclasses need not include override me

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169221139 Ok, I've reworked and updated the patch. I managed to move all the toString-related special-case code into a single if statement. Please try again. --- If

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169212882 At one point I had it working, but you're right, it currently isn't. I must've been modifying the wrong set of files when I was testing overr

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169167951 ActionScript gives an error if you try to use toString() on a non-dynamic class that does not define it explicitly. Is there a reason we should make it behave

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169160089 Flash Builder does not show toString() in its content assist for Object, and there is no error in the editor. =) --- If your project is set up for it, you can

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169140272 I believe the patched code does the right thing. From the AS3 language reference: >Note: Methods of the Object class are dynamically created on Objec

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169134018 This is outputting ActionScript code to correspond to the JavaScript APIs, so I don't think the requirement of an AS3 namespace on Number.prototype.toString(

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169126473 Before the changes related to toString(), new Date().toString() was giving an error because the toString() function was missing from the generated Date.as

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169110068 Object.prototype.toString() is included in the es3.js extern file, but it has a different signature than Number.prototype.toString(opt_radix), so you cannot have it

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169102408 toString() was missing in every class except Number, int, uint. I've found the problem and will add another commit here shortly. Sorry about that. --- If

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

GitHub user adufilie opened a pull request: https://github.com/apache/flex-falcon/pull/5 Compiler fixes related to js.swc You can merge this pull request into a Git repository by running: $ git pull https://github.com/adufilie/flex-falcon patch-4 Alternatively you can review

[GitHub] flex-falcon pull request: (relating to js.swc) Return type with te...

GitHub user adufilie opened a pull request: https://github.com/apache/flex-falcon/pull/4 (relating to js.swc) Return type with template should be treated as * The code "var x:int = [1,2].pop();" should not generate an error "Implicit coercion of a value with static t

[GitHub] flex-falcon pull request: updated test cases with labeled for-each...

GitHub user adufilie opened a pull request: https://github.com/apache/flex-falcon/pull/3 updated test cases with labeled for-each loops See https://issues.apache.org/jira/browse/FLEX-34984?focusedCommentId=15075728&page=com.atlassian.jira.plugin.system.issuetabpanels:com

[GitHub] flex-falcon pull request: Updating assertion to preserve code beha...

GitHub user adufilie opened a pull request: https://github.com/apache/flex-falcon/pull/2 Updating assertion to preserve code behavior See https://github.com/apache/flex-falcon/commit/3971196a4478853e1fd443e21e011ee1b8ea14c8#commitcomment-15157562 You can merge this pull request

[GitHub] flex-falcon pull request: Changed `dirname $0` to `dirname "$0"` t...

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/1#issuecomment-168127810 See https://issues.apache.org/jira/browse/FLEX-34984?focusedCommentId=15075728&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-1507

Re: Closure compiler CompilationLevel

The forum formatting in my previous message caused part of the text to be omitted on the mailing list. The full message is below. If the forum interface happens to omit the quoted text then I apologize in advance. adufilie wrote > Is there a way to do this yet? I'm having the same pro

Re: Closure compiler CompilationLevel

Is there a way to do this yet? I'm having the same problem - I want to be able to specify the compilation level as WHITESPACE_ONLY. I saw reference to "js-closure-compilation-level" in the code , so I t

[GitHub] flex-sdk pull request: Changed `dirname $0` to `dirname "$0"` to s...

GitHub user adufilie opened a pull request: https://github.com/apache/flex-sdk/pull/40 Changed `dirname $0` to `dirname "$0"` to support paths with spaces See https://issues.apache.org/jira/browse/FLEX-35006 You can merge this pull request into a Git repository

[GitHub] flex-falcon pull request: Changed `dirname $0` to `dirname "$0"` t...

GitHub user adufilie opened a pull request: https://github.com/apache/flex-falcon/pull/1 Changed `dirname $0` to `dirname "$0"` to support paths with spaces See https://issues.apache.org/jira/browse/FLEX-35006 You can merge this pull request into a Git repository

[GitHub] flex-asjs pull request: Language.js bug fixes and improvements

GitHub user adufilie opened a pull request: https://github.com/apache/flex-asjs/pull/3 Language.js bug fixes and improvements Individual improvements are separated into different commits. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flex-sdk pull request: Fix MenuBar.styleChanged() crash bug

Github user adufilie commented on the pull request: https://github.com/apache/flex-sdk/pull/12#issuecomment-54565010 Also I think this patch resolves the following issue: https://issues.apache.org/jira/browse/FLEX-14064 --- If your project is set up for it, you can reply to this