Hi Justin,
Could you put this code on paste.apache.org or somewhere else? It's
unreadable on nabble.
Thanks,
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/Re-git-commit-flex-asjs-refs-heads-develop-a
Unless we are absolutely sure that everybody will need the code generated
by the compiler, having the compiler call a framework function makes it
easier for an app developer to make any adjustments to that code. It is
easier to monkey-patch a utility function than find-and-replace some
sequence of
Hi,
> Harbs:
Feel free to do what you want to SonarQube now, but don’t make any changes
based on the reports.
I think you would agree that it doesn’t matter what tool you use to find issues
and a blanket statement like that is like saying you must use a particular IDE
to edit your co
Hi,
Here you go:
diff --git
a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as
b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as
index 3ccf708..89e89c4 100644
---
a/frameworks/projects/Basic/src/main/flex/org/apach
I'm working on adding support for the debugger statement to the compiler
(FLEX-35343). I can successfully emit the debugger statement in the
generated JS so far.
I'm not yet sure if I can make it work on the SWF side. I figured out where
I can generate bytecode instructions in ABCGeneratingReducer
Justin -
You seem to pick the part of the conversation that you are interested in and
edit out the rest of the context. It makes it difficult to have a conversation
about the best way to move forward in this project.
Harbs:
>>> Feel free to do what you want to SonarQube now, but don’t make any
Hi,
> I assume you tested this with regular Flex and not the Falcon compiler? I
> just want to verify a couple of your findings.
Be aware there are existing unresolved bugs in the Flex SDK in this area i.e.
[1]
Thanks,
Justin
1. https://issues.apache.org/jira/browse/FLEX-33644
Hi,
> The exercise with the Wiki was essentially for you to present a proposed set
> of Sonar rules. You did this, thank you.
>
> It was not intended by me as [LAZY CONSENSUS]. Clearly there is healthy
> disagreement and consensus is not yet achieved.
Nor is it intended to be. I created a new
Hi,
> Also, in FlexJS, we want very few if any custom events to bubble.
> Bubbling was overused in regular Flex and was, IMO, a bad practice because
> it breaks encapsulation.
Events provide encapsulation by allowing application to respond to changes
outside of the object. IMO it’s also a good p
Hi,
> Can we focus more on the priorities from the summit [1]?
Sonar Cube analysis was discussed at the summit i.e. items 5 and 6 which it can
help with.
> Or maybe a feature like AMF that some folks really need?
I’m not interested in AMF support so it’s unlikely I’ll work on it.
Thanks,
Ju
Here seems to be the explanation for that:
new RegExp("?”)
In Flash, this creates a RegExp object.
In JS, it throws an “Invalid regular expression” error.
> On Jul 18, 2017, at 9:38 PM, Harbs wrote:
>
> The “?” case seems to be an outlier.
Alex Harui-2 wrote
> By
> calling new utility functions, the developer has control over the
> conversion.
I don't understand that point. Do you mean an app developer?
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/FlexJS-String-match-tp63392p63405.html
Calling language functions at first seemed unnecessarily expensive to me.
I just did a bit of research, and it looks like I was wrong about replacing
search with indexOf. That will only work for simple string searches.
str.search(“.”) will always return 0 unless the string is empty, because the
> On Jul 18, 2017, at 6:13 PM, Alex Harui wrote:
>
> I assume you tested this with regular Flex and not the Falcon compiler?
Yes.
> I just want to verify a couple of your findings.
>
> 1) Does passing empty string really produce an XML object with no children
> or is there a child textNode wi
Hi Justin,
The exercise with the Wiki was essentially for you to present a proposed set of
Sonar rules. You did this, thank you.
It was not intended by me as [LAZY CONSENSUS]. Clearly there is healthy
disagreement and consensus is not yet achieved.
> On Jul 17, 2017, at 11:22 PM, Justin Mclean
Alex,
+1
Thanks for such reminder! Really wish someone could start look into that!
Piotr
-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context:
http://apache-flex-development.247.n4.nabble.com/Re-git-commit-flex-asjs-refs-heads-develop-Added-support-for-JS-upload
This feels like something that the compiler should just call
Language.stringMatch and Language.stringSearch (or standalone
equivalents). I'm not clear that we should always modify the string. By
calling new utility functions, the developer has control over the
conversion.
-Alex
On 7/18/17, 4:11
Additionally, the cloning results in extra objects that need to be garbage
collected, which can hurt performance and make effects/animations look bad.
Good call on avoiding it!
- Josh
On Tue, Jul 18, 2017 at 8:23 AM, Alex Harui
wrote:
> +1 to what Harbs said.
>
> Also, in FlexJS, we want very f
+1 to what Harbs said.
Also, in FlexJS, we want very few if any custom events to bubble.
Bubbling was overused in regular Flex and was, IMO, a bad practice because
it breaks encapsulation.
Bubbling was intended to allow an object in the DOM to monitor inputs to
its children without having to atta
Justin, this is not worth the time being spent on it.
Can we focus more on the priorities from the summit [1]? Or maybe a
feature like AMF that some folks really need?
[1]
https://lists.apache.org/thread.html/3ef2cc9fcd17bbf0c81b38c35586790255277f
bb4f727db8882920ec@%3Cdev.flex.apache.org%3E
-
I assume you tested this with regular Flex and not the Falcon compiler? I
just want to verify a couple of your findings.
1) Does passing empty string really produce an XML object with no children
or is there a child textNode with ""?
2) If you pass in an XMLList with one element, doesn't
var
I guess I should have been more clear. FlexJS supports multiple component
sets and runtimes. An Application class is probably always going to be
the entry point of an application, but there is no guarantee in any
application that the Application class will be a display object or even
the correct
Maybe you are taking the wrong approach. Feel free to share your proposed
changes in a branch or as a patch.
-Alex
On 7/17/17, 9:49 PM, "Justin Mclean" wrote:
>Hi,
>
>So I’ve looked into it and have rough version code up and so far:
>- Requires support of styleName in AS which AFAICS is missin
The same issue applies to String.search(), although it might make sense to
replace String.search() with String.indexOf() if the parameter is a string.
> On Jul 18, 2017, at 12:36 PM, yishayw wrote:
>
> In flash String.match() can take either a string or a regex. In JS it's
> always considered t
In flash String.match() can take either a string or a regex. In JS it's
always considered to be a regex. So str.match("?") is valid in flash but
will fail in JS. We ran into that porting our app which includes some code
to test for url params.
So maybe the compiler should identify that the input
Actually, it’s not really necessary to allow null and undefined to get an empty
XML object. The constructor can default to en empty string. So an empty string
could get an XML object while null and undefined could throw an error.
That might make more sense because it would likely catch more erro
I discovered that the documentation on the top level functions is wrong.
According to the docs[1] the only valid expressions for XML and XMLList are:
XML, XMLList, Boolean, Number and String. Anything else is supposed to throw an
error.
What actually happens is that null and undefined are simpl
Sure. But for which events? You seem to have missed my point.
> On Jul 18, 2017, at 10:35 AM, Justin Mclean wrote:
>
>> How often is clone really used?
>
> I’ve used it in just about every single application I've ever written in Flex
> and I assume most applications will need it.
Hi,
> I’m actually not convinced that we should enforce use of cloneEvent on all
> events.
Again in the wiki doc I did put that it may not be required in every case.
If you have bubbles as a parameter it would be reasonable to assume that a
cloneEvent method is needed, where bubble isn’t a par
Hi,
> How are you going to get rid of that rule if we are using different name of
> method in FlexJS ? Rule can be changed itself ?
Rule can be changed and you can create your own rules.
Given this isn't going to come up often (new events are not added that
frequently) and it easy to see compli
30 matches
Mail list logo
