Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-31 Thread Alex Harui
Hi Piotr, It might be time for you to learn how to tweak the builds so they send emails on failure. We could probably use more folks who know how to do it. -Alex On 5/31/17, 11:52 PM, "Alex Harui" wrote: >I just saw that and pushed a fix. > >On 5/31/17, 10:45 PM, "piotrz" wrote: > >>It's com

Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== rather than == and !=

2017-05-31 Thread Justin Mclean
Hi, > if (restrict) {} Style best to be avoided IMO. Lots of things are truthy / falsy in JS. [1] For instance empty string is false and so is NaN and it gets messy fast. [2] Thanks, Justin 1. https://developer.mozilla.org/en-US/docs/Glossary/Falsy 2. https://dorey.github.io/JavaScript-Equali

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-31 Thread Alex Harui
I just saw that and pushed a fix. On 5/31/17, 10:45 PM, "piotrz" wrote: >It's complaining in SWF sight on missing Geolocation class [1] - This is >my >local build SWF only. I've checked couple of things but didn't find root >cause. > >D:\flex_sdk\Sources\flex-asjs\examples\flexjs\MobileMap\src\

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-05-31 Thread Justin Mclean
Hi, > What will happen if some of those values will be null ? For example > styleable.style ? Styleable could be I guess but there wasn’t a null check for it before. Styable.style is unlikely to be null. All test still pass and I’ve tested this with several applications and it never has a null

Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== rather than == and !=

2017-05-31 Thread piotrz
Understand. :) I'm wondering whether all cases are not resolves something like that: if (restrict) {} Just thinking loud, cause I'm fine with your changes here. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.n

Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== rather than == and !=

2017-05-31 Thread Justin Mclean
Hi, > What will happen if "restrict" will be undefined ? A null restrict according to the comment mean any characters means nothing is restricted same as an empty string and that make sense. Undefined is well undefined :-) having an undefined restrict doesn’t really make any sense so I don’t k

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

2017-05-31 Thread Piotr Zarzycki
Hi Justin What will happen if some of those values will be null ? For example styleable.style ? Piotr 2017-06-01 7:58 GMT+02:00 : > make getValue a lot faster - 30ms down to 5ms in a complex app for JS in > Chrome > > > Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo > Commit: ht

Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== rather than == and !=

2017-05-31 Thread Piotr Zarzycki
Hi Justin, What will happen if "restrict" will be undefined ? Piotr 2017-06-01 7:58 GMT+02:00 : > use === and !== rather than == and != > > > Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo > Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/ce22dc67 > Tree: http://

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-31 Thread piotrz
It's complaining in SWF sight on missing Geolocation class [1] - This is my local build SWF only. I've checked couple of things but didn't find root cause. D:\flex_sdk\Sources\flex-asjs\examples\flexjs\MobileMap\src\main\flex\MobileMap.mxml(35): col: 30 Error: Type was not found or was not a comp

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-31 Thread piotrz
I run another one [1] to align with latest commits and we will see what happened. [1] https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/release0.8.0/18/ Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.2

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-31 Thread piotrz
I see that Maven build [1] of release branch is failing. [1] https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/release0.8.0/17/console Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.c

Re: dual issues

2017-05-31 Thread Alex Harui
If targets only has JSFlex, there shouldn't be any SWF compile at all. The console should spit out what it thinks it needs to do. Keep in mind that there are now SWCs for SWFs and SWCs for JS. Prior to dual, there was a main SWC with SWF APIs that the compiler saw, and JS that it substituted in t

Re: dual issues

2017-05-31 Thread Josh Tynjala
As I understand it, the compiler should just take care of differences between JS and SWF, as long as your targets option is correct. VSCode shouldn't need to do anything​ special except to pass in the correct options. There's nothing related to dual changes on my to-do list at this time, but maybe

Re: dual issues

2017-05-31 Thread Harbs
Another weird issue: > /Users/harbs/Documents/git/PrintUI/printui-flexjs/PortedPrintUI/src/com/printui/dummy/view/Image.as(12): > col: 15 interface method imageElement in interface IImage not implemented by > class Image > > public class Image extends BinaryImage >^ >

Re: dual issues

2017-05-31 Thread Harbs
Josh, VS Code is now reporting lots of errors in the Problems window. I’m guessing it does not know how to differentiate between JS and SWF builds using dual? Is that something on your to-do list? Thanks, Harbs > On Jun 1, 2017, at 5:10 AM, Harbs wrote: > > Bingo. Thanks! > > SWF output sti

Re: dual issues

2017-05-31 Thread Harbs
Bingo. Thanks! SWF output still gets all kinds of errors, but the JS output is pretty error free. I still have some fixing up to do before I can see how well it actually works, but at least the compiler is not complaining now. > On Jun 1, 2017, at 4:45 AM, Josh Tynjala wrote: > > Try replacin

Re: dual issues

2017-05-31 Thread Harbs
The examples I see seem to use COMPILE blocks. I’m not sure how this translates to the app level. Is there a way to define a single method which overrides a SWF one and implements a new JS one (without using COMPILE blocks)? That seems to me like a pretty common use case for migrated apps. > O

Re: dual issues

2017-05-31 Thread Justin Mclean
Hi, > I’m using asconfig in VSCode to compile with these settings: > "config": "flex", > "compilerOptions": { > "debug": false, > "js-output-type": "flexjs", > "source-map": false, > "library-path": [ > "lib" > ], I’ve not used VSCode but perhaps try “

Re: dual issues

2017-05-31 Thread Josh Tynjala
Try replacing the js-output-type compiler option with: "targets": ["JSFlex"] - Josh On May 31, 2017 6:26 PM, "Harbs" wrote: > I’m using asconfig in VSCode to compile with these settings: > "config": "flex", > "compilerOptions": { > "debug": false, > "js-output-type": "f

Re: dual issues

2017-05-31 Thread Harbs
In case I wasn’t clear, I’m not outputting SWF — only JS output. > On Jun 1, 2017, at 4:26 AM, Harbs wrote: > > I’m using asconfig in VSCode to compile with these settings: > "config": "flex", > "compilerOptions": { > "debug": false, > "js-output-type": "flexjs", >

Re: dual issues

2017-05-31 Thread Harbs
I’m using asconfig in VSCode to compile with these settings: "config": "flex", "compilerOptions": { "debug": false, "js-output-type": "flexjs", "source-map": false, "library-path": [ "lib" ], > On Jun 1, 2017, at 1:04 AM, Justin Mclean w

Re: dual issues

2017-05-31 Thread Alex Harui
On 5/31/17, 2:38 PM, "Harbs" wrote: >I just switched to dual and I’m getting lots of errors. These errors seem >to be exactly what I was afraid of, and I’m not sure how to resolve >without being restricted by naming of properties and methods. > >1. I’m using a mask setter and getter for images

Re: git commit: [flex-asjs] [refs/heads/release0.8.0] - forgot to delete these two lines

2017-05-31 Thread Alex Harui
Not a CSS property name. On 5/31/17, 2:49 PM, "Justin Mclean" wrote: >HI, > >What the reason for removing backgroundAlpha? > >Thanks, >Justin

Re: dual issues

2017-05-31 Thread Justin Mclean
HI, > Am I missing something? Perhaps try JSFlex in your pom.xml? I believe the name changed from pre to post dual branch. Justin

Re: git commit: [flex-asjs] [refs/heads/release0.8.0] - forgot to delete these two lines

2017-05-31 Thread Justin Mclean
HI, What the reason for removing backgroundAlpha? Thanks, Justin

dual issues

2017-05-31 Thread Harbs
I just switched to dual and I’m getting lots of errors. These errors seem to be exactly what I was afraid of, and I’m not sure how to resolve without being restricted by naming of properties and methods. 1. I’m using a mask setter and getter for images it’s now giving override errors. 2. contai

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-31 Thread OmPrakash Muppirala
Josh is right. There is no way to pass command-line args to an install command. What is there right now is the best way to pass args during an npm install. Thanks, Om On Wed, May 31, 2017 at 9:35 AM, OmPrakash Muppirala wrote: > I should have something in the next 12 hours or so. > > Thanks, >

Re: [FlexJS] Accordion broken

2017-05-31 Thread Harbs
Yishay had some code to handle the cases where it’s not set via MXML which you removed. I changed his code to simply intialize the document if it was not set by MXML like this: //Needed if the layout is not declared using MXML private function initializeDocument

Re: [FlexJS] Accordion broken

2017-05-31 Thread Peter Ent
I'm still working on this and ran into a couple of issues. The flexible child layouts no longer provide a way to explicitly set a child; instead they rely in the child's id being used to retrieve the child from the document. Unfortunately, a layout that is not referenced in MXML will not get its d

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-31 Thread OmPrakash Muppirala
I should have something in the next 12 hours or so. Thanks, Om On May 31, 2017 8:31 AM, "Alex Harui" wrote: Hi Om, Command-line sounds great if you can do it. Let us know when you are done with the NPM stuff so we can move forward with the release. Thanks, -Alex On 5/30/17, 7:15 PM, "Josh

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-31 Thread Alex Harui
Hi Om, Command-line sounds great if you can do it. Let us know when you are done with the NPM stuff so we can move forward with the release. Thanks, -Alex On 5/30/17, 7:15 PM, "Josh Tynjala" wrote: >I could not find a way to parse extra command line arguments with an npm >install command. If