Re: git commit: [flex-asjs] [refs/heads/develop] - FLEX-35243 - Fix problem with unselecting ToggleTextButton - Use classList.toggle api in order to switch between selected and unselected state - Make

2017-01-15 Thread piotrz
Guys, Should this code for selection in JS be somewhere else ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Re-git-commit-flex-asjs-refs-heads-develop-FLEX-35243-Fix-problem-with-unselecting-ToggleT

Re: [FlexJS] Problem in FlexJSStore

2017-01-15 Thread piotrz
Hi Alex, You mean scenario where I have some object for ex. VO and it has sub class and those sub class has property etc. ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Problem-in-FlexJSStor

Re: [FlexJS] add HTMLElement to document.body

2017-01-15 Thread Alex Harui
On 1/15/17, 12:39 PM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >Hi, > >how can I add the "positioner" or "element" created in "createElement" >method to document.body instead to the parent component? Not quite sure what you are looking for, but Application wraps the Body so

Re: [FlexJS] JS loaded with inject_html reports error in browser

2017-01-15 Thread Alex Harui
Create a test without any FlexJS. Just native JS that loads those scripts. Do you get the same error? I think there is plenty of bad code out there that "just works". -Alex On 1/15/17, 12:02 PM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >Hi, > >I'm in the task of making the

Re: [FlexJS] [Discuss] Add support for "automationName" for making unit-tests simpler

2017-01-15 Thread Alex Harui
On 1/15/17, 9:17 AM, "Christofer Dutz" wrote: >Hi, > >Well simply adding an automationName attribute would be small and simple, >adding beads would be more PAYG, but also a lot of more code. >What would be cool would be if we could add such an AutomationBead >similarly as skinClass would be add

Re: [FlexJS] Some things still missing ni FlexJS

2017-01-15 Thread Alex Harui
On 1/15/17, 9:12 AM, "Christofer Dutz" wrote: >What exactly are you talking about when mentioning “Cordova Support”? >Don’t we already have examples that are bundled with Cordova to valid >Mobile Apps? >What’s missing here? Not sure I understand you question, but in another thread I mentioned

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread Alex Harui
Let's make sure we understand the problem. It is always tempting to add more things to the base classes, but IMO we have to keep in mind that we want to use PAYG as much as possible, and use composition more than subclassing. At the lowest level, the Basic set isn't being designed for folks doing

[4.16.0] # Apache Flex SDK 4.16.0 nightly build 204: Successful

2017-01-15 Thread flex . ci . builds
flex-sdk_release-candidate - Build #204 - Successful Changes since last build: No changes For more information, check the console output at http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_release-candidate/204/.

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread OmPrakash Muppirala
On Jan 15, 2017 11:50 AM, "Carlos Rovira" wrote: Hi Om, 2017-01-15 19:58 GMT+01:00 OmPrakash Muppirala : > > I prefer we create a ComponentUIBase based on UIBase and add this logic > here. And make all components extend ComponentUIBase instead of UIBase. > > But considere that at least in MDL w

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread Carlos Rovira
Thanks Josh, currently seems this method is not used at all in FlexJS, since a search doesn't show any ocurrence... maybe we could make UIBase to use ENTER_FRAME for SWF and this other one for JS? (even unify both under "ENTER_FRAME" event?) 2017-01-15 21:45 GMT+01:00 Josh Tynjala : > requestAni

Re: git commit: [flex-asjs] [refs/heads/develop] - FLEX-35243 - Fix problem with unselecting ToggleTextButton - Use classList.toggle api in order to switch between selected and unselected state - Make

2017-01-15 Thread Piotr Zarzycki
I just fixed my first issue in basic component. Let me know if it's ok. I used classList api to do this. :) I did also bindable "selected" property. Piotr 2017-01-15 22:09 GMT+01:00 : > Repository: flex-asjs > Updated Branches: > refs/heads/develop 8018076b5 -> f29c2a480 > > > FLEX-35243 - Fix

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread Josh Tynjala
requestAnimationFrame() is the web browser equivalent of Flash's Event.ENTER_FRAME. https://developer.mozilla.org/en-US/docs/Web/API/window/requestAnimationFrame - Josh On Jan 15, 2017 11:50 AM, "Carlos Rovira" wrote: Hi Om, 2017-01-15 19:58 GMT+01:00 OmPrakash Muppirala : > > I prefer we c

[FlexJS] add HTMLElement to document.body

2017-01-15 Thread Carlos Rovira
Hi, how can I add the "positioner" or "element" created in "createElement" method to document.body instead to the parent component? Thanks -- Carlos Rovira http://about.me/carlosrovira

[FlexJS] JS loaded with inject_html reports error in browser

2017-01-15 Thread Carlos Rovira
Hi, I'm in the task of making the last MDL component "Dialog" As I said, it requires dialog-pollifil: https://github.com/GoogleChrome/dialog-polyfill So in the component constructor I'm using the urls here: https://cdnjs.com/libraries/dialog-polyfill In concrete: /** * constructor

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread Carlos Rovira
Hi Om, 2017-01-15 19:58 GMT+01:00 OmPrakash Muppirala : > > I prefer we create a ComponentUIBase based on UIBase and add this logic > here. And make all components extend ComponentUIBase instead of UIBase. > > But considere that at least in MDL we are in many cases extending FlexJS basic componen

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread OmPrakash Muppirala
On Jan 15, 2017 9:28 AM, "Carlos Rovira" wrote: @Alex, I only use what you propose : typeNames and className, so I think we are in sync. The problem is how to do the maintenance, since we are dealing with classproperties, I think the chosen path (of insert that line per property setter) is the ri

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread Carlos Rovira
@Alex, I only use what you propose : typeNames and className, so I think we are in sync. The problem is how to do the maintenance, since we are dealing with classproperties, I think the chosen path (of insert that line per property setter) is the right way to do, since is only one line of code...we

Re: [FlexJS] [Discuss] Add support for "automationName" for making unit-tests simpler

2017-01-15 Thread Christofer Dutz
Hi, Well simply adding an automationName attribute would be small and simple, adding beads would be more PAYG, but also a lot of more code. What would be cool would be if we could add such an AutomationBead similarly as skinClass would be added in Spark. Some configuration that allows adding A

Re: [FlexJS] Some things still missing ni FlexJS

2017-01-15 Thread Christofer Dutz
What exactly are you talking about when mentioning “Cordova Support”? Don’t we already have examples that are bundled with Cordova to valid Mobile Apps? What’s missing here? Chris Am 15.01.17, 07:58 schrieb "Alex Harui" : On 1/14/17, 4:00 AM, "Vincent" wrote: >So what wo

Re: [FlexJS] Some things still missing ni FlexJS

2017-01-15 Thread Vincent
Hi Alex, I wasn't thinking from a strategical point of view but only from a technical one. That make sense. Thank you. Vincent Le 15/01/2017 à 07:58, Alex Harui a écrit : On 1/14/17, 4:00 AM, "Vincent" wrote: So what would be the interest of choosing technologies like Cordova instead

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread piotrz
Carlos, Alex, Om, Maybe this issue should be resolved as Alex said, but in a higher level. In some UIBase by having this internal list. If I understand correct it will be list which merges both things? Adding aditional could mess up some components - I think Tab, but not sure. Piotr -

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread OmPrakash Muppirala
On Jan 14, 2017 11:07 PM, "Alex Harui" wrote: On 1/14/17, 10:56 PM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >Thinking about this more, we could enclose components in a container div. >The component would have the frozen styles and any classnames the user >sets >would would