Re: [FlexJS] Runtime error when setting a property to a constant value

2017-01-07 Thread OmPrakash Muppirala
I just tested the fix and everything works fine! Piotr and Alex, thanks for fix this so quickly - right in time for my weekend :-) Regards, Om On Sat, Jan 7, 2017 at 3:27 AM, piotrz wrote: > Alex, > > Thank you for help and testing. I had something wrong with the build. > > Om, > > Issue has b

Re: [DISCUSS] Apache Flex SDK 4.16 RC1 release

2017-01-07 Thread Justin Mclean
Hi, > I'm willing to help, but please help us help you. The subject line is > confusing. I assume you tested the CI build and not some RC? The CI build is currently passing and the 4.16 develop branch is identical to the CI. I tested the 4.16 develop branch. > Earlier you referenced some iss

Re: [DISCUSS] Apache Flex SDK 4.16 RC1 release

2017-01-07 Thread Alex Harui
On 1/7/17, 1:54 PM, "Justin Mclean" wrote: >Hi, > >OK I just tried a clean build out on OSX and everything looks good to me. >If someone could confirm everything is OK on windows that would be great. > >If there are no objections I’ll assume lazy consensus and release RC2 in >24 hours. I'm wi

Re: [FlexJS] Some things still missing ni FlexJS

2017-01-07 Thread OmPrakash Muppirala
On Sat, Jan 7, 2017 at 10:47 AM, Carlos Rovira < carlos.rov...@codeoscopic.com> wrote: > Hi Om, > > about Yeoman, I didn't know about that, but it seems to me the same as a > Maven Arquetype to generate a project scaffold. > Right? If is this, we have already 3 of them (created by Chris, and we >

Re: [FlexJS] Some things still missing ni FlexJS

2017-01-07 Thread Alex Harui
If someone has time, add some of these to JIRA. Which, if any, do folks think are 1.0 requirements? IMO, except for more doc and tutorials, the rest of the list is optional for 1.0, but volunteers are welcome to start now. Other opinions welcome. Some comments in-line... On 1/7/17, 9:39 PM, "o

Re: [FlexJS] Some things still missing ni FlexJS

2017-01-07 Thread OmPrakash Muppirala
On Sat, Jan 7, 2017 at 9:42 AM, OmPrakash Muppirala wrote: > > > On Jan 7, 2017 7:59 AM, "Carlos Rovira" wrote: > > Hi, > > I want to list some things I miss from old Flex SDK in FlexJS. Hope others > could bring more if they want. Hope this thread could help us to know what > people things abou

[4.16.0] # Apache Flex SDK 4.16.0 nightly build 194: Successful

2017-01-07 Thread flex . ci . builds
flex-sdk_release-candidate - Build #194 - Successful Changes since last build: No changes For more information, check the console output at http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_release-candidate/194/.

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-07 Thread piotrz
You are right. Maybe there is also other scenarios. One think which I'm going to do for TabBar and Tabs is expose set for selectedIndex - it gives possibility select some TabBarButton on startup. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apa

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-07 Thread Carlos Rovira
mmm...maybe someone could need it to select content vía code? I think we should think if people could needed in some way... 2017-01-07 19:50 GMT+01:00 piotrz : > Carlos, > > I did notice that haven't handle default selection for Tab. I have to fix > it, but I was wondering - What is the purpose o

Re: [DISCUSS] Apache Flex SDK 4.16 RC1 release

2017-01-07 Thread Justin Mclean
Hi, OK I just tried a clean build out on OSX and everything looks good to me. If someone could confirm everything is OK on windows that would be great. If there are no objections I’ll assume lazy consensus and release RC2 in 24 hours. Thanks, Justin

Re: [FlexJS] value.hasOwnProperty not working, maybe a bug

2017-01-07 Thread Alex Harui
What is a test case where Hasownproperty behaves differently between js and as? Sent from my LG G3, an AT&T 4G LTE smartphone -- Original message-- From: Josh Tynjala Date: Sat, Jan 7, 2017 11:12 AM To: dev@flex.apache.org; Subject:Re: [FlexJS] value.hasOwnProperty not working, maybe a bu

Re: [FlexJS] value.hasOwnProperty not working, maybe a bug

2017-01-07 Thread Josh Tynjala
I don't recall it being discouraged. I use it somewhat frequently with the Flash runtimes. Never had a situation where it failed on me. - Josh On Jan 7, 2017 9:42 AM, "Alex Harui" wrote: > Also properties are made via object.defineproperty. > that may affect hasownproperty. I

Re: [FlexJS,MDL][Discuss] Tabs, TabBar with dataProvider+itemRenderer API

2017-01-07 Thread piotrz
Carlos, I did notice that haven't handle default selection for Tab. I have to fix it, but I was wondering - What is the purpose of have isActive property for TabBarPanel. I think it's good to have getter for this one, but setter is redundant - I think. Basically TabBarButton should have isActive

Re: [FlexJS] Some things still missing ni FlexJS

2017-01-07 Thread Carlos Rovira
Hi Om, about Yeoman, I didn't know about that, but it seems to me the same as a Maven Arquetype to generate a project scaffold. Right? If is this, we have already 3 of them (created by Chris, and we could make more) 2017-01-07 18:42 GMT+01:00 OmPrakash Muppirala : > On Jan 7, 2017 7:59 AM, "Carl

Re: [FlexJS, MDL] Help with MDL

2017-01-07 Thread piotrz
Let me handle TabBar in MainNavigation. - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-MDL-Help-with-MDL-tp56556p57992.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] Some things still missing ni FlexJS

2017-01-07 Thread OmPrakash Muppirala
On Jan 7, 2017 7:59 AM, "Carlos Rovira" wrote: Hi, I want to list some things I miss from old Flex SDK in FlexJS. Hope others could bring more if they want. Hope this thread could help us to know what people things about it, if someone expect to implement it: * Modules (or how to make FlexJS lo

Re: [FlexJS] value.hasOwnProperty not working, maybe a bug

2017-01-07 Thread Alex Harui
Also properties are made via object.defineproperty. that may affect hasownproperty. I don't think there is a way around that. Hasownproperty was discouraged in ActionScript for similar reasons, Iirc. Sent from my LG G3, an AT&T 4G LTE smartphone -- Original message--

Re: [FlexJS] value.hasOwnProperty not working, maybe a bug

2017-01-07 Thread Carlos Rovira
Hi Josh, many thanks, your workaround works, but it's a shame that "hasOwnProperty" can't be used and does not be reliable :( Thanks! :) 2017-01-07 17:28 GMT+01:00 Josh Tynjala : > Are you testing a release build? Remember that Closure compiler renames > member variables, so using a string t

Re: [FlexJS, MDL] Help with MDL

2017-01-07 Thread Carlos Rovira
Hi Piotr 2017-01-07 17:18 GMT+01:00 piotrz : > > > I'm not sure what do you mean by: > "In the examples the second list changed the style, is that right? (was > intended)." ? > > sorry, some words was missed. I wanted to say that the style in the second tab example (the one with names from GOT) ar

Re: [FlexJS] value.hasOwnProperty not working, maybe a bug

2017-01-07 Thread Josh Tynjala
Are you testing a release build? Remember that Closure compiler renames member variables, so using a string to check if they exist won't work. It can be frustrating, I know. To this day, I still wish that this drastic renaming with Closure hadn't been the default we chose. It breaks a number of co

Re: [FlexJS, MDL] Help with MDL

2017-01-07 Thread piotrz
I see, so I think I will: - Review discussion about Dialogs - I think we should definitely have it before any release. - Icon Toggle - I will take it. - Table - That's something we could focus much later in my opinion. That will be a lot of work. I'm not sure what do you mean by: "In the example

[FlexJS] Some things still missing ni FlexJS

2017-01-07 Thread Carlos Rovira
Hi, I want to list some things I miss from old Flex SDK in FlexJS. Hope others could bring more if they want. Hope this thread could help us to know what people things about it, if someone expect to implement it: * Modules (or how to make FlexJS load discrete parts and not the all the App at once

Re: [FlexJS, MDL] Help with MDL

2017-01-07 Thread Carlos Rovira
Hi Piotr, going through the MDL site and our table, I think we only have the following list left: * Dialogs (this is a bit tricky since it needs an external script and we discussed a bit in the past how to do it) * Icon Toggle (from Toggles) * Table I'm still with Footer (I complete "mini" and s

Re: [FlexJS, MDL] Help with MDL

2017-01-07 Thread piotrz
Hi Carlos, What are you going to work next? I think I have finished with Tabs and TabBar - The only think which boders mi now that isActive property is not updated yet, but I will look into that when it will be needed. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this messag

[FlexJS] value.hasOwnProperty not working, maybe a bug

2017-01-07 Thread Carlos Rovira
Hi, I have this code in a Item Renderer: override public function set data(value:Object):void { super.data = value; if(value == null) return; /*if(value.hasOwnProperty('label')) { label = String(value.label); } else { label = String(value); }*/ label = String(value.label);

Re: [FlexJS] Runtime error when setting a property to a constant value

2017-01-07 Thread piotrz
Alex, Thank you for help and testing. I had something wrong with the build. Om, Issue has been successfully fixed. :) Currently fix on FlexJS sight is only on your fontawesome branch, Falcon sight fix is on develop. Once you merge it we will have it full tegrated then I will Resolve jira. Piotr