Re: [FlexJS] last git code doesn't work as of 2016 NOV 29

2016-11-28 Thread Alex Harui
On 11/28/16, 11:11 PM, "Pan Li" wrote: > >Could some one guide me to get working binary or source code of 0.8? Can you build and run the DataBindingExample in examples/flexjs? -Alex

[FlexJS] last git code doesn't work as of 2016 NOV 29

2016-11-28 Thread Pan Li
Hi we would like to try 0.8 for our application, but we could not get the last git code building correct, the produced SDK can build FlexJS application but the app fail with runtime javascript error. I checked nightly builds at http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ I download

Re: [FlexJS, MDL] Add icon to DeletableChip

2016-11-28 Thread Alex Harui
On 11/28/16, 10:07 PM, "piotrz" wrote: >Hi Om, Carlos, > >I created yesterday bead DeletableChip. In DeletableChip there is a place >for icon on the right sigh of the Chip. [1] I'm wondering how actually it >should be implemented. > >Should I add to DeletableChip property for example image="can

RE: git commit: [flex-asjs] [refs/heads/develop] - FLEX-35187 - explicitly set default border to none, so viewports can ignore non-existent borders.

2016-11-28 Thread Yishay Weiss
‘none’ is the default value of border-style, so it shouldn’t affect rendering. The problem was in CSSContainerUtils.getBorderMetrics(): var borderStyle:Object = ValuesManager.valuesImpl.getValue(object, "border-style"); borderStyle was evaluated in JS to undefined and the condition that f

Re: [FlexJS, MDL] Add icon to DeletableChip

2016-11-28 Thread piotrz
Example has been eaten by list: -> https://paste.apache.org/sasN - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-MDL-Add-icon-to-DeletableChip-tp56766p56767.html Sent from the Apache Flex Development ma

[FlexJS, MDL] Add icon to DeletableChip

2016-11-28 Thread piotrz
Hi Om, Carlos, I created yesterday bead DeletableChip. In DeletableChip there is a place for icon on the right sigh of the Chip. [1] I'm wondering how actually it should be implemented. Should I add to DeletableChip property for example image="cancel" which takes name of the image ? /cancel/ I

Re: [FlexJS] Naming conventions for Beads

2016-11-28 Thread piotrz
Thanks Carlos. It make sense the way you think. Let's live it as is. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Naming-conventions-for-Beads-tp56755p56765.html Sent from the Apache Flex Dev

Re: [FlexJS] className manipulation

2016-11-28 Thread Josh Tynjala
Yeah, js.swc exposes APIs that may not work in all browsers. Be careful what you use when you go low-level. At the same time, if someone isn't interested in IE9 at all, it wouldn't be a very good experience for them if we completely blocked those low-level APIs that are fully supported on more mod

Re: git commit: [flex-asjs] [refs/heads/develop] - FLEX-35187 - explicitly set default border to none, so viewports can ignore non-existent borders.

2016-11-28 Thread Alex Harui
Are you sure this did not impact any examples? -Alex On 11/28/16, 6:45 AM, "yish...@apache.org" wrote: >Repository: flex-asjs >Updated Branches: > refs/heads/develop 1ae995db3 -> d159d7ed1 > > >FLEX-35187 - explicitly set default border to none, so viewports can >ignore non-existent borders. >

Re: [FlexJS] className manipulation

2016-11-28 Thread Alex Harui
On 11/28/16, 1:14 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >I just tried to compile a line with classList and seems we have the API in >flexjs. Don't try it...already, so If we have the API and compiles, it >should work, so we are supporting it, right? I think you are re

RE: [Bindable] and private setters (was Re: [Falcon])

2016-11-28 Thread Kessler CTR Mark J
+1 for leaving the setter private. -Mark -Original Message- From: Alex Harui [mailto:aha...@adobe.com] Sent: Tuesday, November 22, 2016 1:01 PM To: dev@flex.apache.org Subject: Re: [Bindable] and private setters (was Re: [Falcon]) On 11/22/16, 9:26 AM, "Josh Tynjala" wrote: >If they

RE: git commit: [flex-asjs] [refs/heads/develop] - Don't let order of bead addition confuse collapse bead.

2016-11-28 Thread Yishay Weiss
This is a form of lazy loading. We’re not baking in any new dependencies that weren’t there before. If you look in ContainerView.performLayout(), for example, you’ll see it’s doing the same thing. Some beads rely on other beads to already be loaded, this code essentially makes sure that the d

Re: git commit: [flex-asjs] [refs/heads/develop] - Don't let order of bead addition confuse collapse bead.

2016-11-28 Thread Harbs
An Accordion component needs a layout or it will not work. On Nov 28, 2016, at 11:19 AM, Piotr Zarzycki wrote: > Hi Yishay, > > This layout property is not only returning something but also adding - It > doesn't look good. Is there any other option ? > > 2016-11-28 9:58 GMT+01:00 : > Reposito

Re: git commit: [flex-asjs] [refs/heads/develop] - Don't let order of bead addition confuse collapse bead.

2016-11-28 Thread Piotr Zarzycki
Hi Yishay, This layout property is not only returning something but also adding - It doesn't look good. Is there any other option ? 2016-11-28 9:58 GMT+01:00 : > Repository: flex-asjs > Updated Branches: > refs/heads/develop ce807561d -> 1ae995db3 > > > Don't let order of bead addition confuse

Re: [FlexJS] className manipulation

2016-11-28 Thread Carlos Rovira
I just tried to compile a line with classList and seems we have the API in flexjs. Don't try it...already, so If we have the API and compiles, it should work, so we are supporting it, right? 2016-11-27 18:32 GMT+01:00 OmPrakash Muppirala : > Looks like this polyfill could be useful. > > https://g

Re: [FlexJS] Naming conventions for Beads

2016-11-28 Thread Carlos Rovira
Hi Piotrz, when I started making some beads, and test its use, I notice that names was very verbose and redundant. Since we use to put beads inside package beads (i.e: "beads/SomeBead.as". For that reason I prefer the simple name. People using it, will discover the bead, in its package, or in an