Closure compiler CompilationLevel

2015-09-21 Thread Josh Tynjala
The Closure compiler has three compilation levels. CompilationLevel.WHITESPACE_ONLY CompilationLevel.SIMPLE_OPTIMIZATIONS CompilationLevel.ADVANCED_OPTIMIZATIONS Right now, JSClosureCompilerWrapper specifies the ADVANCED_OPTIMIZATIONS compilation level. This level changes the code the most, but i

Re: [FlexJS] Tooltips and animations

2015-09-21 Thread Alex Harui
On 9/21/15, 2:12 PM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >I think the charts would look so much better with tooltips and animations. > >Do we have a Tooltip/Datatip component in FlexJS yet? > >Also, if I wanted to add some effects and animations, do we have support >for th

Re: [FlexJS] Tooltips and animations

2015-09-21 Thread Peter Ent
There are tooltips for the charts available, without animation. Please give it a go! ‹peter On 9/21/15, 5:12 PM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >I think the charts would look so much better with tooltips and animations. > >Do we have a Tooltip/Datatip component in F

[FlexJS] Tooltips and animations

2015-09-21 Thread OmPrakash Muppirala
I think the charts would look so much better with tooltips and animations. Do we have a Tooltip/Datatip component in FlexJS yet? Also, if I wanted to add some effects and animations, do we have support for that yet? Or should I start adding something to the framework? Thoughts? Thanks, Om

Re: More dog food

2015-09-21 Thread OmPrakash Muppirala
> > >On Mon, Sep 21, 2015 at 9:12 AM, Alex Harui wrote: > > > >>Did you try running from http:// and not just file://? I’m curious as > to > >> how it works around browser cross-domain security. > >> > > > >We control the SuperProxy app on > >https://apache-flex-dashboard.appspot.com, > >so I wen

Re: More dog food

2015-09-21 Thread OmPrakash Muppirala
Okay, all good now. I am subclassing JSONInputParser instead of implementing IInputParser. I've committed all the changes. JS Debug version: https://apache-flex-dashboard.appspot.com/dashboard/bin/js-debug/index.html JS Release version: https://apache-flex-dashboard.appspot.com/dashboard/bin/js

Re: More dog food

2015-09-21 Thread Alex Harui
On 9/21/15, 12:40 PM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >On Mon, Sep 21, 2015 at 9:12 AM, Alex Harui wrote: > >>Did you try running from http:// and not just file://? I’m curious as to >> how it works around browser cross-domain security. >> > >We control the SuperPr

Re: More dog food

2015-09-21 Thread OmPrakash Muppirala
Actually, I copied the IInputParser.as file to the local package. The cross-compiler took care of creating the JS version (SO COOL!!!) I will check it in soon. As expected, I am now hitting the CORS error: XMLHttpRequest cannot load https://apache-flex-dashboard.appspot.com/query?id=ahdzfmFwYWNo

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-21 Thread piotrz
Mihai, As I understand you are running these test using ant ? Another option is running tests in Flash content debugger in Intellij. The question is how did you try run your tests ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-devel

Re: More dog food

2015-09-21 Thread OmPrakash Muppirala
On Mon, Sep 21, 2015 at 9:12 AM, Alex Harui wrote: > > > On 9/21/15, 4:26 AM, "omup...@gmail.com on behalf of OmPrakash Muppirala" > wrote: > > >I have checked in a new example, FlexWebsiteStatsViewer, which, as the > >README says: > > Sounds very cool. Maybe we should integrate it with the pro

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-21 Thread Alex Harui
In the flex-asjs/frameworks/projects/Core/as/tests/build.xml, we use the “command” attribute to choose a browser to run the tests. -Alex On 9/21/15, 8:58 AM, "Mihai Chira" wrote: >All right, I have a very simple test going, but when I run it I see it >fails with a fatal. Which wouldn't be a pro

Re: More dog food

2015-09-21 Thread Alex Harui
On 9/21/15, 4:26 AM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >I have checked in a new example, FlexWebsiteStatsViewer, which, as the >README says: Sounds very cool. Maybe we should integrate it with the project dashboard? > >We have a very rich set of data in our flex.apa

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-21 Thread Mihai Chira
All right, I have a very simple test going, but when I run it I see it fails with a fatal. Which wouldn't be a problem if I had the debugger version of flash player, to see what the error is. But I cannot install it [1]. Is there a way to get the unit tests to open with firefox instead? (Note that

Re: More dog food

2015-09-21 Thread OmPrakash Muppirala
Hi Piotr, The app can be found here: https://github.com/apache/flex-asjs/tree/develop/examples/flexjs/FlexWebsiteStatsViewer Thanks, Om On Sep 21, 2015 6:00 AM, "piotrz" wrote: > Hi Om, > > Where actually I can take a look into this ? Jenkins is building > automatically these project or Am I w

Re: More dog food

2015-09-21 Thread piotrz
Hi Om, Where actually I can take a look into this ? Jenkins is building automatically these project or Am I wrong ? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/More-dog-food-tp49274p49275.h

More dog food

2015-09-21 Thread OmPrakash Muppirala
I have checked in a new example, FlexWebsiteStatsViewer, which, as the README says: ...fetches data from Google Analytics for the website: flex.apache.org, and parses the data into the required format. Then, via data binding, updates the dataprovider for a ColumnChart which renders the data. We

Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34807

2015-09-21 Thread Mihai Chira
Cool, thanks for the explanation. On 21 September 2015 at 11:57, Harbs wrote: > Yes. It’s a coding style I picked up quite some time ago. It assigns the > value to itself if destinationLeaf is null. > > It avoids writing an extra “if” (and keeps everything in one line while > keeping the declar

Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34807

2015-09-21 Thread Harbs
Yes. It’s a coding style I picked up quite some time ago. It assigns the value to itself if destinationLeaf is null. It avoids writing an extra “if” (and keeps everything in one line while keeping the declaration at the beginning of the line). It might be a bit confusing the first time you see

Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34807

2015-09-21 Thread Mihai Chira
Is this line only confusing for me? var destinationParagraph:ParagraphElement = destinationLeaf ? destinationLeaf.getParagraph() : destinationParagraph; Is this the intention? if (destinationLeaf) destinationParagraph = destinationLeaf.getParagraph(); On 19 September 2015 at 21:52, wrote: > Rep

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-21 Thread Mihai Chira
Thanks Piotr. I was just looking at a few of the tests now, and the ones I can find with PasteOperation are UnitTest.Tests.OperationTest.limitPasteTest() and deleteNextCharExceptionTest(), but they are both a bit confusing: the functions are marked private, and the only other references to them are

Re: AW: Compiling FlexJS

2015-09-21 Thread Maxim Solodovnik
Are you compiling with java8? do you have "-Xdoclint:none" in javadoc plugin config? On Mon, Sep 21, 2015 at 1:23 PM, OmPrakash Muppirala wrote: > Oops, spoke too soon. > > Now, javadocs doesn't seem to like me: > > > ==

AW: AW: AW: Working FlexJS examples?

2015-09-21 Thread Christofer Dutz
Another question ... would it be possible to add a call "ant -f maven.xml deploy" to the nightly build? This would make sure the maven nightly builds are also updated and our users can work with them by simply referencing 0.5.0-SNAPSHOT? Currently I manually do that from my computer, but I thin

Re: AW: Compiling FlexJS

2015-09-21 Thread OmPrakash Muppirala
Oops, spoke too soon. Now, javadocs doesn't seem to like me: = s\TreeModelVisitor.java:123: error: unknown tag: T [javadoc] *object must implement @code{IMergePoint}. [javadoc]

Re: AW: Compiling FlexJS

2015-09-21 Thread OmPrakash Muppirala
Seems to be running. I think you should go to sleep now :-) We can continue tomorrow... Thanks, Om On Mon, Sep 21, 2015 at 12:02 AM, Alex Harui wrote: > OK, skip the tests. Just run “ant” in the compiler and compiler.jx > folders. That should be good enough to start building FlexJS stuff. I

Re: AW: Compiling FlexJS

2015-09-21 Thread Alex Harui
OK, skip the tests. Just run “ant” in the compiler and compiler.jx folders. That should be good enough to start building FlexJS stuff. I get 4 errors when running unit tests from Eclipse that I don’t get from the command-line. Not sure why. Let me know of those two folders build and then tr