Re: Mustella SDK tests

2015-05-22 Thread Alex Harui
I have shut down jenkins slave agent so no mustella runs for a while. Please don’t restart jenkins as I may not have time to finish the investigation tonight and will continue over the weekend. I’ll restart it myself when I’m done digging. Thanks, -Alex On 5/22/15, 5:47 AM, "Alex Harui" wrote:

[GitHub] flex-asjs pull request: SCRIPT_HOME not getting defined if FALCON_...

2015-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flex-asjs/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

Re: AW: AW: AW: [FlexJS] IntelliJ Integration

2015-05-22 Thread Alex Harui
Fred, this is great progress! IIRC, the FB compiler calls flex2/tools/oem/Application.java. You can see how this class builds up an OEMReport with messages. It also does some Configuration stuff as well. Hopefully you can grab pieces of this and connect it up with IJ’s entry point. -Alex On 5

Re: AW: AW: AW: [FlexJS] IntelliJ Integration

2015-05-22 Thread Michael Schmalle
On Fri, May 22, 2015 at 1:32 PM, Frédéric THOMAS wrote: > > FWIW, in the FlashBuilder/Falcon integration, I’ve blocked incremental > > compiles, at least for now. Besides there were plenty of bugs in the > > incremental compilation. > > With randori, I've was passing only the files to recompile,

RE: AW: AW: AW: [FlexJS] IntelliJ Integration

2015-05-22 Thread Frédéric THOMAS
> FWIW, in the FlashBuilder/Falcon integration, I’ve blocked incremental > compiles, at least for now. Besides there were plenty of bugs in the > incremental compilation. With randori, I've was passing only the files to recompile, I won't be able to do that here at least for now but maybe @Mike

RE: AW: AW: AW: [FlexJS] IntelliJ Integration

2015-05-22 Thread Frédéric THOMAS
I forgot to mentioned in my tasks, to do the same with the COMPC. Also, to mention, I've been able to compile a Standard FlexJS project and one build from FlexMojos Frédéric THOMAS > From: webdoubl...@hotmail.com > To: dev@flex.apache.org > Subject: RE: AW: AW: AW: [FlexJS] IntelliJ Integration

RE: AW: AW: AW: [FlexJS] IntelliJ Integration

2015-05-22 Thread Frédéric THOMAS
So, I've been able to use the flex-compiler-oem instead of the external tools feature provided by IntelliJ. The all thing is not finished, I still need: 1- Figure out why IntelliJ auto-switch to its internal compiler, that's really not handy !! 2- See, if it is FM or IJ which remove the .swf at

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2015-05-22 Thread Alex Harui
On 5/22/15, 9:30 AM, "Mihai Chira" wrote: >On 22 May 2015 at 17:38, Alex Harui wrote: >> If you’ve been following the FlexJS stuff, you know that I am a >> “pay-as-you-go” advocate. I tend to lean against fancy code that, while >> it makes development faster, is still running at run-time. >I

Re: FlexUnit testing now built into the Flex SDK

2015-05-22 Thread Mihai Chira
Does anyone mind if I get the unit tests to start running as part of the checkintests target? On 10 December 2014 at 16:18, Tom Chiverton wrote: > On 10/12/14 14:21, Erik de Bruin wrote: >> >> [flexunit] Using the following settings for compilation: >> [flexunit] FLEX_HOME: [c:\Jenkins\worksp

Re: FlexJS /bin/mxmlc executable permissions on mac

2015-05-22 Thread Josh Tynjala
If you've created a pull request on Github, and then you make additional commits on the same branch, the commits will automatically be added to your existing pull request. If you want to be able to make more than one pull request, you can do it by creating a separate branch for each one. Don't wor

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2015-05-22 Thread Mihai Chira
On 22 May 2015 at 17:38, Alex Harui wrote: > If you’ve been following the FlexJS stuff, you know that I am a > “pay-as-you-go” advocate. I tend to lean against fancy code that, while > it makes development faster, is still running at run-time. I agree, which is why, after recalling some things I

Re: [jira] [Updated] (FLEX-34852) Allow sorting by complex fields in ListCollectionView

2015-05-22 Thread Alex Harui
On 5/22/15, 8:29 AM, "Mihai Chira" wrote: >See, I'm glad I started this dialogue. Indeed, I was just planning to >detect complex sort fields by the presence of a "." in them. Now, >after writing a simple unit test, I realised that dynamic Objects can >have fields with "." in them by saying obj[

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2015-05-22 Thread Alex Harui
If you’ve been following the FlexJS stuff, you know that I am a “pay-as-you-go” advocate. I tend to lean against fancy code that, while it makes development faster, is still running at run-time. You can say that a simple flag and the code to test whether to call refresh() doesn’t take many CPU cy

Re: [jira] [Updated] (FLEX-34852) Allow sorting by complex fields in ListCollectionView

2015-05-22 Thread Mihai Chira
See, I'm glad I started this dialogue. Indeed, I was just planning to detect complex sort fields by the presence of a "." in them. Now, after writing a simple unit test, I realised that dynamic Objects can have fields with "." in them by saying obj["field.with.dot"] = 1; But I also just noticed tha

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2015-05-22 Thread Mihai Chira
> Folks keep trying to find ways to avoid calls to refresh() and we keep > ending up with other side-effects. Seems dangerous (from a backward > compatibility standpoint) to be making changes like this. When they do that they run into the risk of forgetting to call refresh() in time, or at all. Ke

Re: [jira] [Updated] (FLEX-34852) Allow sorting by complex fields in ListCollectionView

2015-05-22 Thread Alex Harui
OK, well you got me worried by saying it would be a “rather consequential change”. Are you going to add a property to SortField like “complexSortEnabled” and switch between old behavior and new behavior that way? I don’t think you can just presume that “.” means complex field in case folks are so

Re: AW: AW: AW: [FlexJS] IntelliJ Integration

2015-05-22 Thread Alex Harui
FWIW, in the FlashBuilder/Falcon integration, I’ve blocked incremental compiles, at least for now. Besides there were plenty of bugs in the incremental compilation. It looks like (in the flex-sdk repo) modules/compiler/src/java/flex2/tools/Mxmlc.java is a command-line entry point for the compiler

Re: [jira] [Updated] (FLEX-34852) Allow sorting by complex fields in ListCollectionView

2015-05-22 Thread Mihai Chira
>From what I see in the code, it's possible to use SortField and not break backward compatibility; if it won't be the case, I'll consider doing that. (As usual when refactoring, I'm creating unit tests for existing functionality to increase the certainty that existing functionality still works as b

Re: [jira] [Updated] (FLEX-34852) Allow sorting by complex fields in ListCollectionView

2015-05-22 Thread Alex Harui
It might be possible to add a ComplexSortField class here and have it do the extra work without breaking backward compatibility. -Alex On 5/22/15, 7:41 AM, "Mihai Chira" wrote: >Because this can be a rather consequential change, I thought I'd ask >whether people think it's a good idea before I

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2015-05-22 Thread Alex Harui
Folks keep trying to find ways to avoid calls to refresh() and we keep ending up with other side-effects. Seems dangerous (from a backward compatibility standpoint) to be making changes like this. You could experiment with a new set of Sort classes that take a reference to an LCV and auto-call re

Re: [jira] [Updated] (FLEX-34852) Allow sorting by complex fields in ListCollectionView

2015-05-22 Thread Mihai Chira
Because this can be a rather consequential change, I thought I'd ask whether people think it's a good idea before I finish coding it. If it's something you've worked with, or your application uses heavily, let me know what you think, or ask me details about it. Otherwise we can just do our commit-t

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2015-05-22 Thread Mihai Chira
> collection.sort but nothing happens until the call refresh(). This is > helpful if you have to make several changes to the sort (rather than just a > one line change to sort.fields) as it avoids multiple re-sorts on a > partially set up sort. that's true, and in the vast majority of cases it can

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2015-05-22 Thread Tom Chiverton
I thought it was meant to work this way, you can do what you like to collection.sort but nothing happens until the call refresh(). This is helpful if you have to make several changes to the sort (rather than just a one line change to sort.fields) as it avoids multiple re-sorts on a partially se

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2015-05-22 Thread Mihai Chira
I started to work on this and realised that this might be seen as a pseudo-feature, rather than a bug. (To my mind it's a bug.) Pseudocode for how it works now and how I think it should work: 1. NOW: const sortByIndexAscending:Sort = new Sort(); sortByIndexAscending.fields = [new SortField("index"

RE: AW: AW: AW: [FlexJS] IntelliJ Integration

2015-05-22 Thread Frédéric THOMAS
Hi Alex, Well, as per [1], I thought we would have keep the same feature for Falcon. And In IntelliJ, as per their doc, you can select which of the available Flex compilers should be used: 1- Built-in compiler shell. An IntelliJ IDEA compiler shell which uses the Flex SDK

Re: FlexJS nightly install fails on Google Closure Library download using installer

2015-05-22 Thread Marcus Fritze
Hi Alex, thanks this works. Marcus > Am 22.05.2015 um 14:42 schrieb Alex Harui : > > Hi Marcus, > > Yes, the original FlexJS 0.0.2 release has a hard coded URL that can’t be > changed. That’s why there is a FlexJS 0.0.2 (with Jburg) package in the > list of choices that should work. Let us k

RE: AW: AW: AW: AW: [FlexJS] IntelliJ Integration

2015-05-22 Thread Frédéric THOMAS
Hi Chris, > Hehe ... I think I got your questions now ... sometimes it's good reading > twice ;-) No problem :) > 1. Well this is something that the IntelliJ Guys should work on ... I doubt > its anything we can do. Ok I will see if I can do something when I'll be on the plugin stuffs > 2.

Re: Mustella SDK tests

2015-05-22 Thread Alex Harui
OK, go shut down Jenkins. I hope to get this FlexJS fix in today and then I’ll look at Mustella. -Alex On 5/22/15, 5:31 AM, "Tom Chiverton" wrote: > >On 21/05/15 16:13, Alex Harui wrote: >> On 5/21/15, 8:01 AM, "Tom Chiverton" wrote: >> >>> I've pressed 'keep forever' on >>> http://flex-muste

Re: FlexJS nightly install fails on Google Closure Library download using installer

2015-05-22 Thread Alex Harui
Hi Marcus, Yes, the original FlexJS 0.0.2 release has a hard coded URL that can’t be changed. That’s why there is a FlexJS 0.0.2 (with Jburg) package in the list of choices that should work. Let us know if it doesn’t. Thanks, -Alex On 5/22/15, 3:07 AM, "Marcus Fritze" wrote: >Hi, > >just for

Re: Mustella SDK tests

2015-05-22 Thread Tom Chiverton
On 21/05/15 16:13, Alex Harui wrote: On 5/21/15, 8:01 AM, "Tom Chiverton" wrote: I've pressed 'keep forever' on http://flex-mustella.cloudapp.net/job/flex-sdk_mustella/1484/ OK, not sure what that button does, but I need the workspace not the artifacts. Well the most recent build appears

Re: FlexJS nightly install fails on Google Closure Library download using installer

2015-05-22 Thread Carlos Rovira
Hi Alex, fixed for me. Installing Nightly 0.0.3 with AIR + FP 17 Thanks! 2015-05-22 12:07 GMT+02:00 Marcus Fritze : > Hi, > > just for your info: the installer (version 3.1.0) still fails for me when > installing flexJS 0.0.2 with the same error. > > I am located in Leipzig, Germany. > > Thanks

Re: FlexJS nightly install fails on Google Closure Library download using installer

2015-05-22 Thread Marcus Fritze
Hi, just for your info: the installer (version 3.1.0) still fails for me when installing flexJS 0.0.2 with the same error. I am located in Leipzig, Germany. Thanks Marcus > Am 21.05.2015 um 19:17 schrieb Carlos Rovira : > > Hi Alex, > > just tried, but sorry it fails in the same way :( >