Re: TLF Unit Tests

2015-01-24 Thread Justin Mclean
Hi, > Here’s the texts which are all clearly public domain: > 1) Alice in Wonderland (and parts of it) > 2) Parts of Nathaniel Hawthorne by Ethan Brand > 3) John F. Kennedy’s “ask not” speech. > 4) The Barnsley Manifesto All of the above are public domain and need to be correctly licensed and at

TLF version control/license issues

2015-01-24 Thread Justin Mclean
Hi, OK I looked though the TLF code in version control and here's the list of what I found. I may of missed some things and this is not a complete list but I've run out of time. Jar in version control: ./ant/flexUnitTasks.jar Swcs in version control: ./libs/flexunit-cilistener.swc ./l

RE: [VOTE] Apache Flex SDK 4.14.0 RC2

2015-01-24 Thread Chris Martin
+1 (binding) Package https://dist.apache.org/repos/dist/dev/flex/sdk/4.14.0/rc2/apache-flex-sdk-4.14.0-src.zip Java 1.8 OS: Windows 8.1 amd64 6.3 Source kit signatures match: y Source kit builds: y README is ok: y RELEASE_NOTES is ok: y NOTICE is ok: y LICENSE is ok: y No unapproved licenses or ar

Re: TLF Unit Tests

2015-01-24 Thread Justin Mclean
Hi, > Are you telling me that if include pieces of the Bible, we’re REQUIRED to > give attribution to G-d in the NOTICE file? ;-) :-) Not exactly I believe you would need to attribute the version it come from for instance English Standard [1] or Revised Standard Version [2]. (Just as example

Re: TLF Unit Tests

2015-01-24 Thread Harbs
I did not see that. Are you telling me that if include pieces of the Bible, we’re REQUIRED to give attribution to G-d in the NOTICE file? ;-) On Jan 25, 2015, at 12:25 AM, Justin Mclean wrote: > Hi, > >> Any particular reason? > > As they spell out how public domain content needs to be delt

Re: TLF Unit Tests

2015-01-24 Thread Harbs
I’m not going to comment on this. TLF markup is Apache content. The only thing that might possibly be worth doing for the public domain text is adding to the NOTICE file that portions of the texts used for testing comes from public domain. On Jan 25, 2015, at 12:09 AM, Justin Mclean wrote: >

Re: TLF Unit Tests

2015-01-24 Thread Justin Mclean
Hi, > Any particular reason? As they spell out how public domain content needs to be delt with ie keep origin license and attribution in the the NOTICE file. Justin

Re: [9/9] git commit: [flex-tlf] [refs/heads/develop] - Revert "clean out some stuff that should have been filtered out of the donation"

2015-01-24 Thread Justin Mclean
Hi, > The file has XML markup for TLF, so it needs the Apache header. It should only have the Apache header if it was original license under Apache or was donated to Apace and it license able to be changed. See LEGAL-72 and LEGAL-75 for what needs to be one. Justin

Re: TLF Unit Tests

2015-01-24 Thread Harbs
Any particular reason? It’s interesting if you like racing about legal issues, but I don’t see what it has to do with our discussion. On Jan 25, 2015, at 12:15 AM, Justin Mclean wrote: > Hi, > > You can also want to read: > https://issues.apache.org/jira/browse/LEGAL-72 > https://issues.apach

Re: TLF Unit Tests

2015-01-24 Thread Alex Harui
You said "And last I cheaked Alice in wonder land wasn't under an Apache license” I took that to mean that Alice wasn’t properly donated. On 1/24/15, 1:51 PM, "Justin Mclean" wrote: >Hi, > >> Ha, that's what I get for not double checking justin. I'll revert in a >>bit. > >The text in question

Re: TLF Unit Tests

2015-01-24 Thread Justin Mclean
Hi, You can also want to read: https://issues.apache.org/jira/browse/LEGAL-72 https://issues.apache.org/jira/browse/LEGAL-75 Justin

Re: [9/9] git commit: [flex-tlf] [refs/heads/develop] - Revert "clean out some stuff that should have been filtered out of the donation"

2015-01-24 Thread Harbs
I disagree. The file has XML markup for TLF, so it needs the Apache header. On Jan 25, 2015, at 12:04 AM, Justin Mclean wrote: > And the license for Alice in wonderland is incorrect as it is not Apache > licensed.

Re: [9/9] git commit: [flex-tlf] [refs/heads/develop] - Revert "clean out some stuff that should have been filtered out of the donation"

2015-01-24 Thread Harbs
AFAIK you can’t veto a revert — only a commit. As Alex said, this is pending removing the stuff that’s really a problem. On Jan 25, 2015, at 12:04 AM, Justin Mclean wrote: > Hi, > > -1 as this puts stuff we don't have legal permission to use > > In particular: > sdk/samples/flex/Logo.jpg

Re: TLF Unit Tests

2015-01-24 Thread Justin Mclean
Hi, > The files are xml files. So an Apache license seems to be correct. Making something XML format doesn't change the original license. > The xml files contain text from public domain which is not a problem either, > so I don’t see any issue there at all. Putting an Apache licence on somethi

Re: JAR in TLF svn/git mirror

2015-01-24 Thread Harbs
The only thing that concerns me from Justin’s list is the Arial font and possibly the Adobe logo. I’m not sure what the Arial font is used for. Piotr will have to comment on that. As far as I can tell, the Adobe logo is not used, so removing that should be fine. On Jan 25, 2015, at 12:03 AM,

Re: [9/9] git commit: [flex-tlf] [refs/heads/develop] - Revert "clean out some stuff that should have been filtered out of the donation"

2015-01-24 Thread Justin Mclean
Hi, -1 as this puts stuff we don't have legal permission to use In particular: sdk/samples/flex/Logo.jpg test/testFiles/assets/ARIAL_FONT.swf (and possibly others) And the license for Alice in wonderland is incorrect as it is not Apache licensed. Justin On 25 Jan 2015, at 8:50 am, aha..

Re: JAR in TLF svn/git mirror

2015-01-24 Thread Alex Harui
I’ve reverted all the way back to before I tried fixing issues in Justin’s list. Once everything passes, I’ll try removing a few things. On 1/24/15, 2:02 PM, "Harbs" wrote: >However, as far as I can tell the image was not used in any of the tests, >so it’s probably safe to remove it if you want

Re: JAR in TLF svn/git mirror

2015-01-24 Thread Harbs
However, as far as I can tell the image was not used in any of the tests, so it’s probably safe to remove it if you want. On Jan 25, 2015, at 12:00 AM, Harbs wrote: > Yes. But it was obviously taken by an Adobe employee and then donated to > Apache, so there’s no IP issues there. > > On Jan 2

Re: JAR in TLF svn/git mirror

2015-01-24 Thread Harbs
Yes. But it was obviously taken by an Adobe employee and then donated to Apache, so there’s no IP issues there. On Jan 24, 2015, at 11:57 PM, Justin Mclean wrote: > Hi, > >>> For instance we probably don't have permission to redistribute: >>> https://github.com/apache/flex-tlf/blob/develop/tes

Re: JAR in TLF svn/git mirror

2015-01-24 Thread Justin Mclean
Hi, >> For instance we probably don't have permission to redistribute: >> https://github.com/apache/flex-tlf/blob/develop/test/testFiles/assets/image1.jpg >> I would be surprised if the above image was public domain. Justin

Re: TLF Unit Tests

2015-01-24 Thread Harbs
The files are xml files. So an Apache license seems to be correct. The xml files contain text from public domain which is not a problem either, so I don’t see any issue there at all. On Jan 24, 2015, at 11:51 PM, Justin Mclean wrote: > Hi, > >> Ha, that's what I get for not double checking ju

Re: TLF Unit Tests

2015-01-24 Thread Justin Mclean
Hi, > Ha, that's what I get for not double checking justin. I'll revert in a bit. The text in question had an Apache licence on it, and as I stated that's incorrect. Were did I ask you to remove it from version control? Justin

Re: JAR in TLF svn/git mirror

2015-01-24 Thread Harbs
Yes. The tests do not do image comparisons. It’s only position, structure and metrics. The following images appear to be used in the tests: carrot.png FremontBridge.jpg fakepng.png gremlin.jpg leaves.jpg RedCircles.swf smiley.gif smiling.png smiling.swf.png surprised.png They do not look to me

Re: JAR in TLF svn/git mirror

2015-01-24 Thread Alex Harui
On 1/24/15, 1:22 PM, "Harbs" wrote: > >On Jan 24, 2015, at 2:53 AM, Justin Mclean >wrote: >> >> In fact several things under here: >> https://github.com/apache/flex-tlf/tree/develop/test/testFiles/assets >> >> For instance we probably don't have permission to redistribute: >> >>https://gith

Re: JAR in TLF svn/git mirror

2015-01-24 Thread Harbs
On Jan 24, 2015, at 2:53 AM, Justin Mclean wrote: > > In fact several things under here: > https://github.com/apache/flex-tlf/tree/develop/test/testFiles/assets > > For instance we probably don't have permission to redistribute: > https://github.com/apache/flex-tlf/blob/develop/test/testFiles/a

Re: JAR in TLF svn/git mirror

2015-01-24 Thread Erik de Bruin
If you explain what needs to be build, I can get Jenkins to build it prior to launching the tests, no problem. EdB On Sat, Jan 24, 2015 at 9:57 PM, piotrz wrote: > Hi Guys, > > Files in /ant and /libs folders are needed for Unit tests in TLF. All these > files should be removed also from our g

Re: JAR in TLF svn/git mirror

2015-01-24 Thread piotrz
Hi Guys, Files in /ant and /libs folders are needed for Unit tests in TLF. All these files should be removed also from our git repository ? If yes - How Jenkins will build everything and launch tests ? Is there any specific path where we can point once we remove files from repository ? Piotr -

Re: TLF Unit Tests

2015-01-24 Thread Alex Harui
Ha, that's what I get for not double checking justin. I'll revert in a bit. Sent via the PANTECH Discover, an AT&T 4G LTE smartphone. Harbs wrote: Here’s the texts which are all clearly public domain: 1) Alice in Wonderland (and parts of it) 2) Parts of Nathaniel Hawthorne by Ethan Brand 3) Joh

Re: [FlexJS] FlexJSStore

2015-01-24 Thread jude
Way to go! On Fri, Jan 23, 2015 at 11:12 PM, Angelo Anolin wrote: > Great work Alex! (and to the rest of the guys/gals as well). Keep it up. > > On Fri, Jan 23, 2015 at 6:53 PM, OmPrakash Muppirala > > wrote: > > > This is SO cool! > > > > Thanks, > > Om > > On Jan 24, 2015 4:52 AM, "Alex Harui

Re: TLF Unit Tests

2015-01-24 Thread Harbs
Here’s the texts which are all clearly public domain: 1) Alice in Wonderland (and parts of it) 2) Parts of Nathaniel Hawthorne by Ethan Brand 3) John F. Kennedy’s “ask not” speech. 4) The Barnsley Manifesto 5) UN Universal Declaration of Human Rights 6) The Bible in Hebrew The following are Adobe

Re: TLF Unit Tests

2015-01-24 Thread Harbs
It looks to me that we are fine with this: http://www.apache.org/legal/resolved.html#can-works-placed-in-the-public-domain-be-included-in-apache-products I’ll be happy to check the rest of the test texts to make sure they are all public domain. On Jan 24, 2015, at 9:50 PM, Harbs wrote: > Why i

Re: TLF Unit Tests

2015-01-24 Thread Harbs
Why is that a problem? As Erik points out, it’s currently public domain text. I did not go through all the text, but I’m sure Adobe picked open domain text for all the tests.(i.e. I noticed the Hebrew text is text from the bible. You can’t get more open domain then that…);-) Swapping out the te

Re: TLF Unit Tests

2015-01-24 Thread Erik de Bruin
http://www.alice-in-wonderland.net/alice11.html#9 EdB On Sat, Jan 24, 2015 at 7:38 PM, Alex Harui wrote: > Piotr, Harbs, > > Turns out the TLF tests are infested with text from Alice In Wonderland > and probably other famous text. Do either of you (or anybody else) have > time to overhaul the

TLF Unit Tests

2015-01-24 Thread Alex Harui
Piotr, Harbs, Turns out the TLF tests are infested with text from Alice In Wonderland and probably other famous text. Do either of you (or anybody else) have time to overhaul the tests? I think you probably would be faster at it than me. I’m not that familiar with FlexUnit and how it manages re

Re: AW: JAR in TLF svn/git mirror

2015-01-24 Thread Alex Harui
On 1/24/15, 1:25 AM, "Christofer Dutz" wrote: >I think you are running the "Ant" build on the "Maven" project ... I have >never gotten the Ant build to work. When did you last try? I’m pretty sure I got it to work. It works for me. Hopefully Justin’s technique for scrubbing will be to blow

AW: [DISCUSS] Release Apache Flex 4.14.0

2015-01-24 Thread Christofer Dutz
Hi guys, Actually ... in my experience. The most issues preventing my customers from treating an project releaseable, is that these strange workflows are handled. Especially changing the locale. When thinking about non-native speakers I think this use-case is not so far from reality. Assuming

Re: Configure our Jenkins to auto-build feature and release branches?

2015-01-24 Thread Erik de Bruin
It does that already ;-) We've been building nightlies from the release branch for nearly two months. It would be interesting to see if this can be automated. EdB On Saturday, January 24, 2015, Christofer Dutz wrote: > Hi, > > I'm currently consumed with doing trainings on continuous deliv

AW: JAR in TLF svn/git mirror

2015-01-24 Thread Christofer Dutz
I think you are running the "Ant" build on the "Maven" project ... I have never gotten the Ant build to work. As the Maven build works like a charm, I would stick to that. I think we also discussed retiring the stuff outside the "modules" directory and as soon as I initiate a release for BlazeDS

AW: JAR in TLF svn/git mirror

2015-01-24 Thread Christofer Dutz
Well I think it wasn't completely skipped. When I made the BlazeDS testsuite run again. I a lot of files were missing. When looking into the old Adobe repos I could see these were all files with license headers of individual contributors ("This code is property of XYZ Telecom") and similarly lic

AW: locales and player global

2015-01-24 Thread Christofer Dutz
Hi Justin, I encountered this during my work on the mavenizer. What I found even more strange is that the rb files come from us and the playerglobal from adobe so there is no chance the playerglobal would actually rely on them. Having a look at the rb files, it seemed to me that they are all em

Configure our Jenkins to auto-build feature and release branches?

2015-01-24 Thread Christofer Dutz
Hi, I'm currently consumed with doing trainings on continuous delivery stuff ... while preparing my slides I stumbled over a jenkins plugin to auto-build feature branches by defining the job for "develop" and automatically using that as template for the feature branches. I bet it should be poss

Re: [DISCUSS] Release Apache Flex 4.14.0

2015-01-24 Thread OmPrakash Muppirala
On Jan 24, 2015 1:52 PM, "Justin Mclean" wrote: > > Hi, > > > You are a member of our PMC so go for it. Others who are interested in > > helping are encouraged to join. But again, please try to save all your > > findings for one report. Right now, my priorities are on getting this > > release o

Re: [DISCUSS] Release Apache Flex 4.14.0

2015-01-24 Thread Alex Harui
On 1/24/15, 12:29 AM, "Justin Mclean" wrote: >Hi, > >> My vote remains +1. The files in the source package have passed my >>review. > >My question still stands, irrespective of how you voted. I’m not the RM, but if I was, I would post the bits if I get the right vote count. The contents of t

Re: [DISCUSS] Release Apache Flex 4.14.0

2015-01-24 Thread Justin Mclean
Hi, > My vote remains +1. The files in the source package have passed my review. My question still stands, irrespective of how you voted. Justin

Re: [DISCUSS] Release Apache Flex 4.14.0

2015-01-24 Thread Alex Harui
On 1/24/15, 12:21 AM, "Justin Mclean" wrote: >I assume you will hold off releasing until this review is complete then? My vote remains +1. The files in the source package have passed my review. -Alex

Re: [DISCUSS] Release Apache Flex 4.14.0

2015-01-24 Thread Justin Mclean
Hi, > You are a member of our PMC so go for it. Others who are interested in > helping are encouraged to join. But again, please try to save all your > findings for one report. Right now, my priorities are on getting this > release out. I assume you will hold off releasing until this review is

Re: [DISCUSS] Release Apache Flex 4.14.0

2015-01-24 Thread Alex Harui
On 1/24/15, 12:07 AM, "Justin Mclean" wrote: >HI, > >> Donation procedures were followed correctly. Could some file have >>incorrect provenance? Sure. > >I think it a little more than some files. If a casual glance in 5 minutes >can pick up some issues it's quite likely there's more issues th

Re: [DISCUSS] Release Apache Flex 4.14.0

2015-01-24 Thread Justin Mclean
HI, > Donation procedures were followed correctly. Could some file have incorrect > provenance? Sure. I think it a little more than some files. If a casual glance in 5 minutes can pick up some issues it's quite likely there's more issues there. This is a formal request to have the PMC review