FormLayout not aligning

2014-02-22 Thread Oleg Konovalov
Hi, I have a Spark TitleWindow popup which has a Spark Form and a lot of FormItems, say 15 (mostly Label and DropDownList's). Labels range from 2-5cm. I do have FormLayout specified inside that Form (and VerticalLayout outside it, because there is a few Buttons at the bottom of the window, but out

Re: Unit Tests

2014-02-22 Thread Peter Hall
The change is very simple: https://github.com/peterjoel/flex-sdk/commit/cf597a5bb548bd3b82830573f58031c539289aeb#diff-4d5aeaf88d407ba618ef8cec016c0443L1213 But the surrounding code is a bit hard to understand, and I'm unclear on what the original intent was, as it didn't make much sense. I am not

Re: Unit Tests

2014-02-22 Thread Justin Mclean
Hi, > I have a fix for a bug (FLEX-34101), related to ListCollectionView. I'd > like to submit a patch. Submit a patch - there some mustella tests and I also have some flex unit tests I can run. Thanks, Justin

DataGroup elements window adjustments

2014-02-22 Thread Oleg Konovalov
Hi, I have a Spark TitleWindow popup with Form, which among other widgets includes DataGroup (one of FormItem's) with custom ItemRenderer (where I put rows of data as per dataProvider contents - custom component). So user should Add or Remove a row of data on button click. Adding/Removing row work

Unit Tests

2014-02-22 Thread Peter Hall
I have a fix for a bug (FLEX-34101), related to ListCollectionView. I'd like to submit a patch but I can't find unit tests for that class or any of the collections code. Do tests exist or is it just the Mustella tests? Peter

Unit Tests

2014-02-22 Thread Peter Hall
I have a fix for a bug (FLEX-34101), related to ListCollectionView. I'd like to submit a patch but I can't find unit tests for that class or any of the collections code. Do tests exist or is it just the Mustella tests? Peter

Re: Carlos, please revert 8745a94d0d6885db01aad1eb31df73b262612cf1

2014-02-22 Thread Erik de Bruin
I think the compiler is correct in suggesting the use of "is" over "instanceof", but as long as "instanceof" is valid Actionscript, we need to test for it. EdB On Sat, Feb 22, 2014 at 3:15 PM, Carlos Rovira < carlos.rov...@codeoscopic.com> wrote: > Hi Erik, > > done. sorry, I was not aware of

Re: Carlos, please revert 8745a94d0d6885db01aad1eb31df73b262612cf1

2014-02-22 Thread Carlos Rovira
Hi Erik, done. sorry, I was not aware of this. Maybe something to be updated in compiler? 2014-02-22 10:08 GMT+01:00 Erik de Bruin : > Carlos, > > Can you please revert your changes to LanguageTests.as? The use of > 'instanceof' is intentional, as it is a valid language construct that needs >

Re: How can I compile my code to js using FlexJS?

2014-02-22 Thread Erik de Bruin
The links is fine, the link he's redirected to is a mobile link. My guess is he's checking the wiki on his cellphone or tablet... EdB On Sat, Feb 22, 2014 at 8:09 AM, Alex Harui wrote: > I just tried the link and it worked for me. Try again in case the wiki > wasn't working right. > > -Alex

Re: [FlexJS] TileLayout.js errors

2014-02-22 Thread Erik de Bruin
Committed the fixes for the JSHint errors. EdB On Sat, Feb 22, 2014 at 7:56 AM, Alex Harui wrote: > OK, hopefully Peter can clean that up on Monday. Thanks for fixing the > other build.xml files. > > -Alex > > From: carlos.rov...@gmail.com [carlos.rov

Carlos, please revert 8745a94d0d6885db01aad1eb31df73b262612cf1

2014-02-22 Thread Erik de Bruin
Carlos, Can you please revert your changes to LanguageTests.as? The use of 'instanceof' is intentional, as it is a valid language construct that needs to be tested. Thanks, EdB -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl

RE: Mobile grid skin warnings while making a release build

2014-02-22 Thread Maurice Amsellem
Fixed and committed. Should be good now. -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : samedi 22 février 2014 09:43 À : dev@flex.apache.org Objet : RE: Mobile grid skin warnings while making a release build > Looks pointless isn't it? Should we

RE: Mobile grid skin warnings while making a release build

2014-02-22 Thread Maurice Amsellem
> Looks pointless isn't it? Should we just remove them? What the asdoc compiler error doesn't show is the metadata before the const: [Embed(source="../../../assets/images/mobile320/dg_header_shadow.png")] private const headerShadowCls320:Class; So IMO, it's legal, it's just that the asd