Re: How to compile and contribute Flex SDK in IntelliJ 12 with Git?

2013-04-07 Thread Nicholas Kwiatkowski
I'm working on a new tutorial... I had some time to muck around with it this weekend... Fred, can you check to see if my push I did to the SVN-TEST file came through ok? -Nick On Sun, Apr 7, 2013 at 6:27 PM, Frédéric THOMAS wrote: > Well, as I said in the 1rst post, you can simplify your life

Re: How to compile and contribute Flex SDK in IntelliJ 12 with Git?

2013-04-07 Thread Frédéric THOMAS
Well, as I said in the 1rst post, you can simplify your life using the installer, it will install the sdk 4.9.1 for you and that's will be your base I never tried it like that but I think it should work, you can then start to the step 6, don't forget the 1rst step, manually clone the sdk 'git c

Re: How to compile and contribute Flex SDK in IntelliJ 12 with Git?

2013-04-07 Thread Marcus Fritze
Thanks again for your answer. To be honest this doesn't makes sense to me and I don't understand this, but I try to figure it out. Marcus Am 08.04.2013 um 00:03 schrieb Frédéric THOMAS : > Well, I didn't say to use IDEA before the step 6, the more complicated part > is the sdk setup, once don

Re: How to compile and contribute Flex SDK in IntelliJ 12 with Git?

2013-04-07 Thread Frédéric THOMAS
Well, I didn't say to use IDEA before the step 6, the more complicated part is the sdk setup, once done, that's easy, in more those steps are nothing relative to the videos you can find on internet but it works for me. The 1srt part is Apache Flex specifics, the 2nd one is the best way I found.

Re: How to compile and contribute Flex SDK in IntelliJ 12 with Git?

2013-04-07 Thread Marcus Fritze
Thanks Frederic for the detailed description. I tried your tutorial, but this doesn't work for me. It seems there is no easy way to load the Flex SDK into IntelliJ as a full project (as described in the video for IDEA 11.1 by Nicholas Kwiatkowski) or even import. I think the video show a very g

Re: Extra Merge?

2013-04-07 Thread Frédéric THOMAS
And finally to answer your question in the situation you was: Just saw an extra merge in my commits when I pushed 2 different fixes. Is that a Fast-Forward issue? I was expecting to see just the two commits and it be inline with my other ones? That's because, you didn't do a 'git fetch' befor

Re: Extra Merge?

2013-04-07 Thread Frédéric THOMAS
Hi Mark, For the FLEX-33190, I would have separated it into 2 commits, the reason behind that is because one is relative to the code and one relative to the doc, splitting it into 2 commits gives you the possibility to revert one w/o to to touch the other. For the FLEX-33477, I would have re

Extra Merge?

2013-04-07 Thread Mark Kessler
Just saw an extra merge in my commits when I pushed 2 different fixes. Is that a Fast-Forward issue? I was expecting to see just the two commits and it be inline with my other ones? Steps I did during were... starting from develop... -checkout FLEX-33477 (new branch) -rebase from the origin -Up

[jira] [Commented] (FLEX-33477) Listbase doesn't expose setSelectedIndex

2013-04-07 Thread Mark Kessler (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-33477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624956#comment-13624956 ] Mark Kessler commented on FLEX-33477: - Modified the ASDOC tags to use the current play

[jira] [Commented] (FLEX-33190) GridEvent.GRID_DOUBLE_CLICK is dispatched even when two different cells are clicked

2013-04-07 Thread Mark Kessler (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-33190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624954#comment-13624954 ] Mark Kessler commented on FLEX-33190: - Modified the ASDOC tags to use the current play

Re: [jira] [Assigned] (FLEX-33451) The release build due to the Git migration is broken

2013-04-07 Thread Alex Harui
PhoneGap supposedly releases monthly. In theory, there is no optimal schedule, and my understanding of the Apache Way is to release often mainly to keep the committers and other contributors feeling like their work is hitting the streets often enough to keep contributing. PhoneGap seems to have l

[jira] [Closed] (FLEX-33397) Spark button skin doesn't exclude coloring icon.

2013-04-07 Thread Mark Kessler (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-33397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Kessler closed FLEX-33397. --- > Spark button skin doesn't exclude coloring icon. >

[jira] [Closed] (FLEX-33448) DataGrid doubleClickMode getter event binder not being called

2013-04-07 Thread Mark Kessler (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-33448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Kessler closed FLEX-33448. --- Assignee: Mark Kessler > DataGrid doubleClickMode getter event binder not being called >

Re: git commit: FLEX-33477: Update ComboBox.as setSelectedIndex ASDOC comments to match that of the ListBase

2013-04-07 Thread Mark Kessler
Well then I'll go change those in here in a few. On Sun, Apr 7, 2013 at 10:06 AM, Alex Harui wrote: > > > > On 4/7/13 5:28 AM, "Mark Kessler" wrote: > > > Ok so lets see if this is where we agree. The changes I just made on the > > ComboBox and ListBase should keep the old values since they

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
Yes. I understand. I appreciate your hand-holding… I'll try to wrap my head around this a bit later… On Apr 7, 2013, at 6:21 PM, Frédéric THOMAS wrote: > I understand very well what you mean Harbs, that's the reason I was trying to > think with you and go progressively forward with the tests, g

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
I understand very well what you mean Harbs, that's the reason I was trying to think with you and go progressively forward with the tests, git and bug correction. If it is not already too much for a start, read the following. The first part of the test 'setup' says reset the component with thos

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
Yeah. Easy if you know what you're looking at. To me it looks like a bit of meaningless xml… :P I have a lot of new things to absorb, and it'll take me a bit of time getting up to speed on everything… ;-) Harbs On Apr 7, 2013, at 5:51 PM, Frédéric THOMAS wrote: > Those tests are pretty easy,

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
I think that's checking for input validity. The issue we're dealing with is when setting the value programtically. The relevant code in mx is this: setValue(isNaN(proposedValue) ? 0 : proposedValue, false); So it's changed to 0 before being passed to setValue. Harbs On Apr 7, 2013, at 5:45 P

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
Those tests are pretty easy, that's properties tests .\mustella\tests\components\NumericStepper\properties Just add a new one for both Mx and Spark. I guess it could be something like that: className="mx.controls.NumericStepper" waitEvent="updateComplete"/> value="-1" wa

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
Ok, perfect then, maybe I'm wrong, I was reading the mx:NumericStepper: private function checkValidValue(value:Number):Number { if (isNaN(value)) return this.value; But if you tried it, it's worth :) -Fred -Message d'origine- From: Harbs Sent: Sunday, April 07, 2013 4:37 PM

Re: [jira] [Assigned] (FLEX-33451) The release build due to the Git migration is broken

2013-04-07 Thread Erik de Bruin
+1 on all but "1" Making releases is not only about getting new stuff out there, it is also about attracting attention to the product. Maybe someone (Scott?) with some more "marketing" background can chime in and voice an opinion about the "optimal release frequency" or a maybe some variants we ca

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
Thanks. Good to know. On Apr 7, 2013, at 3:37 PM, Frédéric THOMAS wrote: > Btw, FYI, the good way to revert a commit which is not a merge commit is to > do 'git revert ' where was 53ad8aa in your case, the hash of the > commit to revert, it creates another commit strictly the opposite of the b

Re: [VOTE] Release InstallApacheFlex 2.5.4 - RC5

2013-04-07 Thread Alex Harui
+1 Source built and installed files that matched the 4.9.1 bin distro. Rat is clean. Signature match. Notice files look fine (really minor indentation issue in README) Thanks Frédéric and Justin! -Alex On 4/5/13 6:35 PM, "Frédéric THOMAS" wrote: > > *Issues addressed in this Release Candida

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
Sounds good to me, but I've never created a test case, so I have no idea what to do. Like I just responded, I believe they already are equivalent. On Apr 7, 2013, at 3:29 PM, Frédéric THOMAS wrote: > One more point, none of the Mustella tests for the Mx and the Spark > NumericStepper have the

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
I just used the test app with mx:NumericStepper, and it's reverted to 0 when setting it to NaN. So it looks like the behavior is now equivalent. Note. It's 0 not minimum, because minimum could be less than 0… On Apr 7, 2013, at 3:21 PM, Frédéric THOMAS wrote: > Ok, I just noticed the mx:Numeric

Re: git commit: FLEX-33477: Update ComboBox.as setSelectedIndex ASDOC comments to match that of the ListBase

2013-04-07 Thread Alex Harui
On 4/7/13 5:28 AM, "Mark Kessler" wrote: > Ok so lets see if this is where we agree. The changes I just made on the > ComboBox and ListBase should keep the old values since they are existing > features I only changed the public scope. However new features that only > started existing with Ap

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
Btw, FYI, the good way to revert a commit which is not a merge commit is to do 'git revert ' where was 53ad8aa in your case, the hash of the commit to revert, it creates another commit strictly the opposite of the bad one, you can then work on. -Fred -Message d'origine- From: Harbs

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
One more point, none of the Mustella tests for the Mx and the Spark NumericStepper have the use case of the NaN, it would be nice to add this case and make them consistent, what do you think ? -Fred -Message d'origine- From: Frédéric THOMAS Sent: Sunday, April 07, 2013 2:21 PM To: de

Re: git commit: FLEX-33477: Update ComboBox.as setSelectedIndex ASDOC comments to match that of the ListBase

2013-04-07 Thread Mark Kessler
Ok so lets see if this is where we agree. The changes I just made on the ComboBox and ListBase should keep the old values since they are existing features I only changed the public scope. However new features that only started existing with Apache Flex, such as the doubleClickMode; should have th

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
Ok, I just noticed the mx:NumericStepper commitProperties set it to 0 in case of NaN but it never happen because the checkValidValue reset it the old value in case of NaN, it means the Spart one and the Mx one are not consistent, the Mx one doesn’t allows the value to be set with NaN, is this t

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
Okay. Done. I'll set up Mustella when I get a chance… On Apr 7, 2013, at 2:28 PM, Frédéric THOMAS wrote: > Yeah, Range allows to incr/decr in changeValueByStep, so nearestValidValue is > the good place, I haven't seen before because the source code where FB took > me wasn't the good function,

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
Yeah, Range allows to incr/decr in changeValueByStep, so nearestValidValue is the good place, I haven't seen before because the source code where FB took me wasn't the good function, I have to fix that, that's a pain. -Fred -Message d'origine- From: Harbs Sent: Sunday, April 07, 2013

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
Okay. Thanks. I'll need to find the time to go through the wiki properly… On Apr 7, 2013, at 2:01 PM, Frédéric THOMAS wrote: > I personally do it on the same one, the wiki explains how to run tests, Om > did the tool called OneClickMustella to simplify your life. > > -Fred > > -Message d'o

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
Yes. nearestValidValue looks like a good place to fix it. The question is, should it be in Range, Spinner (what a funny name for a base class…) or NumericStepper? I'm thinking Range make the most sense because NaN is not a valid value… On Apr 7, 2013, at 2:08 PM, Frédéric THOMAS wrote: > Sorry

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
I'm not sure I see why you'd want a NaN value in Range, but I guess you are right that it's technically a legal value. Does range have a skin? I'm guessing not… On Apr 7, 2013, at 2:00 PM, Frédéric THOMAS wrote: > IMHO, it is more a Spinner thing as the Range doesn’t incr/decr values, so, > i

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
Sorry my bad, you are right, I was looking at another function, I don't use usually FB and it sent me elsewhere. well, nearestValidValue looks to be the place. -Fred -Message d'origine- From: Frédéric THOMAS Sent: Sunday, April 07, 2013 1:00 PM To: dev@flex.apache.org Subject: Re: gi

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
I personally do it on the same one, the wiki explains how to run tests, Om did the tool called OneClickMustella to simplify your life. -Fred -Message d'origine- From: Harbs Sent: Sunday, April 07, 2013 12:39 PM To: dev@flex.apache.org Subject: Re: git commit: Added override to set val

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
IMHO, it is more a Spinner thing as the Range doesn’t incr/decr values, so, it is valid to set it to a NaN value to say that's a meaningless value but the incr/decr have currently no code to manage that situation, that's the reason why I thing it could be the place to do it. What do you think

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
Okay. But I'll have to set up another machine to run Mustella on, and I'll probably need some hand-holding on it… On Apr 7, 2013, at 12:53 PM, Frédéric THOMAS wrote: > And sorry again but now you are committer, I guess it is your duty to run the > Mustella tests to ensure the fix doesn't break

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
If 0 is out of range, 0 will be converted to minimum automatically. But you are probably right. I see no reason to not set it straight to minimium. It should probably also be fixed in Range set value(). Any reason you can think of why it should not be fixed there? If you agree, I'll revert Nume

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
And sorry again but now you are committer, I guess it is your duty to run the Mustella tests to ensure the fix doesn't break them (or eventually you'll need to adapt the tests too). -Fred -Message d'origine- From: Frédéric THOMAS Sent: Sunday, April 07, 2013 11:46 AM To: dev@flex.apa

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
And maybe it can be fixed directly in the Sinner at override public function changeValueByStep(increase:Boolean = true):void -Fred -Message d'origine- From: Frédéric THOMAS Sent: Sunday, April 07, 2013 11:43 AM To: dev@flex.apache.org Subject: Re: git commit: Added override to set val

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
Hi Harbs, I guess you will have the opportunity to do it again. What if 0 is out of the Range ? I guess the right fix is: if(isNaN(newValue)) newValue = minimum; -Fred -Message d'origine- From: Harbs Sent: Sunday, April 07, 2013 11:38 AM To: dev@flex.apache.org Subject: Re: git

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Harbs
I thought it was automatically prepended because I created a branch for it. I see that when I deleted the branch, the JIRA number disappeared. Still learning git… ;-) FWIW, it was FLEX-33288 Harbs On Apr 7, 2013, at 11:57 AM, Frédéric THOMAS wrote: > Take the habit to prepend the issue id to

Re: git commit: Added override to set value to ensure it is not set to NaN

2013-04-07 Thread Frédéric THOMAS
Take the habit to prepend the issue id to your commit message, it is useful if someone wants to see the modified code from the source tab of the Jira issue. -Fred -Message d'origine- From: ha...@apache.org Sent: Sunday, April 07, 2013 9:02 AM To: comm...@flex.apache.org Subject: git co

[jira] [Resolved] (FLEX-33288) Numeric Stepper value once NaN does not change to any number user sets or increments

2013-04-07 Thread Harbs (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-33288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harbs resolved FLEX-33288. -- Resolution: Fixed I added an override to set value() to convert all NaN values to 0 as per Carol's suggestion

[jira] [Assigned] (FLEX-33288) Numeric Stepper value once NaN does not change to any number user sets or increments

2013-04-07 Thread Harbs (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-33288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harbs reassigned FLEX-33288: Assignee: Harbs > Numeric Stepper value once NaN does not change to any number user sets or > incremen