Re: [Discuss] deprecating and eventually removing non-sql compatible configs

2024-12-16 Thread Clint Wylie
https://github.com/apache/druid/issues/17575 is the issue for tracking all the removal tasks, will link the PRs as they are created On Mon, Dec 16, 2024 at 2:32 PM Gian Merlino wrote: > > Thanks Clint. I'm looking forward to the code and testing matrix being > simplified! > > I do want to note th

Re: [Discuss] deprecating and eventually removing non-sql compatible configs

2024-12-16 Thread Gian Merlino
Thanks Clint. I'm looking forward to the code and testing matrix being simplified! I do want to note that in addition to the defaults being SQL compatible since Druid 28, the docs also list the legacy mode as deprecated. So the timing makes sense for removal in Druid 32. Gian On Mon, Dec 16, 202

Re: [Discuss] deprecating and eventually removing non-sql compatible configs

2024-12-16 Thread Clint Wylie
I plan to move forward with removal of these configs starting soon and will create a github issue to track everything. This will make Druid 32 the version where the removal will be completed, I'll make sure we have a migration guide in place for the release notes and docs as part of this work. On

Re: [Discuss] deprecating and eventually removing non-sql compatible configs

2024-02-01 Thread Abhishek Agarwal
@clint - Those configs are already in SQL compatible mode by default since 28. Aren't they? To the original question, I am ok to deprecate these configs given that we have enough releases for folks to migrate over their queries. On Fri, Jan 26, 2024 at 4:55 AM Clint Wylie wrote: > >Are there an

Re: [Discuss] deprecating and eventually removing non-sql compatible configs

2024-01-25 Thread Clint Wylie
>Are there any performance implications in making those the defaults? For numeric columns without null values there should be no impact. For numeric columns with null values, I believe there is currently a very minor performance impact for scans/aggregations since the null value bitmap is iterated

Re: [Discuss] deprecating and eventually removing non-sql compatible configs

2024-01-22 Thread Xavier Léauté
Two questions: - Are there any performance implications in making those the defaults? - Would this break compatibility for any existing native queries? On Wed, Jan 17, 2024 at 5:53 PM Clint Wylie wrote: > Hi all, > > I wanted to discuss the deprecation and removal of the Druid configs > related

[Discuss] deprecating and eventually removing non-sql compatible configs

2024-01-17 Thread Clint Wylie
Hi all, I wanted to discuss the deprecation and removal of the Druid configs related to SQL compatibility, with the eventual goal of always running in SQL compatible mode. As of Druid 28, these are the default, but in the interest of dramatically reducing complexity and removing a ton of code, and