[dpdk-dev] [PATCH] stats: remove useless memset's

2015-01-20 Thread step...@networkplumber.org
From: Stephen Hemminger The rte_eth_stats_get is the only API that should call the device statistics function directly, and it already does a memset of the resulting structure. Therefore doing memset() in the driver is redundant and should be removed. Signed-off-by: Stephen Hemminger --- lib/l

[dpdk-dev] [PATCH] mk: allow application to override clean

2015-01-22 Thread step...@networkplumber.org
From: Stephen Hemminger In some cases application may want to have additional rules for clean. This can be handled by allowing the double colon form of rule. https://www.gnu.org/software/make/manual/html_node/Double_002dColon.html Single colon and double colon rules for same target causes an e

[dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count

2015-01-22 Thread step...@networkplumber.org
From: Stephen Hemminger The ixgbe driver was including CRC in the transmit packet byte count, but not for packets received. This was notice when forwarding and the number of bytes received was greater than the number of bytes transmitted for the same number of packets. Make the driver behave like

[dpdk-dev] [PATCH v3 0/8] vmxnet3: driver updates

2015-07-09 Thread step...@networkplumber.org
From: Stephen Hemminger These are update to earlier vmxnet3 driver changes. Mostly rebasing to current layout. I skipped the jumbo MTU stuff which works for me but reviewers seem to see problems with. Stephen Hemminger (8): vmxnet3: enable VLAN filtering vmxnet3: remove mtu check vmxnet3:

[dpdk-dev] [PATCH 1/8] vmxnet3: enable VLAN filtering

2015-07-09 Thread step...@networkplumber.org
From: Stephen Hemminger Support the VLAN filter functionality of the VMXNET3 interface. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 105 --- drivers/net/vmxnet3/vmxnet3_ethdev.h | 3 +- drivers/net/vmxnet3/vmxnet3_rxtx.c | 31

[dpdk-dev] [PATCH 2/8] vmxnet3: remove mtu check

2015-07-09 Thread step...@networkplumber.org
From: Stephen Hemminger Remove check for packets greater than MTU. No other driver does this, it should be handled at higher layer Signed-off-by: Stephen Hemminger Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 -- drivers/net/vmxnet3/vmxnet3_ethdev.h | 1 - drivers/net/vm

[dpdk-dev] [PATCH 3/8] vmxnet3: cleanup txq stats

2015-07-09 Thread step...@networkplumber.org
From: Stephen Hemminger There are several stats here which are never set, and have no way to be displayed. Assume in future xstats could be used. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ring.h | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) di

[dpdk-dev] [PATCH 4/8] vmxnet3: add support for multi-segment transmit

2015-07-09 Thread step...@networkplumber.org
From: Stephen Hemminger Change sending loop to support multi-segment mbufs. The VMXNET3 api has start-of-packet and end-packet flags, so it is not hard to send multi-segment mbuf's. Also, update descriptor in 32 bit value rather than toggling bitfields which is slower and error prone. Based on c

[dpdk-dev] [PATCH 5/8] vmxnet3: fix link state handling

2015-07-09 Thread step...@networkplumber.org
From: Stephen Hemminger The Intel version of VMXNET3 driver does not handle link state properly. The VMXNET3 API returns 1 if connected and 0 if disconnected. Also need to return correct value to indicate state change. Signed-off-by: Stephen Hemminger Acked-by: Yong Wang --- drivers/net/vmxne

[dpdk-dev] [PATCH 6/8] vmxnet3: support RSS and refactor offload

2015-07-09 Thread step...@networkplumber.org
From: Stephen Hemminger Refactor the logic to compute receive offload flags to a simpler function. And add support for putting RSS flow hash into packet. Signed-off-by: Stephen Hemminger Signed-off-by: Bill Hong --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 69 ++---

[dpdk-dev] [PATCH 7/8] vmxnet3: get rid of DEBUG ifdefs

2015-07-09 Thread step...@networkplumber.org
From: Stephen Hemminger By defining macro as a stub it is possible to get rid of #ifdef's in the actual code. Always evaluate the argument (even in the stub) so that there are no extra unused variable errors. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.h | 6 --

[dpdk-dev] [PATCH 8/8] vmxnet3: remove unnecessary inlining

2015-07-09 Thread step...@networkplumber.org
From: Stephen Hemminger No reason to inline large functions. Compiler will decide already based on optimization level. Also register array should be const. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions