Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR),
worker thread should not try to fetch crypto op, which would lead to
memory fault.
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrish
vc_req->dev = vcrypto->dev;
vc_req->vq = vq;
Thanks,
Gowrishankar
.
Hence, it would break parsing vhost_user messages.
This patch addresses both of the above problems.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
lib/vhost/vhost_crypto.c | 12 ++--
lib/vhost/vhost_user.h | 33 +
2 files changed, 35
This patch series supports asymmetric RSA in vhost crypto library.
It also includes changes to improve vhost crypto library:
* support newer QEMU versions.
* fix broken vhost_crypto example application.
* stabilize crypto fastpath operations.
Gowrishankar Muthukrishnan (5):
vhost: skip
In order to handle new vhost user connection, use new_connection
and destroy_connection callbacks.
Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
examples/vhost_crypto/
In order to handle new vhost user connection, use new_connection
and destroy_connection callbacks.
Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
examples/vhost_crypto/
not recognise this inherited lock and
stops compilation. This patch explicitly uses vhost_virtqueue
where ever required and fulfills thread safety checks.
Signed-off-by: Gowrishankar Muthukrishnan
---
lib/vhost/vhost_crypto.c | 76 ++--
1 file changed, 41 inserti
Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR),
worker thread should not try to fetch crypto op, which would lead to
memory fault.
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrish
.
Hence, it would break parsing vhost_user messages.
This patch addresses both of the above problems.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
lib/vhost/vhost_crypto.c | 12 ++--
lib/vhost/vhost_user.h | 33 +
2 files changed, 35
This patch series supports asymmetric RSA in vhost crypto library.
It also includes changes to improve vhost crypto library:
* support newer QEMU versions.
* fix broken vhost_crypto example application.
* stabilize crypto fastpath operations.
v9:
- new patch 1/6
Gowrishankar Muthukrishnan (6
Support asymmetric RSA crypto operations in vhost-user.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
doc/guides/rel_notes/release_25_03.rst | 3 +
lib/vhost/vhost_crypto.c | 484 +++--
lib/vhost/virtio_crypto.h | 67
Support asymmetric crypto operations.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
doc/guides/sample_app_ug/vhost_crypto.rst | 5 +++
examples/vhost_crypto/main.c | 50 +--
2 files changed, 43 insertions(+), 12 deletions(-)
diff --git a
any other changes are required, we can assist going forward. We also
believe
this software backend needs to be reliable and hence can help test required
virtio
functionalities.
Thanks,
Gowrishankar
Regards,
Gowrishankar
> Maxime
x27;t see little point
> in having
> in the first place..) and adjust annotations.
>
Yes I thought about it initially, but then I had thought
vhost_crypto_process_one_req() is only static and called with locks held.
Anyway, I have come up with one additional patch in series to fix it
specifically.
Thanks for your suggestion.
Regards,
Gowrishankar
>
> --
> David Marchand
>
> Fixes: d1b484bf1876 ("vhost/crypto: support asymmetric RSA")
>
> Signed-off-by: David Marchand
Tested-by: Gowrishankar Muthukrishnan
t; Fixes: 88c73b5434e6 ("vhost/crypto: fix thread safety check")
>
> Signed-off-by: David Marchand
Tested-by: Gowrishankar Muthukrishnan
Thanks,
Gowrishankar
Return correct error status when incorrect signature is
used in RSA verify op.
Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/openssl/rte_openssl_pmd.c | 3 +++
1 file
Return error code in an asymmetric operation status
when none of the known conditions met.
Fixes: d29c4e0a4bea ("crypto/cnxk: fix ECDH public key verification")
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 2 ++
1 file changed, 2 insertion
From: Akhil Goyal
Add RSA support in crypto-perf application.
Signed-off-by: Akhil Goyal
---
app/test-crypto-perf/cperf_ops.c | 68
app/test-crypto-perf/cperf_options.h | 4 +
app/test-crypto-perf/cperf_options_parsing.c | 38 +++-
app/test-crypto-perf/cperf_te
Add negative test for RSA verify operation to check if incorrect
signature is validated.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c b
Asymmetric RSA operations (SIGN, VERIFY, ENCRYPT and DECRYPT) are
supported in virtio PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
Depends-on: series-34674 ("vhost: add RSA support")
v3:
- fast path optimizations.
---
.../virtio/virtio_crypto_capabilities.h | 19 +
driv
This patch series enhances virtio crypto PMD to:
* support RSA
* support packed virtio ring
* support vDPA backend
v3:
- vDPA backend code majorly sourced from virtio net.
Gowrishankar Muthukrishnan (6):
crypto/virtio: add asymmetric RSA support
crypto/virtio: refactor queue operations
Add vDPA backend to virtio_user crypto.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/virtio/meson.build | 7 +
drivers/crypto/virtio/virtio_cryptodev.c | 57 +-
drivers/crypto/virtio/virtio_cryptodev.h | 3 +
drivers/crypto/virtio/virtio_logs.h
Move existing control queue operations into a common place
that would be shared with other virtio type of devices.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/virtio/meson.build | 1 +
drivers/crypto/virtio/virtio_crypto_algs.h | 2 +-
drivers/crypto/virtio
Reuse virtio_crypto tests for testing virtio_crypto_user PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev.c | 7 +++
app/test/test_cryptodev.h | 1 +
app/test/test_cryptodev_asym.c | 15 +++
3 files changed, 23 insertions(+)
diff --git a
Add asymmetric tests for Virtio PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 28
1 file changed, 28 insertions(+)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 9b5f3c545e..ac47be724f 100644
Support asymmetric RSA crypto operations in vhost-user.
Signed-off-by: Gowrishankar Muthukrishnan
---
v3:
- TLV decode optimization for fast path.
- virtio_crypto.h changes moved from virtio PMD patch series into this series
as asymmetric support starts essentially from library.
---
lib
Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR),
worker thread should not try to fetch crypto op, which would lead to
memory fault.
Fixes: 939066d9656 ("vhost/crypto: add public function implementation")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Mut
Support asymmetric crypto operations.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/vhost_crypto/main.c | 50 +++-
1 file changed, 38 insertions(+), 12 deletions(-)
diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
index
In order to handle new vhost user connection, use new_connection
and destroy_connection callbacks.
Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
v3:
- decoupled from v2 single patch.
---
in v2.
- stabilized vhost crypto lib and example app.
Gowrishankar Muthukrishnan (5):
vhost: skip crypto op fetch before vring init
vhost: update vhost_user crypto session parameters
examples/vhost_crypto: fix user callbacks
vhost: support asymmetric RSA crypto ops
examples/vhost_crypto
parsing
vhost_user message.
This patch addresses both of the above problems.
Signed-off-by: Gowrishankar Muthukrishnan
---
v3:
- decoupled originally from v2 series single patch.
---
lib/vhost/vhost_crypto.c | 12 ++--
lib/vhost/vhost_user.h | 33 +
2
Return correct error status when incorrect signature is
used in RSA verify op.
Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
v2:
- added comments.
---
drivers/crypto/openssl/rte_openssl_
Add packed ring support.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/virtio/virtio_cryptodev.c | 125 +++
drivers/crypto/virtio/virtio_cryptodev.h | 13 +-
drivers/crypto/virtio/virtio_cvq.c | 103 +-
drivers/crypto/virtio/virtio_pci.h | 25 ++
drivers
Add packed ring support.
Signed-off-by: Gowrishankar Muthukrishnan
---
Depends-on: series-34682 ("vhost: add RSA support")
---
drivers/crypto/virtio/virtio_cryptodev.c | 125 +++
drivers/crypto/virtio/virtio_cryptodev.h | 13 +-
drivers/crypto/virtio/virtio_cvq.c
Asymmetric RSA operations (SIGN, VERIFY, ENCRYPT and DECRYPT) are
supported in virtio PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
Depends-on: series-34682 ("vhost: add RSA support")
---
.../virtio/virtio_crypto_capabilities.h | 19 +
drivers/crypto/virtio/virtio_c
This patch series enhances virtio crypto PMD to:
* support RSA
* support packed virtio ring
* support vDPA backend
v4:
- CI issue fixed.
Depends-on: series-34682 ("vhost: add RSA support")
Gowrishankar Muthukrishnan (6):
crypto/virtio: add asymmetric RSA support
crypto/virtio
parsing
vhost_user message.
This patch addresses both of the above problems.
Signed-off-by: Gowrishankar Muthukrishnan
---
lib/vhost/vhost_crypto.c | 12 ++--
lib/vhost/vhost_user.h | 33 +
2 files changed, 35 insertions(+), 10 deletions(-)
diff --git a/lib
Reuse virtio_crypto tests for testing virtio_crypto_user PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev.c | 7 +++
app/test/test_cryptodev.h | 1 +
app/test/test_cryptodev_asym.c | 15 +++
3 files changed, 23 insertions(+)
diff --git a
Support asymmetric crypto operations.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/vhost_crypto/main.c | 50 +++-
1 file changed, 38 insertions(+), 12 deletions(-)
diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
index
Add vDPA backend to virtio_user crypto.
Signed-off-by: Gowrishankar Muthukrishnan
---
Depends-on: series-34682 ("vhost: add RSA support")
v4:
- fixed CI issue.
---
drivers/crypto/virtio/meson.build | 7 +
drivers/crypto/virtio/virtio_cryptodev.c | 57 +-
driv
Add asymmetric tests for Virtio PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 28
1 file changed, 28 insertions(+)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 9b5f3c545e..ac47be724f 100644
Move existing control queue operations into a common place
that would be shared with other virtio type of devices.
Signed-off-by: Gowrishankar Muthukrishnan
---
Depends-on: series-34682 ("vhost: add RSA support")
---
drivers/crypto/virtio/meson.build | 1 +
drivers/cry
This patch series supports asymmetric RSA in vhost crypto library.
It also includes changes to improve vhost crypto library:
* support newer QEMU versions.
* fix broken vhost_crypto example application.
* stabilize crypto fastpath operations.
v4:
- fixed CI issues.
Gowrishankar Muthukrishnan
Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR),
worker thread should not try to fetch crypto op, which would lead to
memory fault.
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Mut
Support asymmetric RSA crypto operations in vhost-user.
Signed-off-by: Gowrishankar Muthukrishnan
---
v4:
- fixed CI issue.
---
lib/vhost/vhost_crypto.c | 486 +++---
lib/vhost/virtio_crypto.h | 67 ++
2 files changed, 518 insertions(+), 35 deletions
In order to handle new vhost user connection, use new_connection
and destroy_connection callbacks.
Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/vhost_crypto/main.c | 4 ++--
1 file
This patch series supports asymmetric RSA in vhost crypto library.
It also includes changes to improve vhost crypto library:
* support newer QEMU versions.
* fix broken vhost_crypto example application.
* stabilize crypto fastpath operations.
v5:
- added docs.
Gowrishankar Muthukrishnan (5
Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR),
worker thread should not try to fetch crypto op, which would lead to
memory fault.
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrish
.
Hence, it would break parsing vhost_user messages.
This patch addresses both of the above problems.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
v5:
- updated patch description for QEMU version.
---
lib/vhost/vhost_crypto.c | 12 ++--
lib/vhost/vhost_user.h | 33
In order to handle new vhost user connection, use new_connection
and destroy_connection callbacks.
Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
examples/vhost_crypto/
Support asymmetric RSA crypto operations in vhost-user.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
v5:
- release notes
---
doc/guides/rel_notes/release_25_03.rst | 3 +
lib/vhost/vhost_crypto.c | 486 +++--
lib/vhost/virtio_crypto.h
Support asymmetric crypto operations.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
v5:
- doc update
---
doc/guides/sample_app_ug/vhost_crypto.rst | 5 +++
examples/vhost_crypto/main.c | 50 +--
2 files changed, 43 insertions(+), 12
Return correct error status when incorrect signature is
used in RSA verify op.
Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
v2:
- clubbed with test patch
---
drivers/cryp
Add negative test for RSA verify operation to check if incorrect
signature is validated.
Signed-off-by: Gowrishankar Muthukrishnan
---
v2:
- no changes, but added openssl pmd patch for CI.
---
app/test/test_cryptodev_asym.c | 27 +--
1 file changed, 25 insertions(+), 2
>
Ack. Except for vq->enabled, next version of this patch would carry these
checks.
Current virtio crypto for vhost_user does not request SET_VRING_ENABLE, so this
flag would not be set.
Thanks,
Gowrishankar
> You can have a look at rte_vhost_dequeue_burst for example.
>
> > avail_idx = *((volatile uint16_t *)&vq->avail->idx);
> > start_idx = vq->last_used_idx;
> > count = avail_idx - start_idx;
Support asymmetric RSA crypto operations in vhost-user.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
doc/guides/rel_notes/release_25_03.rst | 3 +
lib/vhost/vhost_crypto.c | 486 +++--
lib/vhost/virtio_crypto.h | 67
Support asymmetric crypto operations.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
doc/guides/sample_app_ug/vhost_crypto.rst | 5 +++
examples/vhost_crypto/main.c | 50 +--
2 files changed, 43 insertions(+), 12 deletions(-)
diff --git a
Add vDPA backend to virtio_user crypto.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/virtio/meson.build | 7 +
drivers/crypto/virtio/virtio_cryptodev.c | 57 +-
drivers/crypto/virtio/virtio_cryptodev.h | 3 +
drivers/crypto/virtio/virtio_logs.h
Reuse virtio_crypto tests for testing virtio_crypto_user PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev.c | 7 +++
app/test/test_cryptodev.h | 1 +
app/test/test_cryptodev_asym.c | 15 +++
3 files changed, 23 insertions(+)
diff --git a
Add asymmetric tests for Virtio PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 28
1 file changed, 28 insertions(+)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 9b5f3c545e..ac47be724f 100644
Move existing control queue operations into a common place
that would be shared with other virtio type of devices.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/virtio/meson.build | 1 +
drivers/crypto/virtio/virtio_crypto_algs.h | 2 +-
drivers/crypto/virtio
.
Hence, it would break parsing vhost_user messages.
This patch addresses both of the above problems.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
lib/vhost/vhost_crypto.c | 12 ++--
lib/vhost/vhost_user.h | 33 +
2 files changed, 35
Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR),
worker thread should not try to fetch crypto op, which would lead to
memory fault.
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrish
In order to handle new vhost user connection, use new_connection
and destroy_connection callbacks.
Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
examples/vhost_crypto/
This patch series supports asymmetric RSA in vhost crypto library.
It also includes changes to improve vhost crypto library:
* support newer QEMU versions.
* fix broken vhost_crypto example application.
* stabilize crypto fastpath operations.
Gowrishankar Muthukrishnan (5):
vhost: skip
This patch series enhances virtio crypto PMD to:
* support RSA
* support packed virtio ring
* support vDPA backend
Depends-on: patch-152109 ("vhost: support asymmetric RSA crypto ops")
Gowrishankar Muthukrishnan (6):
crypto/virtio: add asymmetric RSA support
crypto/virtio: refa
Asymmetric RSA operations (SIGN, VERIFY, ENCRYPT and DECRYPT) are
supported in virtio PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
Depends-on: patch-152109 ("vhost: support asymmetric RSA crypto ops")
v5:
- fixed asym enqueue xmit func for correct head idx.
- release not
Add packed ring support.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/virtio/virtio_cryptodev.c | 125 +++
drivers/crypto/virtio/virtio_cryptodev.h | 13 +-
drivers/crypto/virtio/virtio_cvq.c | 103 +-
drivers/crypto/virtio/virtio_pci.h | 25 ++
drivers
eq() once implemented.
>
Ack.
Thanks,
Gowrishankar.
Support asymmetric RSA crypto operations in vhost-user.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
doc/guides/rel_notes/release_25_03.rst | 3 +
lib/vhost/vhost_crypto.c | 486 +++--
lib/vhost/virtio_crypto.h | 67
This patch series supports asymmetric RSA in vhost crypto library.
It also includes changes to improve vhost crypto library:
* support newer QEMU versions.
* fix broken vhost_crypto example application.
* stabilize crypto fastpath operations.
Gowrishankar Muthukrishnan (5):
vhost: skip
Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR),
worker thread should not try to fetch crypto op, which would lead to
memory fault.
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrish
Support asymmetric crypto operations.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
doc/guides/sample_app_ug/vhost_crypto.rst | 5 +++
examples/vhost_crypto/main.c | 50 +--
2 files changed, 43 insertions(+), 12 deletions(-)
diff --git a
.
Hence, it would break parsing vhost_user messages.
This patch addresses both of the above problems.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
lib/vhost/vhost_crypto.c | 12 ++--
lib/vhost/vhost_user.h | 33 +
2 files changed, 35
In order to handle new vhost user connection, use new_connection
and destroy_connection callbacks.
Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Akhil Goyal
---
examples/vhost_crypto/
This patch fixes incorrect return value when RSA negative
test scenario is validated.
Coverity-issue: 457463
Fixes: 9682e8246ae ("test/crypto: add negative case for RSA verification")
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 1 +
1 file
As per RFC 8017, RSA public key in ASN.1 should have only
modulus and exponent values. Add a separate encoding function
to follow this standard.
Fixes: 6fe6a7f7bcf ("crypto/virtio: add asymmetric RSA support")
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/cry
As per RFC 8017, RSA parameter needs to be positive integer.
This patch fixes TLV encoding function appropriately.
Fixes: 6fe6a7f7bcf ("crypto/virtio: add asymmetric RSA support")
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/virtio/virtio_crypto
.
Fixes: 5ae36995f10 ("test/crypto: move RSA enqueue/dequeue into functions")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/app/test/test_cryptodev_as
Increment dequeue timeout to allow implementations taking
longer cycles.
Signed-off-by: Gowrishankar Muthukrishnan
---
v2:
- no changes. only for CI.
---
app/test/test_cryptodev_asym.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_cryptodev_asym.c b/app/test
Recheck unit test failure for openssl 1.1.1 in some distros.
Recheck-request: iol-unit-amd64-testing
--
Gowrishankar
>
> Following RSA encrypt op, same plaintext buffer is used as output buffer for
> decrypt op, hence comparing plaintext buffer against same buffer pointer in
> cryp
Add test vectors for ECDH groups 19, 20 and 21.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 39 ++-
app/test/test_cryptodev_ecdh_test_vectors.h | 344 +++
app/test/test_cryptodev_ecdsa_test_vectors.h | 6 +
3 files changed
This change fixes coverity issue on overflowed constant.
Bad phys address should be checked before using it in
descriptor.
Coverity issue: 457462, 457465
Fixes: 10702138f1a ("crypto/virtio: support asymmetric RSA")
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/cry
This change fixes an uninitialized local variable as reported
in coverity issue 445390.
Coverity-issue: 445390
Fixes: a8ebe94f8cc ("crypto/cnxk: support EdDSA")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/cnxk/cnxk_ae.h | 2 +-
1 file changed, 1
This patch fixes incorrect return value when RSA negative
test scenario is validated.
Coverity-issue: 457463
Fixes: 9682e8246ae ("test/crypto: add negative case for RSA verification")
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 1 +
1 file
Fix uninitialized variable as reported in coverity scan.
Coverity-issue: 457449
Fixes: d1b484bf187 ("vhost/crypto: support asymmetric RSA")
Signed-off-by: Gowrishankar Muthukrishnan
---
lib/vhost/vhost_crypto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Fix coverity issue on out-of-bounds access.
Coverity-issue: 403166, 403171, 403172
Fixes: 5686b573e4b ("crypto/cnxk: support SM2")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/cnxk/cnxk_ae.h | 9 +
1 file changed, 9 insertions(+)
di
Dispatcher unit test failed which is unrelated to this patch and looks like
infrastructure issue.
Recheck-request: loongarch-unit-testing
--
Gowrishankar
> This change fixes an uninitialized local variable as reported in coverity
> issue
> 445390.
>
> Coverity-issue:
Hi Kai Ji,
>
> Hi Gowrishankar,
>
> Thanks for reach out, I don't have those environments setup on my end, but
> Ubuntu 20.04 and RHEL8 are old but still common LTS packages.
> Are you able to dump the actual msg buffer ?
>
RSA_private_decrypt fails and return co
() would additionally need
private exponent
rsa->d, assuming that d is already part of RSA session, to derive kdk used in
implicit rejection.
We did not have it in CRT test vectors today. I'll send patch to fix these.
Thanks,
Gowrishankar
>
> Hi Kai Ji,
> >
> > Hi Gowris
.
Fixes: 5ae36995f10f ("test/crypto: move RSA enqueue/dequeue into functions")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/app/test/test_cryptodev_as
enssl: add RSA and mod asym operations")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
b/drivers/cryp
As per RFC 8017 (A.1.2), RSA private key should be represented
with both exponent and CRT forms of data for inter operability.
Fixes: a379799cbaaf ("test/crypto: add RSA key type CRT")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_crypto
, for openssl PMD ?
If required, I can start filing a Bugzilla as well.
Thanks,
Gowrishankar
>
> Following RSA encrypt op, same plaintext buffer is used as output buffer for
> decrypt op, hence comparing plaintext buffer against same buffer pointer in
> crypto op always succeed irresp
801 - 895 of 895 matches
Mail list logo
