[dpdk-dev] [PATCH v5 4/8] table: enable table library for ppc64le

2016-08-16 Thread gowrishankar muthukrishnan
in v6. After this patch, a ltable lib unit test fail as in Intel case currently and it is not related to powerpc changes. If some one already looking into broken unit test failure for table lib, that is helpful. Regards, Gowrishankar On Tuesday 16 August 2016 01:26 PM, Chao Zhu wrote

RE: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-10-08 Thread Gowrishankar Muthukrishnan
sage > (TLS and IKEv2 forbids PH though), But from RFC8032, it looks like it was > defined to be used per protocol basis, or some subprotocol routine. But about > this I am not sure. > > Yet, EdDSA should not be delayed really; it is basically a network standard > for > quite a time. > These changes may be discussed later. > Sure Arkadiusz. Regards, Gowrishankar

RE: [PATCH v2] cryptodev: add asymmetric operational capability

2024-10-08 Thread Gowrishankar Muthukrishnan
_ASYM_OP_SIGN] = (1 << RTE_CRYPTO_SM2_RNG) | > > + (1 << RTE_CRYPTO_SM2_PH), > > + > [RTE_CRYPTO_ASYM_OP_VERIFY] = (1 << RTE_CRYPTO_SM2_RNG) | > > + (1 << RTE_CRYPTO_SM2_PH) > > + }, > > + }, > > } > Ack. > Probably driver/test changes should be in different patches. > Ack. Regards, Gowrishankar

RE: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-10-08 Thread Gowrishankar Muthukrishnan
> Acked-by: Arkadiusz Kusztal > Hi Gowrishankar, > > > > I like the idea of adding EdDSA, but I have several comments. > > > > > +/** > > > + * EdDSA operation params > > > + */ > > > +struct rte_crypto_eddsa_op_param { > >

[PATCH v3 1/3] cryptodev: add asymmetric operational capability

2024-10-09 Thread Gowrishankar Muthukrishnan
Asymmetric crypto algorithms such as SM2, EdDSA would need per op capability and based on it, the input param to a crypto operation is chosen wisely. Signed-off-by: Gowrishankar Muthukrishnan --- v3: - Removed unused rte_crypto_sm2_op_capa enum value RTE_CRYPTO_SM2_PKE_KDF. HW that needs it

[PATCH v3 2/3] test/crypto: check op capabilities in SM2 tests

2024-10-09 Thread Gowrishankar Muthukrishnan
Check crypto op capabilities (prehash and RNG support) in SM2 tests. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test

[PATCH v3 3/3] crypto/openssl: include op capabilities for SM2

2024-10-09 Thread Gowrishankar Muthukrishnan
Include capabilities for SM2 operations. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl

[PATCH v5 3/6] crypto/cnxk: support EDDSA

2024-10-03 Thread Gowrishankar Muthukrishnan
Support EDDSA crypto algorithm in CNXK PMD. Signed-off-by: Gowrishankar Muthukrishnan --- v5: - long line fixed. --- doc/guides/cryptodevs/features/cn10k.ini | 1 + drivers/common/cnxk/hw/cpt.h | 3 +- drivers/common/cnxk/roc_ae.c | 52 +- drivers

[PATCH v5 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-10-03 Thread Gowrishankar Muthukrishnan
Add support for asymmetric EDDSA in cryptodev, as referenced in RFC: https://datatracker.ietf.org/doc/html/rfc8032 Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/default.ini | 1 + doc/guides/prog_guide/cryptodev_lib.rst| 2 +- lib/cryptodev/rte_crypto_asym.h

[PATCH v5 4/6] test/crypto: add asymmetric EDDSA test cases

2024-10-03 Thread Gowrishankar Muthukrishnan
Add test cases to validate EDDSA sign and verify ops, as per RFC 8032. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 345 +++- app/test/test_cryptodev_ecdh_test_vectors.h | 94 +++- app/test/test_cryptodev_ecdsa_test_vectors.h | 4

[PATCH v5 5/6] examples/fips_validation: support EDDSA

2024-10-03 Thread Gowrishankar Muthukrishnan
Add EDDSA support in fips_validation app. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c| 2 + examples/fips_validation/fips_validation.h| 23 ++ .../fips_validation/fips_validation_eddsa.c | 307 + examples/fips_validation

[PATCH v5 2/6] crypto/openssl: support EDDSA

2024-10-03 Thread Gowrishankar Muthukrishnan
Support EDDSA crypto algorithm in OpenSSL PMD. Signed-off-by: Gowrishankar Muthukrishnan --- v5: - fixed compilation error due to RTE_LOG_CHECK_NO_NEWLINE. --- doc/guides/cryptodevs/features/openssl.ini | 1 + drivers/crypto/openssl/openssl_pmd_private.h | 13 ++ drivers/crypto/openssl

[PATCH v5 6/6] app/crypto-perf: support EDDSA

2024-10-03 Thread Gowrishankar Muthukrishnan
Added support for EDDSA 25519 curve SIGN and VERIFY operations. Signed-off-by: Gowrishankar Muthukrishnan --- app/test-crypto-perf/cperf_ops.c | 52 app/test-crypto-perf/cperf_options.h | 2 + app/test-crypto-perf/cperf_options_parsing.c | 9 +++- app

[PATCH v2 2/2] cryptodev: move RSA padding information into xform

2024-10-03 Thread Gowrishankar Muthukrishnan
creation. Hence, moving this info from crypto op into xform structure. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 10 ++-- app/test/test_cryptodev_rsa_test_vectors.h | 2 + drivers/common/cpt/cpt_ucode_asym.h | 4 +- drivers/crypto/cnxk

[PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax

2024-10-03 Thread Gowrishankar Muthukrishnan
VirtIO to benefit from the xform as per ASN.1 syntax. Signed-off-by: Gowrishankar Muthukrishnan --- lib/cryptodev/rte_crypto_asym.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h index 39d3da3952..c33be3b155

[PATCH v2 0/2] cryptodev: fix RSA xform to support VirtIO standard

2024-10-03 Thread Gowrishankar Muthukrishnan
In this series of patches, RSA crypto xform is fixed to support VirtIO standard. Changes: v2: - Decoupled spec related patches into this series from v1. Gowrishankar Muthukrishnan (2): cryptodev: fix RSA xform for ASN.1 syntax cryptodev: move RSA padding information into xform app/test

[PATCH v2] cryptodev: add asymmetric operational capability

2024-10-04 Thread Gowrishankar Muthukrishnan
Asymmetric crypto algorithms such as SM2, EdDSA would need per op capability and based on it, the input param to a crypto operation is chosen wisely. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - op_capa is array of int instead of structure. - compilation issues addressed. --- app/test

[PATCH v6 3/6] crypto/cnxk: support EDDSA

2024-10-04 Thread Gowrishankar Muthukrishnan
Support EDDSA crypto algorithm in CNXK PMD. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/cn10k.ini | 1 + drivers/common/cnxk/hw/cpt.h | 3 +- drivers/common/cnxk/roc_ae.c | 52 +- drivers/common/cnxk/roc_ae.h

[PATCH v6 4/6] test/crypto: add asymmetric EDDSA test cases

2024-10-04 Thread Gowrishankar Muthukrishnan
Add test cases to validate EDDSA sign and verify ops, as per RFC 8032. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 345 +++- app/test/test_cryptodev_ecdh_test_vectors.h | 94 +++- app/test/test_cryptodev_ecdsa_test_vectors.h | 4

[PATCH v6 2/6] crypto/openssl: support EDDSA

2024-10-04 Thread Gowrishankar Muthukrishnan
Support EDDSA crypto algorithm in OpenSSL PMD. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/openssl.ini | 1 + drivers/crypto/openssl/openssl_pmd_private.h | 13 ++ drivers/crypto/openssl/rte_openssl_pmd.c | 223 +++ drivers/crypto

[PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-10-04 Thread Gowrishankar Muthukrishnan
Add support for asymmetric EDDSA in cryptodev, as referenced in RFC: https://datatracker.ietf.org/doc/html/rfc8032 Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/default.ini | 1 + doc/guides/prog_guide/cryptodev_lib.rst| 2 +- lib/cryptodev/rte_crypto_asym.h

[PATCH v6 5/6] examples/fips_validation: support EDDSA

2024-10-04 Thread Gowrishankar Muthukrishnan
Add EDDSA support in fips_validation app. Signed-off-by: Gowrishankar Muthukrishnan --- v6: - fixed Makefile. --- examples/fips_validation/Makefile | 1 + examples/fips_validation/fips_validation.c| 2 + examples/fips_validation/fips_validation.h| 23

[PATCH v6 6/6] app/crypto-perf: support EDDSA

2024-10-04 Thread Gowrishankar Muthukrishnan
Added support for EDDSA 25519 curve SIGN and VERIFY operations. Signed-off-by: Gowrishankar Muthukrishnan --- app/test-crypto-perf/cperf_ops.c | 52 app/test-crypto-perf/cperf_options.h | 2 + app/test-crypto-perf/cperf_options_parsing.c | 9 +++- app

[PATCH v1] examples/fips_validation: fix EdDSA signature size

2024-10-28 Thread Gowrishankar Muthukrishnan
Fix EdDSA signature size. Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_eddsa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/fips_

[PATCH v1] examples/fips_validation: prehash input for RSA

2024-10-28 Thread Gowrishankar Muthukrishnan
Plain text needs to be prehashed for RSA as well in asymmetric crypto validation. Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

[PATCH v3 3/6] crypto/cnxk: support EDDSA

2024-09-20 Thread Gowrishankar Muthukrishnan
Support EDDSA crypto algorithm in CNXK PMD. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/cn10k.ini | 1 + drivers/common/cnxk/hw/cpt.h | 3 +- drivers/common/cnxk/roc_ae.c | 52 +- drivers/common/cnxk/roc_ae.h

[PATCH v3 2/6] crypto/openssl: support EDDSA

2024-09-20 Thread Gowrishankar Muthukrishnan
Support EDDSA crypto algorithm in OpenSSL PMD. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/openssl/openssl_pmd_private.h | 13 ++ drivers/crypto/openssl/rte_openssl_pmd.c | 223 +++ drivers/crypto/openssl/rte_openssl_pmd_ops.c | 131 +++ 3 files

[PATCH v3 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-09-20 Thread Gowrishankar Muthukrishnan
Add support for asymmetric EDDSA in cryptodev, as referenced in RFC: https://datatracker.ietf.org/doc/html/rfc8032 Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/default.ini | 1 + doc/guides/prog_guide/cryptodev_lib.rst| 2 +- lib/cryptodev/rte_crypto_asym.h

[PATCH v3 4/6] test/crypto: add asymmetric EDDSA test cases

2024-09-20 Thread Gowrishankar Muthukrishnan
Add test cases to validate EDDSA sign and verify ops, as per RFC 8032. Signed-off-by: Gowrishankar Muthukrishnan --- v3: - minor update in verify test. --- app/test/test_cryptodev_asym.c | 345 +++- app/test/test_cryptodev_ecdh_test_vectors.h | 94 +++- app/test

[PATCH v3 5/6] examples/fips_validation: support EDDSA

2024-09-20 Thread Gowrishankar Muthukrishnan
Add EDDSA support in fips_validation app. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c| 2 + examples/fips_validation/fips_validation.h| 23 ++ .../fips_validation/fips_validation_eddsa.c | 307 + examples/fips_validation

[PATCH v3 6/6] app/crypto-perf: support EDDSA

2024-09-20 Thread Gowrishankar Muthukrishnan
Added support for EDDSA 25519 curve SIGN and VERIFY operations. Signed-off-by: Gowrishankar Muthukrishnan --- app/test-crypto-perf/cperf_ops.c | 52 app/test-crypto-perf/cperf_options.h | 2 + app/test-crypto-perf/cperf_options_parsing.c | 9 +++- app

[PATCH v4 3/6] crypto/cnxk: support EDDSA

2024-10-03 Thread Gowrishankar Muthukrishnan
Support EDDSA crypto algorithm in CNXK PMD. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/cn10k.ini | 1 + drivers/common/cnxk/hw/cpt.h | 3 +- drivers/common/cnxk/roc_ae.c | 52 +- drivers/common/cnxk/roc_ae.h

[PATCH v4 5/6] examples/fips_validation: support EDDSA

2024-10-03 Thread Gowrishankar Muthukrishnan
Add EDDSA support in fips_validation app. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c| 2 + examples/fips_validation/fips_validation.h| 23 ++ .../fips_validation/fips_validation_eddsa.c | 307 + examples/fips_validation

[PATCH v4 2/6] crypto/openssl: support EDDSA

2024-10-03 Thread Gowrishankar Muthukrishnan
Support EDDSA crypto algorithm in OpenSSL PMD. Signed-off-by: Gowrishankar Muthukrishnan --- v4: - Restrict eddsa session creation only for openssl 3.3.0 and above. Lower v3.x may support pure instances, but not context and prehash instances. --- doc/guides/cryptodevs/features

[PATCH v4 4/6] test/crypto: add asymmetric EDDSA test cases

2024-10-03 Thread Gowrishankar Muthukrishnan
Add test cases to validate EDDSA sign and verify ops, as per RFC 8032. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 345 +++- app/test/test_cryptodev_ecdh_test_vectors.h | 94 +++- app/test/test_cryptodev_ecdsa_test_vectors.h | 4

[PATCH v4 6/6] app/crypto-perf: support EDDSA

2024-10-03 Thread Gowrishankar Muthukrishnan
Added support for EDDSA 25519 curve SIGN and VERIFY operations. Signed-off-by: Gowrishankar Muthukrishnan --- app/test-crypto-perf/cperf_ops.c | 52 app/test-crypto-perf/cperf_options.h | 2 + app/test-crypto-perf/cperf_options_parsing.c | 9 +++- app

[PATCH v4 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-10-03 Thread Gowrishankar Muthukrishnan
Add support for asymmetric EDDSA in cryptodev, as referenced in RFC: https://datatracker.ietf.org/doc/html/rfc8032 Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/default.ini | 1 + doc/guides/prog_guide/cryptodev_lib.rst| 2 +- lib/cryptodev/rte_crypto_asym.h

RE: [EXTERNAL] Re: [RFC] crypto/virtio: add vhost-vdpa backend

2024-11-27 Thread Gowrishankar Muthukrishnan
Hi Jason, > Hello: > > On Fri, Nov 22, 2024 at 2:03 AM Gowrishankar Muthukrishnan > wrote: > > > > Hi, > > We are adding support for vDPA user backend for virtio-crypto PMD in DPDK. > > I wonder what kind of vDPA device you are using? Is there a marvell speci

[PATCH v1] vhost: include AKCIPHER algorithms in crypto_config

2024-11-19 Thread Gowrishankar Muthukrishnan
Update virtio_crypto_config structure to include AKCIPHER algorithms, as per VirtIO standard. Signed-off-by: Gowrishankar Muthukrishnan Change-Id: I227bfa9b2bb840a92d50b21b538892927379f3f2 --- lib/vhost/virtio_crypto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib

[PATCH v2] vhost: include AKCIPHER algorithms in crypto_config

2024-11-19 Thread Gowrishankar Muthukrishnan
Update virtio_crypto_config structure to include AKCIPHER algorithms, as per VirtIO standard. Signed-off-by: Gowrishankar Muthukrishnan --- v1: - updated patch description. --- lib/vhost/virtio_crypto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vhost

[PATCH v2] vhost: include AKCIPHER algorithms in crypto_config

2024-11-19 Thread Gowrishankar Muthukrishnan
Update virtio_crypto_config structure to include AKCIPHER algorithms, as per VirtIO standard. Signed-off-by: Gowrishankar Muthukrishnan --- v1: - updated patch description. --- lib/vhost/virtio_crypto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vhost

RE: [EXTERNAL] [PATCH v3] app/dma-perf: calrify incorrect NUMA config

2024-11-19 Thread Gowrishankar Muthukrishnan
> Subject: [EXTERNAL] [PATCH v3] app/dma-perf: calrify incorrect NUMA config Looks good to me, with minor correction in subject: calrify -> clarify. Thanks, Gowrishankar

RE: [RFC] crypto/virtio: add vhost-vdpa backend

2024-11-26 Thread Gowrishankar Muthukrishnan
common issues and extending virtio functionalities efficiently. As we plan to include this feature in DPDK 25.03, we would like to conclude on the implementation direction soon. We would greatly appreciate your valuable feedback or any suggestions on this proposal. Thank you! Thanks, Gowrishankar

RE: [EXTERNAL] Re: [PATCH] maintainers: update for DMA perf app

2024-11-14 Thread Gowrishankar Muthukrishnan
Hi, > wrote: > > > > Add co-maintainer for DMA perf app. > > > > Signed-off-by: Gowrishankar Muthukrishnan > > Good to have more maintainers. > > Acked-by: Jerin Jacob > > Could this patch be applied ?. Thanks, Gowrishankar > > &g

RE: [EXTERNAL] Re: [RFC] crypto/virtio: add vhost-vdpa backend

2024-12-05 Thread Gowrishankar Muthukrishnan
well. https://lore.kernel.org/virtualization/20241121134002.990285-3-sthot...@marvell.com/ Regards, Gowrishankar

[PATCH] test/crypto: check for RSA capability

2025-01-07 Thread Gowrishankar Muthukrishnan
In RSA crypto tests, check if it is supported by PMD before executing it. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 24 1 file changed, 24 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c

[PATCH] crypto/virtio: fix dataqueues iteration

2025-01-07 Thread Gowrishankar Muthukrishnan
Fix dataqueues iteration using nb_queue_pairs info available in device data instead of max dataqueues as dataqueue count might have been changed in device configuration. Fixes: 6f0175ff53e0 ("crypto/virtio: support basic PMD ops") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Mut

[v2 0/4] crypto/virtio: add vDPA backend support

2025-01-07 Thread Gowrishankar Muthukrishnan
ring support") Depends-on: series-34291 ("crypto/virtio: add RSA support") v2: - split from v1 series. Gowrishankar Muthukrishnan (4): common/virtio: move vDPA to common directory common/virtio: support cryptodev in vdev setup crypto/virtio: add vhost backend to virtio_use

[v2 0/2] crypto/virtio: add RSA support

2025-01-07 Thread Gowrishankar Muthukrishnan
This series adds RSA support in virtio crypto PMD. v2: - split from v1 series. Gowrishankar Muthukrishnan (2): crypto/virtio: add asymmetric RSA support test/crypto: add asymmetric tests for virtio PMD app/test/test_cryptodev_asym.c| 29 ++ app/test

[v2 1/2] vhost: add asymmetric RSA support

2025-01-07 Thread Gowrishankar Muthukrishnan
Support asymmetric RSA crypto operations in vhost-user. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: series-34291 ("crypto/virtio: add RSA support") lib/vhost/vhost_crypto.c | 504 --- lib/vhost/vhost_user.h | 33 ++- 2 files ch

[v2 0/2] vhost: add RSA support

2025-01-07 Thread Gowrishankar Muthukrishnan
This series adds RSA support in vhost_crypto library. v2: - split from v1 series. Depends-on: series-34291 ("crypto/virtio: add RSA support") Gowrishankar Muthukrishnan (2): vhost: add asymmetric RSA support examples/vhost_crypto: add asymmetric support examples/vhost_crypto/ma

[v2 1/2] crypto/virtio: add asymmetric RSA support

2025-01-07 Thread Gowrishankar Muthukrishnan
Asymmetric RSA operations (SIGN, VERIFY, ENCRYPT and DECRYPT) are supported in virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- .../virtio/virtio_crypto_capabilities.h | 19 + drivers/crypto/virtio/virtio_cryptodev.c | 384 +++--- drivers/crypto/virtio

[v2 2/2] test/crypto: add asymmetric tests for virtio PMD

2025-01-07 Thread Gowrishankar Muthukrishnan
Add asymmetric tests for Virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 29 ++ app/test/test_cryptodev_rsa_test_vectors.h | 4 +++ 2 files changed, 33 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app

[v2 3/4] crypto/virtio: add vhost backend to virtio_user

2025-01-07 Thread Gowrishankar Muthukrishnan
Add vhost backend to virtio_user crypto. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/meson.build | 7 + drivers/crypto/virtio/virtio_cryptodev.c | 57 +- drivers/crypto/virtio/virtio_cryptodev.h | 3 + drivers/crypto/virtio/virtio_pci.h

[v2 2/4] common/virtio: support cryptodev in vdev setup

2025-01-07 Thread Gowrishankar Muthukrishnan
Support cryptodev in vdev setup. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/virtio/virtio_user/vhost_vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/common/virtio/virtio_user/vhost_vdpa.c b/drivers/common/virtio/virtio_user/vhost_vdpa.c

[v2 1/4] common/virtio: move vDPA to common directory

2025-01-07 Thread Gowrishankar Muthukrishnan
Move vhost-vdpa backend implementation into common folder. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: patch-149672 ("vhost: include AKCIPHER algorithms in crypto_config") Depends-on: patch-148913 ("crypto/virtio: remove redundant crypto queue free") Depe

[v2 4/4] test/crypto: test virtio_crypto_user PMD

2025-01-07 Thread Gowrishankar Muthukrishnan
Reuse virtio_crypto tests for testing virtio_crypto_user PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_asym.c | 15 +++ 3 files changed, 23 insertions(+) diff --git a

[v2 1/2] crypto/virtio: refactor queue operations

2025-01-07 Thread Gowrishankar Muthukrishnan
Move existing control queue operations into a common place that would be shared with other virtio type of devices. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: series-34291 ("crypto/virtio: add RSA support") drivers/crypto/virtio/meson.build | 1 + drivers/cry

[v2 0/2] crypto/virtio: add packed ring support

2025-01-07 Thread Gowrishankar Muthukrishnan
This series adds packed ring support in virtio crypto PMD. Depends-on: series-34291 ("crypto/virtio: add RSA support") v2: - split from v1 series. Gowrishankar Muthukrishnan (2): crypto/virtio: refactor queue operations crypto/virtio: add packed ring support drivers/cry

[v2 2/2] examples/vhost_crypto: add asymmetric support

2025-01-07 Thread Gowrishankar Muthukrishnan
Add symmetric support. Signed-off-by: Gowrishankar Muthukrishnan --- examples/vhost_crypto/main.c | 54 ++-- 1 file changed, 40 insertions(+), 14 deletions(-) diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c index 558c09a60f..8bdfc40c4b

[v2 2/2] crypto/virtio: add packed ring support

2025-01-07 Thread Gowrishankar Muthukrishnan
Add packed ring support. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/virtio_cryptodev.c | 125 +++ drivers/crypto/virtio/virtio_cryptodev.h | 13 +- drivers/crypto/virtio/virtio_cvq.c | 103 +- drivers/crypto/virtio/virtio_pci.h | 25 ++ drivers

[v3] vhost: include AKCIPHER algorithms in crypto_config

2025-01-07 Thread Gowrishankar Muthukrishnan
Update virtio_crypto_config structure to include AKCIPHER algorithms, as per VirtIO standard. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- v3: - rebased on main. lib/vhost/virtio_crypto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vhost

RE: [EXTERNAL] Re: [v1 12/16] common/virtio: common virtio log

2025-01-07 Thread Gowrishankar Muthukrishnan
Hi David, > Hello Gowri, > > On Tue, Dec 24, 2024 at 8:39 AM Gowrishankar Muthukrishnan > wrote: > > > > Common virtio log include file. > > That's really a short commitlog.. > What are you trying to achieve? As part of sharing vDPA backend ops implementa

[v1 00/16] crypto/virtio: vDPA and asymmetric support

2024-12-23 Thread Gowrishankar Muthukrishnan
This series introduces vDPA backend support to virtio crypto PMD. Also added asymmetric RSA support. Gowrishankar Muthukrishnan (14): vhost: include AKCIPHER algorithms in crypto_config crypto/virtio: add asymmetric RSA support test/crypto: check for RSA capability test/crypto: add

[v1 01/16] vhost: include AKCIPHER algorithms in crypto_config

2024-12-23 Thread Gowrishankar Muthukrishnan
Update virtio_crypto_config structure to include AKCIPHER algorithms, as per VirtIO standard. Signed-off-by: Gowrishankar Muthukrishnan --- lib/vhost/virtio_crypto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vhost/virtio_crypto.h b/lib/vhost/virtio_crypto.h index

[v1 02/16] crypto/virtio: remove redundant crypto queue free

2024-12-23 Thread Gowrishankar Muthukrishnan
From: Rajesh Mudimadugula Remove multiple invocations of virtio_crypto_queue_release, and set virtio crypto queue as null upon free to avoid segfaults. Signed-off-by: Rajesh Mudimadugula --- .mailmap | 1 + drivers/crypto/virtio/virtio_cryptodev.c | 11 +---

[v1 10/16] crypto/virtio: refactor queue operations

2024-12-23 Thread Gowrishankar Muthukrishnan
Move existing control queue operations into a common place that would be shared with other virtio type of devices. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/meson.build | 1 + drivers/crypto/virtio/virtio_crypto_algs.h | 2 +- drivers/crypto/virtio

[v1 09/16] crypto/virtio: fix dataqueues iteration

2024-12-23 Thread Gowrishankar Muthukrishnan
Fix dataqueues iteration using nb_queue_pairs info available in device data instead of max dataqueues as dataqueue count might have been changed in device configuration. Fixes: 6f0175ff53e0 ("crypto/virtio: support basic PMD ops") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Mut

[v1 04/16] test/crypto: check for RSA capability

2024-12-23 Thread Gowrishankar Muthukrishnan
In RSA crypto tests, check if it is supported by PMD before executing it. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 24 1 file changed, 24 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c

[v1 07/16] vhost: add asymmetric RSA support

2024-12-23 Thread Gowrishankar Muthukrishnan
Support asymmetric RSA crypto operations in vhost-user. Signed-off-by: Gowrishankar Muthukrishnan --- lib/vhost/vhost_crypto.c | 504 --- lib/vhost/vhost_user.h | 33 ++- 2 files changed, 498 insertions(+), 39 deletions(-) diff --git a/lib/vhost

[v1 03/16] crypto/virtio: add asymmetric RSA support

2024-12-23 Thread Gowrishankar Muthukrishnan
Asymmetric RSA operations (SIGN, VERIFY, ENCRYPT and DECRYPT) are supported in virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- .../virtio/virtio_crypto_capabilities.h | 19 + drivers/crypto/virtio/virtio_cryptodev.c | 384 +++--- drivers/crypto/virtio

[v1 08/16] examples/vhost_crypto: add asymmetric support

2024-12-23 Thread Gowrishankar Muthukrishnan
Add symmetric support. Signed-off-by: Gowrishankar Muthukrishnan --- examples/vhost_crypto/main.c | 54 ++-- 1 file changed, 40 insertions(+), 14 deletions(-) diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c index 558c09a60f..8bdfc40c4b

[v1 05/16] test/crypto: return proper codes in create session

2024-12-23 Thread Gowrishankar Muthukrishnan
From: Rajesh Mudimadugula Return proper error codes in create_auth_session() to avoid segfaults as a result of this. Signed-off-by: Rajesh Mudimadugula --- app/test/test_cryptodev.c | 38 -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/app

[v1 06/16] test/crypto: add asymmetric tests for virtio PMD

2024-12-23 Thread Gowrishankar Muthukrishnan
Add asymmetric tests for Virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 29 ++ app/test/test_cryptodev_rsa_test_vectors.h | 4 +++ 2 files changed, 33 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app

[v1 15/16] crypto/virtio: add vhost backend to virtio_user

2024-12-23 Thread Gowrishankar Muthukrishnan
Add vhost backend to virtio_user crypto. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/meson.build | 7 + drivers/crypto/virtio/virtio_cryptodev.c | 57 +- drivers/crypto/virtio/virtio_cryptodev.h | 3 + drivers/crypto/virtio/virtio_pci.h

[v1 11/16] crypto/virtio: add packed ring support

2024-12-23 Thread Gowrishankar Muthukrishnan
Add packed ring support. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/virtio_cryptodev.c | 125 +++ drivers/crypto/virtio/virtio_cryptodev.h | 13 +- drivers/crypto/virtio/virtio_cvq.c | 103 +- drivers/crypto/virtio/virtio_pci.h | 25 ++ drivers

[v1 16/16] test/crypto: test virtio_crypto_user PMD

2024-12-23 Thread Gowrishankar Muthukrishnan
Reuse virtio_crypto tests for testing virtio_crypto_user PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_asym.c | 15 +++ 3 files changed, 23 insertions(+) diff --git a

[v1 12/16] common/virtio: common virtio log

2024-12-23 Thread Gowrishankar Muthukrishnan
Common virtio log include file. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/{net => common}/virtio/virtio_logs.h | 16 ++ drivers/crypto/virtio/meson.build | 1 + .../{virtio_logs.h => virtio_crypto_logs.h} | 30 --- drivers/crypto/

[v1 13/16] common/virtio: move vDPA to common directory

2024-12-23 Thread Gowrishankar Muthukrishnan
Move vhost-vdpa backend implementation into common folder. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/virtio/meson.build | 13 + drivers/common/virtio/version.map | 9 ++ .../virtio/virtio_user/vhost.h| 2 -- .../virtio

[v1 14/16] common/virtio: support cryptodev in vdev setup

2024-12-23 Thread Gowrishankar Muthukrishnan
Support cryptodev in vdev setup. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/virtio/virtio_user/vhost_vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/common/virtio/virtio_user/vhost_vdpa.c b/drivers/common/virtio/virtio_user/vhost_vdpa.c

RE: [EXTERNAL] Re: [v2 1/4] common/virtio: move vDPA to common directory

2025-02-06 Thread Gowrishankar Muthukrishnan
Hi Maxime, > On 1/7/25 7:44 PM, Gowrishankar Muthukrishnan wrote: > > Move vhost-vdpa backend implementation into common folder. > > If we decided to have a common base for Virtio devices, which I think is a > good > idea to avoid needless duplication, we should do a

[RFC] crypto/virtio: add vhost-vdpa backend

2024-11-21 Thread Gowrishankar Muthukrishnan
ggestions. Thanks, Gowrishankar -- 2.37.1

[PATCH 1/1] test/crypto: additional RSA tests for CNXK PMD

2025-01-22 Thread Gowrishankar Muthukrishnan
Include additional RSA tests for CNXK PMD. These tests validates RSA operations using private key in exponent form. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/test

RE: [EXTERNAL] Re: [v2 2/2] examples/vhost_crypto: add asymmetric support

2025-01-30 Thread Gowrishankar Muthukrishnan
new version of this series). Thanks, Gowrishankar > > > }; > > > > static int > > @@ -376,6 +386,7 @@ vhost_crypto_worker(void *arg) > > int callfds[VIRTIO_CRYPTO_MAX_NUM_BURST_VQS]; > > uint32_t lcore_id = rte_lcore_id(); > > uint32_t burst_size =

[PATCH] test/crypto: add test case for modex group 24

2025-04-20 Thread Gowrishankar Muthukrishnan
Add test case for modex group 24. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 16 ++ app/test/test_cryptodev_mod_test_vectors.h | 227 + 2 files changed, 243 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/test

[PATCH] test/crypto: increment dequeue timeout

2025-04-20 Thread Gowrishankar Muthukrishnan
Increment dequeue timeout to allow implementations taking longer cycles. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index

[PATCH v2] test/crypto: increment dequeue timeout

2025-05-06 Thread Gowrishankar Muthukrishnan
Increment dequeue timeout to allow implementations taking longer cycles. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - no changes. only for CI. --- app/test/test_cryptodev_asym.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test

[PATCH] crypto/virtio: support RSA 8K mod ops

2025-04-29 Thread Gowrishankar Muthukrishnan
Support RSA 8K mod ops in virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/virtio_cryptodev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/virtio/virtio_cryptodev.h b/drivers/crypto/virtio/virtio_cryptodev.h index

[PATCH] app/crypto-perf: add RSA test vectors

2025-04-29 Thread Gowrishankar Muthukrishnan
Add test vectors to benchmark larger RSA modulus. Signed-off-by: Gowrishankar Muthukrishnan --- app/test-crypto-perf/cperf_options.h |3 + app/test-crypto-perf/cperf_options_parsing.c | 132 +- app/test-crypto-perf/cperf_test_vectors.c| 1386 +- app/test-crypto

[v8 5/5] examples/vhost_crypto: support asymmetric crypto

2025-02-27 Thread Gowrishankar Muthukrishnan
Support asymmetric crypto operations. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- doc/guides/sample_app_ug/vhost_crypto.rst | 5 +++ examples/vhost_crypto/main.c | 50 +-- 2 files changed, 43 insertions(+), 12 deletions(-) diff --git a

[v8 4/5] vhost: support asymmetric RSA crypto ops

2025-02-27 Thread Gowrishankar Muthukrishnan
Support asymmetric RSA crypto operations in vhost-user. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- doc/guides/rel_notes/release_25_03.rst | 3 + lib/vhost/vhost_crypto.c | 486 +++-- lib/vhost/virtio_crypto.h | 67

[v2] app/crypto-perf: add RSA support

2025-02-27 Thread Gowrishankar Muthukrishnan
From: Akhil Goyal Add RSA support in crypto-perf application. Signed-off-by: Akhil Goyal --- v2: - fixed RSA padding type. --- app/test-crypto-perf/cperf_ops.c | 69 app/test-crypto-perf/cperf_options.h | 4 + app/test-crypto-perf/cperf_options_parsing.c | 38

[v6 2/6] crypto/virtio: refactor queue operations

2025-03-04 Thread Gowrishankar Muthukrishnan
Move existing control queue operations into a common place that would be shared with other virtio type of devices. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/meson.build | 1 + drivers/crypto/virtio/virtio_crypto_algs.h | 2 +- drivers/crypto/virtio

[v6 1/6] crypto/virtio: add asymmetric RSA support

2025-03-04 Thread Gowrishankar Muthukrishnan
Asymmetric RSA operations (SIGN, VERIFY, ENCRYPT and DECRYPT) are supported in virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/virtio.ini | 4 + doc/guides/rel_notes/release_25_03.rst| 4 + .../virtio/virtio_crypto_capabilities.h

[v6 5/6] test/crypto: add asymmetric tests for virtio PMD

2025-03-04 Thread Gowrishankar Muthukrishnan
Add asymmetric tests for Virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 28 1 file changed, 28 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index 9b5f3c545e..ac47be724f 100644

[v6 6/6] test/crypto: add tests for virtio user PMD

2025-03-04 Thread Gowrishankar Muthukrishnan
Reuse virtio_crypto tests for testing virtio_crypto_user PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_asym.c | 15 +++ 3 files changed, 23 insertions(+) diff --git a

[v6 0/6] crypto/virtio: enhancements for RSA and vDPA

2025-03-04 Thread Gowrishankar Muthukrishnan
This patch series enhances virtio crypto PMD to: * support RSA * support packed virtio ring * support vDPA backend v6: - patches rebased. Gowrishankar Muthukrishnan (6): crypto/virtio: add asymmetric RSA support crypto/virtio: refactor queue operations crypto/virtio: add packed ring

[v6 4/6] crypto/virtio: add vDPA backend

2025-03-04 Thread Gowrishankar Muthukrishnan
Add vDPA backend to virtio_user crypto. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/meson.build | 7 + drivers/crypto/virtio/virtio_cryptodev.c | 57 +- drivers/crypto/virtio/virtio_cryptodev.h | 3 + drivers/crypto/virtio/virtio_logs.h

[v6 3/6] crypto/virtio: add packed ring support

2025-03-04 Thread Gowrishankar Muthukrishnan
Add packed ring support. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/virtio_cryptodev.c | 125 +++ drivers/crypto/virtio/virtio_cryptodev.h | 13 +- drivers/crypto/virtio/virtio_cvq.c | 103 +- drivers/crypto/virtio/virtio_pci.h | 25 ++ drivers

[PATCH] test/crypto: skip test when virtio PMD not loaded

2025-03-11 Thread Gowrishankar Muthukrishnan
Skip asymmetric test when virtio PMD is not loaded. Fixes: 7e2e9d5f3227 ("test/crypto: add asymmetric cases for virtio") Fixes: a8f3d4f5b547 ("test/crypto: add cases for virtio-user") Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 4 ++-

<    3   4   5   6   7   8   9   >