RE: [PATCH v2] examples/fips_validation: add parsing for AES CTR

2022-09-16 Thread Gowrishankar Muthukrishnan
Tested with FIPS test vectors from NIST. Acked-by: Gowrishankar Muthukrishnan Thanks, Gowrishankar > -Original Message- > From: Ji, Kai > Sent: Thursday, September 15, 2022 6:52 PM > To: Dooley, Brian ; Zhang, Roy Fan > > Cc: dev@dpdk.org; Gowrishankar Muthukrishn

[v2 1/7] examples/fips_validation: fix parsing test group info

2022-09-26 Thread Gowrishankar Muthukrishnan
If a test group does not have expected key, it should not crash. This patch fixes parsing test group info to continue further when a key does not exist (as in asym tests). Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") Signed-off-by: Gowrishankar Muthukrishnan Acked

[v2 2/7] examples/fips_validation: add interim parse writeback

2022-09-26 Thread Gowrishankar Muthukrishnan
Asym tests need a callback to write interim info in expected output. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- examples/fips_validation/fips_validation.c | 6 ++ examples/fips_validation/fips_validation.h | 1 + 2 files changed, 7 insertions(+) diff --git a

[v2 3/7] examples/fips_validation: add function to calculate SHA hash size

2022-09-26 Thread Gowrishankar Muthukrishnan
Add function to calculate hash size for a given SHA hash algorithm. Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- v2: - fixed include file --- examples/fips_validation/fips_validation

[v2 4/7] examples/fips_validation: fix buffer size to parse JSON string

2022-09-26 Thread Gowrishankar Muthukrishnan
In asym op, while parsing test interim info, existing buffer of size 256 bytes is not sufficient, hence setting it to maximum that a test would need. Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley ---

[v2 5/7] examples/fips_validation: add asymmetric validation

2022-09-26 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley -- v2: - improved handling priv key type

[v2 6/7] examples/fips_validation: encode digest with hash OID

2022-09-26 Thread Gowrishankar Muthukrishnan
FIPS RSA validation requires hash ddigest be encoded with ASN.1 value for digest info. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 78 + 1 file changed, 78 insertions(+) diff --git a/examples/fips_validation/main.c b/examples

[v2 7/7] examples/fips_validation: randomize message for conformance test

2022-09-26 Thread Gowrishankar Muthukrishnan
FIPS conformance tests require randomizing message based on SP 800-106. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_rsa.c | 112 +- 2 files changed, 115 insertions(+), 1 deletion

[v2 0/7] FIPS asymmetric validation

2022-09-27 Thread Gowrishankar Muthukrishnan
encoding for fips validation - addition of message randomization for fips conformance tests. Gowrishankar Muthukrishnan (7): examples/fips_validation: fix parsing test group info examples/fips_validation: add interim parse writeback examples/fips_validation: add function to calculate SHA hash

[v2 2/7] examples/fips_validation: add interim parse writeback

2022-09-27 Thread Gowrishankar Muthukrishnan
Asym tests need a callback to write interim info in expected output. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- examples/fips_validation/fips_validation.c | 6 ++ examples/fips_validation/fips_validation.h | 1 + 2 files changed, 7 insertions(+) diff --git a

[v2 1/7] examples/fips_validation: fix parsing test group info

2022-09-27 Thread Gowrishankar Muthukrishnan
If a test group does not have expected key, it should not crash. This patch fixes parsing test group info to continue further when a key does not exist (as in asym tests). Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") Signed-off-by: Gowrishankar Muthukrishnan Acked

[v2 3/7] examples/fips_validation: add function to calculate SHA hash size

2022-09-27 Thread Gowrishankar Muthukrishnan
Add function to calculate hash size for a given SHA hash algorithm. Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- v2: - fixed include file --- examples/fips_validation/fips_validation

[v2 4/7] examples/fips_validation: fix buffer size to parse JSON string

2022-09-27 Thread Gowrishankar Muthukrishnan
In asym op, while parsing test interim info, existing buffer of size 256 bytes is not sufficient, hence setting it to maximum that a test would need. Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley ---

[v2 5/7] examples/fips_validation: add asymmetric validation

2022-09-27 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley -- v2: - improved handling priv key type

[v2 6/7] examples/fips_validation: encode digest with hash OID

2022-09-27 Thread Gowrishankar Muthukrishnan
FIPS RSA validation requires hash ddigest be encoded with ASN.1 value for digest info. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 78 + 1 file changed, 78 insertions(+) diff --git a/examples/fips_validation/main.c b/examples

[v2 7/7] examples/fips_validation: randomize message for conformance test

2022-09-27 Thread Gowrishankar Muthukrishnan
FIPS conformance tests require randomizing message based on SP 800-106. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_rsa.c | 112 +- 2 files changed, 115 insertions(+), 1 deletion

[v1 1/2] cryptodev: add enumeration in EC xform for FPM

2022-09-27 Thread Gowrishankar Muthukrishnan
Add enumeration in EC xform for FPM. Crypto driver would need this to xform point multiplication based on given type of EC curve. Signed-off-by: Kiran Kumar K Signed-off-by: Gowrishankar Muthukrishnan --- lib/cryptodev/rte_crypto_asym.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a

[v1 0/2] examples/fips_validation: add ECDSA tests

2022-09-27 Thread Gowrishankar Muthukrishnan
This series adds ECDSA validation in fips_validation app. Depends-on: series-24851 ("FIPS asymmetric validation") Gowrishankar Muthukrishnan (2): cryptodev: add enumeration in EC xform for FPM examples/fips_validation: add ECDSA validation doc/guides/sample_app_ug/fips_vali

[v1 2/2] examples/fips_validation: add ECDSA validation

2022-09-27 Thread Gowrishankar Muthukrishnan
This patch adds support in fips_validation app to validate ECDSA. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/sample_app_ug/fips_validation.rst | 1 + examples/fips_validation/fips_validation.c| 2 + examples/fips_validation/fips_validation.h| 27

[v1] crypto/cnxk: add support for fixed point multiplication

2022-09-27 Thread Gowrishankar Muthukrishnan
Add fixed point multiplication for EC curve in CNXK. Signed-off-by: Kiran Kumar K Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/roc_ae.h | 1 + drivers/crypto/cnxk/cnxk_ae.h | 69 +++ .../crypto/cnxk

[v1] crypto/cnxk: support exponent type private key

2022-09-27 Thread Gowrishankar Muthukrishnan
This patch adds support for RTE_RSA_KEY_TYPE_EXP in cnxk crypto driver. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/cnxk/cnxk_ae.h| 60 ++-- drivers/crypto/cnxk/cnxk_cryptodev.c | 1 + 2 files changed, 48 insertions(+), 13 deletions(-) diff

RE: [EXT] [dpdk-dev v2] app/test: random test vectors for Asymc RSA

2022-09-27 Thread Gowrishankar Muthukrishnan
> -Original Message- > From: Przemyslaw Zegan > Sent: Wednesday, August 17, 2022 7:45 PM > To: dev@dpdk.org > Cc: Akhil Goyal ; roy.fan.zh...@intel.com; > Przemyslaw Zegan > Subject: [EXT] [dpdk-dev v2] app/test: random test vectors for Asymc RSA > > External Email > > -

[dpdk-dev] [v5] telemetry: fix json output buffer size

2021-09-28 Thread Gowrishankar Muthukrishnan
Fix json output buffer size for an actual data length. Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON") Signed-off-by: Gowrishankar Muthukrishnan --- lib/telemetry/telemetry_json.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib

[dpdk-dev] [v1] ethdev: add telemetry endpoint for device info

2021-09-28 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint /ethdev/info for device info. Signed-off-by: Gowrishankar Muthukrishnan Change-Id: I3e6ee2bd1a80675473adf0bd884b194f98e28536 --- lib/ethdev/rte_ethdev.c | 92 + 1 file changed, 92 insertions(+) diff --git a/lib/ethdev/rte_ethdev.c

Re: [dpdk-dev] [EXT] [PATCH] cryptodev: add telemetry callbacks

2021-09-28 Thread Gowrishankar Muthukrishnan
t; return nb_drivers++; > } > + > +static int > +cryptodev_handle_dev_list(const char *cmd __rte_unused, > + const char *params __rte_unused, > + struct rte_tel_data *d) > +{ > + int dev_id; > + > + if (rte_cryptodev_count() < 1) > + return -1; > + > + rte_tel_data_start_dict(d); > + for (dev_id = 0; dev_id < RTE_CRYPTO_MAX_DEVS; dev_id++) > + if (rte_cryptodev_pmd_is_valid_dev(dev_id)) This is broken now. Correct function is rte_cryptodev_is_valid_dev() . Thanks, Gowrishankar

[dpdk-dev] [v1] mempool: add telemetry endpoint for mempool info

2021-09-28 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint for mempool info. Signed-off-by: Gowrishankar Muthukrishnan --- lib/mempool/rte_mempool.c | 84 +++ 1 file changed, 84 insertions(+) diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index 59a588425b..b8dad2997a 100644

[dpdk-dev] [v1] cryptodev: add telemetry endpoint for cryptodev info

2021-09-28 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint for cryptodev info. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: patch-18355 ("cryptodev: add telemetry callbacks") Depends-on: patch-19247 ("telemetry: fix json output buffer size") --- lib/cryptodev/

[dpdk-dev] [v9 0/4] cnxk: enable telemetry endpoints

2021-09-28 Thread Gowrishankar Muthukrishnan
19251 ("mempool: add telemetry endpoint for mempool info") v9: - moved common info from drivers to lib endpoints. Gowrishankar Muthukrishnan (4): common/cnxk: add telemetry endpoints to npa common/cnxk: add telemetry endpoints to nix mempool/cnxk: add telemetry endpoints mem

[dpdk-dev] [v9 1/4] common/cnxk: add telemetry endpoints to npa

2021-09-28 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to npa. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry.h | 26 +++ drivers/common/cnxk/cnxk_telemetry_npa.c | 224 +++ drivers/common/cnxk/meson.build | 6 +- drivers/common/cnxk/roc_platform.h

[dpdk-dev] [v9 2/4] common/cnxk: add telemetry endpoints to nix

2021-09-28 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to nix. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry_nix.c | 849 +++ drivers/common/cnxk/meson.build | 3 +- drivers/common/cnxk/roc_nix.c| 3 + drivers/common/cnxk/roc_nix_priv.h

[dpdk-dev] [v9 3/4] mempool/cnxk: add telemetry endpoints mempool

2021-09-28 Thread Gowrishankar Muthukrishnan
Adding telemetry endpoints to cnxk mempool driver. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/mempool/cnxk/cnxk_mempool_telemetry.c | 57 +++ drivers/mempool/cnxk/meson.build | 1 + 2 files changed, 58 insertions(+) create mode 100644 drivers/mempool

[dpdk-dev] [v9 4/4] net/cnxk: add telemetry endpoints to ethdev

2021-09-28 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to ethdev. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/net/cnxk/cnxk_ethdev_telemetry.c | 93 drivers/net/cnxk/meson.build | 1 + 2 files changed, 94 insertions(+) create mode 100644 drivers/net/cnxk

[dpdk-dev] [v3] crypto/cnxk: add telemetry endpoints to cryptodev

2021-09-29 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to cryptodev. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: patch-19252 ("cryptodev: add telemetry endpoint for cryptodev info") Depends-on: series-19253 ("cnxk: enable telemetry endpoints") v3: - common info moved to lib/cryptodev endpo

[dpdk-dev] [v4] crypto/cnxk: add telemetry endpoints to cryptodev

2021-09-29 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to cryptodev. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: patch-19252 ("cryptodev: add telemetry endpoint for cryptodev info") Depends-on: series-19253 ("cnxk: enable telemetry endpoints") v4: - fix compilation issue.

Re: [dpdk-dev] [v2] telemetry: fix json output buffer size

2021-09-30 Thread Gowrishankar Muthukrishnan
> > I am not sure why it is needed to have limits defined per platform - can you > explain further about why it is necessary? > Mainly, for the endpoint in driver. In case, if the endpoint data is bigger than MAX_SINGLE_STRING_LEN at the worst case, endpoint will not work correctly. Thanks, Gowrishankar

Re: [dpdk-dev] [EXT] Re: [v5] telemetry: fix json output buffer size

2021-10-06 Thread Gowrishankar Muthukrishnan
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 6, 2021 11:09 PM > To: Gowrishankar Muthukrishnan > Cc: dev@dpdk.org; bruce.richard...@intel.com; ciara.po...@intel.com; Jerin > Jacob Kollanukkaran > Subject: [EXT] Re: [dpdk-dev

Re: [dpdk-dev] [EXT] Re: [v5] telemetry: fix json output buffer size

2021-10-07 Thread Gowrishankar Muthukrishnan
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, October 7, 2021 12:52 PM > To: Gowrishankar Muthukrishnan > Cc: dev@dpdk.org; bruce.richard...@intel.com; ciara.po...@intel.com; Jerin > Jacob Kollanukkaran > Subject: Re: [EXT] Re: [dpdk-dev] [v5] telem

Re: [dpdk-dev] [EXT] [PATCH v2] eventdev/rx-adapter: add telemetry callbacks

2021-10-07 Thread Gowrishankar Muthukrishnan
ue_conf.ev, queue_id); > + RXA_ADD_DICT(queue_conf.ev, sched_type); > + RXA_ADD_DICT(queue_conf.ev, priority); > + RXA_ADD_DICT(queue_conf.ev, flow_id); > + > + return 0; > +} > + > +RTE_INIT(rxa_init_telemetry) > +{ > + rte_telemetry_register_cm

[dpdk-dev] [v6] telemetry: remove limitation on JSON output buffer length

2021-10-11 Thread Gowrishankar Muthukrishnan
Earlier, JSON message length was limited to 1024 which would not allow data more than this size. Removed this limitation by creating output buffer based on requested data length. Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON") Signed-off-by: Gowrishankar Mut

[v3 0/3] FIPS asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
submitted here. v2: - minor fixes in v1 - addition of digest encoding for fips validation - addition of message randomization for fips conformance tests. Gowrishankar Muthukrishnan (3): examples/fips_validation: add asymmetric validation examples/fips_validation: encode digest with hash OID

[v3 1/3] examples/fips_validation: add asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley -- v3: - rebased according to cryptodev session

[v3 2/3] examples/fips_validation: encode digest with hash OID

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS RSA validation requires hash digest be encoded with ASN.1 value for digest info. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 78 + 1 file changed, 78 insertions(+) diff --git a/examples/fips_validation/main.c b/examples

[v3 3/3] examples/fips_validation: randomize message for conformance test

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS conformance tests require randomizing message based on SP 800-106. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_rsa.c | 112 +- 2 files changed, 115 insertions(+), 1 deletion

[v2] crypto/cnxk: support exponent type private key

2022-10-11 Thread Gowrishankar Muthukrishnan
This patch adds support for RTE_RSA_KEY_TYPE_EXP in cnxk crypto driver. Signed-off-by: Gowrishankar Muthukrishnan -- v2: - new function to handle exp type priv key. --- drivers/crypto/cnxk/cnxk_ae.h| 112 ++- drivers/crypto/cnxk/cnxk_cryptodev.c | 1 + 2 files

[v4 0/3] FIPS asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
and 7 in v2 are rebased and submitted here. v2: - minor fixes in v1 - addition of digest encoding for fips validation - addition of message randomization for fips conformance tests. Gowrishankar Muthukrishnan (3): examples/fips_validation: add asymmetric validation examples

[v4 1/3] examples/fips_validation: add asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley -- v4: - AES GMAC callback fix. v3: - rebased

[v4 3/3] examples/fips_validation: randomize message for conformance test

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS conformance tests require randomizing message based on SP 800-106. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_rsa.c | 112 +- 2 files changed, 115 insertions(+), 1 deletion

[v4 2/3] examples/fips_validation: encode digest with hash OID

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS RSA validation requires hash ddigest be encoded with ASN.1 value for digest info. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 78 + 1 file changed, 78 insertions(+) diff --git a/examples/fips_validation/main.c b/examples

[v5 0/3] FIPS asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
. v3: - patches 5,6 and 7 in v2 are rebased and submitted here. v2: - minor fixes in v1 - addition of digest encoding for fips validation - addition of message randomization for fips conformance tests. Gowrishankar Muthukrishnan (3): examples/fips_validation: add asymmetric validation

[v5 1/3] examples/fips_validation: add asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley -- v5: - release notes. v4: - AES GMAC callback

[v5 2/3] examples/fips_validation: encode digest with hash OID

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS RSA validation requires hash ddigest be encoded with ASN.1 value for digest info. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 78 + 1 file changed, 78 insertions(+) diff --git a/examples/fips_validation/main.c b/examples

[v5 3/3] examples/fips_validation: randomize message for conformance test

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS conformance tests require randomizing message based on SP 800-106. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_rsa.c | 112 +- 2 files changed, 115 insertions(+), 1 deletion

[v6 0/3] FIPS asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
. v4: - AES GMAC callback fixes. v3: - patches 5,6 and 7 in v2 are rebased and submitted here. v2: - minor fixes in v1 - addition of digest encoding for fips validation - addition of message randomization for fips conformance tests. Gowrishankar Muthukrishnan (3): examples

[v6 1/3] examples/fips_validation: add asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley -- v6: - checpatch related fix. v5: - release

[v6 2/3] examples/fips_validation: encode digest with hash OID

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS RSA validation requires hash ddigest be encoded with ASN.1 value for digest info. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 78 + 1 file changed, 78 insertions(+) diff --git a/examples/fips_validation/main.c b/examples

[v6 3/3] examples/fips_validation: randomize message for conformance test

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS conformance tests require randomizing message based on SP 800-106. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_rsa.c | 112 +- 2 files changed, 115 insertions(+), 1 deletion

[v3] crypto/cnxk: support exponent type private key

2022-10-11 Thread Gowrishankar Muthukrishnan
This patch adds support for RTE_RSA_KEY_TYPE_EXP in cnxk crypto driver. Signed-off-by: Gowrishankar Muthukrishnan -- v3: - .ini updates. v2: - new function to handle exp type priv key. --- doc/guides/cryptodevs/features/cn10k.ini | 2 + doc/guides/cryptodevs/features/cn9k.ini | 2

[v7 0/3] FIPS asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
. Gowrishankar Muthukrishnan (3): examples/fips_validation: add asymmetric validation examples/fips_validation: encode digest with hash OID examples/fips_validation: randomize message for conformance test config/meson.build| 6 + doc/guides/rel_notes/release_22_11

[v7 1/3] examples/fips_validation: add asymmetric validation

2022-10-11 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley -- v7: - fix test to return error if not

[v7 2/3] examples/fips_validation: encode digest with hash OID

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS RSA validation requires hash ddigest be encoded with ASN.1 value for digest info. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 78 + 1 file changed, 78 insertions(+) diff --git a/examples/fips_validation/main.c b/examples

[v7 3/3] examples/fips_validation: randomize message for conformance test

2022-10-11 Thread Gowrishankar Muthukrishnan
FIPS conformance tests require randomizing message based on SP 800-106. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_rsa.c | 112 +- 2 files changed, 115 insertions(+), 1 deletion

Re: [dpdk-dev] [v3, 0/3] common/cnxk: enable npa telemetry

2021-08-24 Thread Gowrishankar Muthukrishnan
Hi, Please let me know if any other info is required. Thanks, Gowrishankar > -Original Message- > From: dev On Behalf Of Gowrishankar Muthukrishnan > Sent: Wednesday, August 11, 2021 9:49 PM > To: Power, Ciara ; dev@dpdk.org > Cc: Richardson, Bruce ; Jerin Jacob Kollanuk

Re: [dpdk-dev] [EXT] Re: [v3, 0/3] common/cnxk: enable npa telemetry

2021-08-25 Thread Gowrishankar Muthukrishnan
on type casting the values internally in our driver (and avoiding library patch). Please share your thoughts. Thanks, Gowrishankar

[dpdk-dev] [v4, 0/2] cnxk: enable npa and mempool telemetry

2021-08-26 Thread Gowrishankar Muthukrishnan
This patch series enables telemetry in NPA LF and mempool driver of cnxk. v4: - added mempool driver endpoints. - removed lib/telemetry changes to include _ptr api. Gowrishankar Muthukrishnan (2): common/cnxk: add telemetry endpoints to npa mempool/cnxk: add telemetry end points drivers

[dpdk-dev] [v4, 1/2] common/cnxk: add telemetry endpoints to npa

2021-08-26 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to npa. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry.h | 26 +++ drivers/common/cnxk/cnxk_telemetry_npa.c | 227 +++ drivers/common/cnxk/meson.build | 4 + drivers/common/cnxk/roc_platform.h

[dpdk-dev] [v4, 2/2] mempool/cnxk: add telemetry end points

2021-08-26 Thread Gowrishankar Muthukrishnan
Adding telemetry end points to cnxk mempool driver. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/mempool/cnxk/cnxk_mempool_telemetry.c | 100 ++ drivers/mempool/cnxk/meson.build | 1 + 2 files changed, 101 insertions(+) create mode 100644 drivers/mempool

[dpdk-dev] [v5, 0/2] cnxk: enable npa and mempool telemetry

2021-08-26 Thread Gowrishankar Muthukrishnan
This patch series enables telemetry in NPA LF and mempool driver of cnxk. v5: - fixed meson.build files to use deps. Gowrishankar Muthukrishnan (2): common/cnxk: add telemetry endpoints to npa mempool/cnxk: add telemetry end points drivers/common/cnxk/cnxk_telemetry.h | 26

[dpdk-dev] [v5, 1/2] common/cnxk: add telemetry endpoints to npa

2021-08-26 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to npa. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry.h | 26 +++ drivers/common/cnxk/cnxk_telemetry_npa.c | 227 +++ drivers/common/cnxk/meson.build | 6 +- drivers/common/cnxk/roc_platform.h

[dpdk-dev] [v5, 2/2] mempool/cnxk: add telemetry end points

2021-08-26 Thread Gowrishankar Muthukrishnan
Adding telemetry end points to cnxk mempool driver. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/mempool/cnxk/cnxk_mempool_telemetry.c | 100 ++ drivers/mempool/cnxk/meson.build | 3 +- 2 files changed, 102 insertions(+), 1 deletion(-) create mode 100644

Re: [dpdk-dev] [EXT] Re: [v4, 1/2] common/cnxk: add telemetry endpoints to npa

2021-08-26 Thread Gowrishankar Muthukrishnan
ly, and the libraries linked against too if any functions from > those > are used by the code in this lib. > Ack. Thanks Bruce. Regards, Gowrishankar > Regards, > /Bruce

[dpdk-dev] [v6, 0/4] cnxk: enable telemetry endpoints

2021-09-03 Thread Gowrishankar Muthukrishnan
This patch series enables telemetry for cnxk in the following: - NPA LF - Mempool driver - NIX LF - Ethdev driver Depends-on: series-18612 ("net/cnxk: support for inline ipsec") v6: - Added nix and ethdev endpoints. Gowrishankar Muthukrishnan (4): common/cnxk: add telemetry en

[dpdk-dev] [v6, 1/4] common/cnxk: add telemetry endpoints to npa

2021-09-03 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to npa. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry.h | 26 +++ drivers/common/cnxk/cnxk_telemetry_npa.c | 225 +++ drivers/common/cnxk/meson.build | 6 +- drivers/common/cnxk/roc_platform.h

[dpdk-dev] [v6, 2/4] mempool/cnxk: add telemetry end points

2021-09-03 Thread Gowrishankar Muthukrishnan
Adding telemetry end points to cnxk mempool driver. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/mempool/cnxk/cnxk_mempool_telemetry.c | 100 ++ drivers/mempool/cnxk/meson.build | 1 + 2 files changed, 101 insertions(+) create mode 100644 drivers/mempool

[dpdk-dev] [v6, 3/4] common/cnxk: add telemetry endpoints to nix

2021-09-03 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to nix. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry_nix.c | 852 +++ drivers/common/cnxk/meson.build | 3 +- drivers/common/cnxk/roc_nix.c| 3 + drivers/common/cnxk/roc_nix_priv.h

[dpdk-dev] [v6, 4/4] net/cnxk: add telemetry endpoing to ethdev

2021-09-03 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint to ethdev. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/net/cnxk/cnxk_ethdev_telemetry.c | 148 +++ drivers/net/cnxk/meson.build | 1 + 2 files changed, 149 insertions(+) create mode 100644 drivers/net/cnxk

[dpdk-dev] [v7, 1/6] common/cnxk: add telemetry endpoints to npa

2021-09-08 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to npa. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry.h | 26 +++ drivers/common/cnxk/cnxk_telemetry_npa.c | 224 +++ drivers/common/cnxk/meson.build | 6 +- drivers/common/cnxk/roc_platform.h

[dpdk-dev] [v7, 0/6] cnxk: enable telemetry endpoints

2021-09-08 Thread Gowrishankar Muthukrishnan
This patch series enables telemetry for cnxk in the following: - NPA LF - Mempool driver - NIX LF - Ethdev driver - Crypto driver Depends-on: series-18612 ("net/cnxk: support for inline ipsec") v7: - Added cryptodev endppoints. - minor cleanup in other patches. Gowrishankar Mut

[dpdk-dev] [v7, 2/6] mempool/cnxk: add telemetry end points

2021-09-08 Thread Gowrishankar Muthukrishnan
Adding telemetry end points to cnxk mempool driver. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/mempool/cnxk/cnxk_mempool_telemetry.c | 100 ++ drivers/mempool/cnxk/meson.build | 1 + 2 files changed, 101 insertions(+) create mode 100644 drivers/mempool

[dpdk-dev] [v7, 3/6] common/cnxk: add telemetry endpoints to nix

2021-09-08 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to nix. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry_nix.c | 849 +++ drivers/common/cnxk/meson.build | 3 +- drivers/common/cnxk/roc_nix.c| 3 + drivers/common/cnxk/roc_nix_priv.h

[dpdk-dev] [v7, 4/6] net/cnxk: add telemetry endpoing to ethdev

2021-09-08 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint to ethdev. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/net/cnxk/cnxk_ethdev_telemetry.c | 129 +++ drivers/net/cnxk/meson.build | 1 + 2 files changed, 130 insertions(+) create mode 100644 drivers/net/cnxk

[dpdk-dev] [v7, 5/6] telemetry: fix json output buffer size

2021-09-08 Thread Gowrishankar Muthukrishnan
Fix json output buffer size for a single largest value. Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON") Signed-off-by: Gowrishankar Muthukrishnan Change-Id: Ida314114b654b5085244a659eb08b22969339856 --- lib/telemetry/telemetry_json.h | 7 +-- 1 file

[dpdk-dev] [v7, 6/6] crypto/cnxk: add telemetry endpoints to cryptodev

2021-09-08 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to cryptodev. Signed-off-by: Gowrishankar Muthukrishnan Change-Id: I7a0387fe11f383fca95169cfe2ec97bca46221ac --- .../crypto/cnxk/cnxk_cryptodev_telemetry.c| 154 ++ drivers/crypto/cnxk/meson.build | 1 + 2 files changed, 155 insertions

[PATCH v1 1/2] examples/fips_validation: skip offsetting source for json vectors

2022-07-12 Thread Gowrishankar Muthukrishnan
For JSON based test vectors, it is not required to offset further on source address where key value is read. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c | 4 1 file changed, 4 insertions(+) diff --git a/examples/fips_validation

[PATCH v1 2/2] examples/fips_validation: add parsing for tdes

2022-07-12 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for TDES CBC and ECB tests in json. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/sample_app_ug/fips_validation.rst | 2 + examples/fips_validation/fips_validation.c| 5 +- examples/fips_validation/fips_validation.h| 4

[PATCH v1] examples/fips_validation: fix memory allocation in aes mct test

2022-07-12 Thread Gowrishankar Muthukrishnan
Instead of allocating memory in every external iteration, do once in the beginning of AES MCT tests and free at the end. Fixes: 8b8546aaedf ("examples/fips_validation: add parsing for AES-CBC") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/m

[PATCH v2] examples/fips_validation: fix memory allocation in AES MCT test

2022-08-12 Thread Gowrishankar Muthukrishnan
Instead of allocating memory in every external iteration, do once in the beginning of AES MCT tests and free at the end. Fixes: 8b8546aaedf ("examples/fips_validation: add parsing for AES-CBC") Signed-off-by: Gowrishankar Muthukrishnan --- v2: - commit message. --- examples/fips_

[PATCH v1] examples/fips_validation: fix parsing SHA test type from JSON vector

2022-08-12 Thread Gowrishankar Muthukrishnan
Store SHA test type in its own interim info struct instead of AES. Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_sha.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 1/2] examples/fips_validation: share test callback with multiple keys

2022-08-12 Thread Gowrishankar Muthukrishnan
Make use of key param in test callbacks so that, test callback can be shared with multiple keys. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c | 27 +++--- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/examples

[PATCH v2 2/2] examples/fips_validation: add parsing for TDES

2022-08-12 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for TDES CBC and ECB tests in json. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/sample_app_ug/fips_validation.rst | 2 + examples/fips_validation/fips_validation.c| 3 + examples/fips_validation/fips_validation.h| 4

[PATCH v1 0/5] FIPS asymmetric validation

2022-08-12 Thread Gowrishankar Muthukrishnan
This patch series adds support in fips_validation app to perform asymmetric validation. To start with, RSA algorithm is used in the evaluation. For the key value pairs which is multiprecision in arithmetic, openssl library is used. Gowrishankar Muthukrishnan (5): examples/fips_validation: fix

[PATCH v1 1/5] examples/fips_validation: fix parsing test group info

2022-08-12 Thread Gowrishankar Muthukrishnan
If a test group does not have expected key, it should not crash. This patch fixes parsing test group info to continue further when a key does not exist (as in asym tests). Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") Signed-off-by: Gowrishankar Muthukrishnan ---

[PATCH v1 2/5] examples/fips_validation: add interim parse writeback

2022-08-12 Thread Gowrishankar Muthukrishnan
Asym tests need a callback to write interim info in expected output. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c | 6 ++ examples/fips_validation/fips_validation.h | 1 + 2 files changed, 7 insertions(+) diff --git a/examples/fips_validation

[PATCH v1 3/5] examples/fips_validation: add function to calculate SHA hash size

2022-08-12 Thread Gowrishankar Muthukrishnan
Add function to calculate hash size for a given SHA hash algorithm. Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 3 ++ .../fips_validation/fips_validation_sha.

[PATCH v1 4/5] examples/fips_validation: fix buffer size to parse JSON string

2022-08-12 Thread Gowrishankar Muthukrishnan
In asym op, while parsing test interim info, existing buffer of size 256 bytes is not sufficient, hence setting it to maximum that a test would need. Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_

[PATCH v1 5/5] examples/fips_validation: add asymmetric validation

2022-08-12 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan --- config/meson.build| 6 + doc/guides

[PATCH v2 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-09-05 Thread Gowrishankar Muthukrishnan
Add support for asymmetric EDDSA in cryptodev, as referenced in RFC: https://datatracker.ietf.org/doc/html/rfc8032 Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/default.ini | 1 + doc/guides/prog_guide/cryptodev_lib.rst| 2 +- lib/cryptodev/rte_crypto_asym.h

[PATCH v2 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-09-05 Thread Gowrishankar Muthukrishnan
Add support for asymmetric EDDSA in cryptodev, as referenced in RFC: https://datatracker.ietf.org/doc/html/rfc8032 Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/default.ini | 1 + doc/guides/prog_guide/cryptodev_lib.rst| 2 +- lib/cryptodev/rte_crypto_asym.h

[PATCH v2 2/6] crypto/openssl: support EDDSA

2024-09-05 Thread Gowrishankar Muthukrishnan
Support EDDSA crypto algorithm in OpenSSL PMD. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/openssl/openssl_pmd_private.h | 13 ++ drivers/crypto/openssl/rte_openssl_pmd.c | 223 +++ drivers/crypto/openssl/rte_openssl_pmd_ops.c | 131 +++ 3 files

[PATCH v2 3/6] crypto/cnxk: support EDDSA

2024-09-05 Thread Gowrishankar Muthukrishnan
Support EDDSA crypto algorithm in CNXK PMD. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/cn10k.ini | 1 + drivers/common/cnxk/hw/cpt.h | 3 +- drivers/common/cnxk/roc_ae.c | 52 +- drivers/common/cnxk/roc_ae.h

[PATCH v2 4/6] test/crypto: add asymmetric EDDSA test cases

2024-09-05 Thread Gowrishankar Muthukrishnan
Add test cases to validate EDDSA sign and verify ops, as per RFC 8032. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 357 +++- app/test/test_cryptodev_ecdh_test_vectors.h | 94 +++- app/test/test_cryptodev_ecdsa_test_vectors.h | 4

<    1   2   3   4   5   6   7   8   9   >