Use generic EC opcodes for sign and verify ops in ECDSA and SM2
implementations.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/common/cnxk/roc_ae.h | 14 +++---
drivers/crypto/cnxk/cnxk_ae.h | 50 +++
2 files changed, 38 insertions(+), 26 deletions
Change order of ECFPM params to match changes in v2.0 microcode.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/cnxk/cnxk_ae.h | 49 ++-
1 file changed, 20 insertions(+), 29 deletions(-)
diff --git a/drivers/crypto/cnxk/cnxk_ae.h b/drivers/crypto
Add ECDH support in CNXK PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
doc/guides/cryptodevs/features/cn10k.ini | 1 +
doc/guides/cryptodevs/features/cn9k.ini | 1 +
drivers/common/cnxk/roc_ae.h | 7 +
drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 12
Add modexp tests for groups 5, 14, 15, 16, 17 and 18.
Signed-off-by: Gowrishankar Muthukrishnan
---
v3:
- Fixed test descriptions for clang requirement.
---
app/test/test_cryptodev_asym.c | 48 +
app/test/test_cryptodev_mod_test_vectors.h | 989 -
2 files
device support
Gowrishankar Muthukrishnan (2):
app/dma-perf: validate copied memory
app/dma-perf: add SG copy support
app/test-dma-perf/benchmark.c | 344 ++
app/test-dma-perf/config.ini | 56 ++
app/test-dma-perf/main.c | 136 +-
app/test
From: Amit Prakash Shukla
Add support to skip running a dma-perf test-case.
Signed-off-by: Amit Prakash Shukla
---
app/test-dma-perf/config.ini | 2 ++
app/test-dma-perf/main.c | 23 +++
app/test-dma-perf/main.h | 1 +
3 files changed, 26 insertions(+)
diff --git
From: Amit Prakash Shukla
Add support to test performance for "device to memory" and
"memory to device" data transfer.
Signed-off-by: Amit Prakash Shukla
---
app/test-dma-perf/benchmark.c | 67 +++
app/test-dma-perf/config.ini | 37 +++
app/test
Validate copied memory to ensure DMA copy did not fail.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test-dma-perf/benchmark.c | 23 +--
app/test-dma-perf/main.c | 16 +++-
app/test-dma-perf/main.h | 2 +-
3 files changed, 33 insertions(+), 8
Add SG copy support.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test-dma-perf/benchmark.c | 274 +-
app/test-dma-perf/config.ini | 19 ++-
app/test-dma-perf/main.c | 34 -
app/test-dma-perf/main.h | 5 +-
4 files changed, 292 insertions
Add co-maintainer for DMA perf app.
Signed-off-by: Gowrishankar Muthukrishnan
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4083658697..b81eb1d5c0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1773,6 +1773,7 @@ F: doc/guides/testpmd_app_ug
Remove invoking include for sys/random.h which is not actually used
by app.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation_rsa.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/examples/fips_validation/fips_validation_rsa.c
b/examples/fips_validation
AES GMAC decrypt test should output only whether test passed or
failed.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation_gcm.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/examples/fips_validation/fips_validation_gcm.c
b
Acked-by: Gowrishankar Muthukrishnan
Thanks.
> -Original Message-
> From: Brian Dooley
> Sent: Monday, October 24, 2022 4:07 PM
> To: Brian Dooley
> Cc: dev@dpdk.org; Gowrishankar Muthukrishnan
> ; Akhil Goyal
> Subject: [EXT] [PATCH v1] examples/fips_validati
This patch series adds support for SHA3, SHAKE, AES-CCM
JSON test vectors and fixes existing algorithms to
support NIST test vectors.
Gowrishankar Muthukrishnan (10):
examples/fips_validation: fix MCT output for SHA
examples/fips_validation: add SHA3 validation
examples/fips_validation: fix
MCT test for SHA need not print message string along
with digest value.
Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA")
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation_sha.c | 8 ++--
examples/fips_validat
Add support in fips_validation to parse SHA3 algorithms.
Signed-off-by: Gowrishankar Muthukrishnan
---
doc/guides/sample_app_ug/fips_validation.rst | 5 +-
examples/fips_validation/fips_validation.h| 1 +
.../fips_validation/fips_validation_hmac.c| 8 ++
.../fips_validation
Add support in fips_validation to parse SHAKE algorithms.
Signed-off-by: Gowrishankar Muthukrishnan
---
doc/guides/sample_app_ug/fips_validation.rst | 1 +
examples/fips_validation/fips_validation.h| 4 +-
.../fips_validation/fips_validation_sha.c | 63 -
examples
Parsing integer value in test case vector does not store
it because only string was expected. This patch adds handling
for integer value as well.
Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing")
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_
Add support in fips_validation to parse CCM JSON vectors.
Signed-off-by: Gowrishankar Muthukrishnan
---
doc/guides/sample_app_ug/fips_validation.rst | 1 +
examples/fips_validation/fips_validation.c| 2 +
examples/fips_validation/fips_validation.h| 3 +
.../fips_validation
Add support to validate ECDSA keygen mode tests.
Signed-off-by: Gowrishankar Muthukrishnan
---
.../fips_validation/fips_validation_ecdsa.c | 52 +++
examples/fips_validation/main.c | 13 +
2 files changed, 65 insertions(+)
diff --git a/examples
Add SHA3 algorithms in ECDSA as supported.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation_ecdsa.c | 4
1 file changed, 4 insertions(+)
diff --git a/examples/fips_validation/fips_validation_ecdsa.c
b/examples/fips_validation/fips_validation_ecdsa.c
Fix AES XTS test to read sequence number correctly.
Fixes: f8e431ed8f6 ("examples/fips_validation: add parsing for AES-XTS")
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation_xts.c | 13 +
1 file changed, 9 insertions(+), 4 deletion
AES GCM validation tests fail in FIPS validation due to incorrect
fields populated in response file. This patch fixes them.
Fixes: 5b540bebac8e ("examples/fips_validation: fix GMAC decryption output")
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_valida
JSON buffer size")
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/fips_validation/fips_validation.h
b/examples/fips_validation/fips_validation.h
index c4988053c1..abc1d64
Auth key length is stored as 8 bit value in SE context. It should
be larger enough to accommodate supported auth key length of 1024
bytes maximum, as in HMAC.
Fixes: a45859312ff ("common/cnxk: add SE definitions for symmetric crypto")
Signed-off-by: Gowrishankar Muthukrishnan
--
Fix the order of ECFPM parameters according to target board.
Fixes: 8e39b133235 ("crypto/cnxk: support fixed point multiplication")
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/cnxk/cnxk_ae.h | 48 ---
1 file changed, 28 inserti
Hi,
Could these patches get some review ?
Thanks,
Gowrishankar
> This patch series fixes SM2 algorithm implementation to support digest
> message as input along with plain message as today.
>
> Gowrishankar Muthukrishnan (6):
> crypto/openssl: include SM2 in asymmetr
Fix memory leaks in SM2 ops, as reported by valgrind.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/openssl/rte_openssl_pmd.c | 45 ++--
1 file changed, 26 insertions(+), 19 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
b/drivers/crypto
t; > > + */
> > > + rte_crypto_uint k;
> > > + /**< The SM2 per-message secret number, which is an integer
> > > + * in the interval (1, n-1).
> > > + * If the random number is generated by the PMD,
> > > + * the 'rte_crypto_param.data' parameter should be set to NULL.
> > > + */
> > > +};
> > > +
> > > +/*
> > > + * Asymmetric SM2 transform data.
> > > + *
> > > + * Structure describing SM2 xform params.
> > > + */
> > > +struct rte_crypto_sm2_xform {
> > > + enum rte_crypto_auth_algorithm hash;
> > > + /**< Hash algorithm used in SM2 op. */
> > > + rte_crypto_uint dA;
> > > + /**< Private key. */
> > > + struct rte_crypto_ec_point PA;
> > > + /**< Public key. */
> > > +};
> > > +
> >
> > sm2_xform is no more required, but ec_xform can be reused as I had
> > proposed
> > in:
> > [v1,4/6] cryptodev: use generic EC xform params for SM2
> >
> > So, to summarize, may I request below of this patch to go above my
> > patch series If you agree.
> >
> > (1). Splitting sm2 op params into sign and cipher ops.
> > (2). Move private and public keys from op param into EC xform.
> >For DSA , should we move public key into xform as a session param ?
> Regardless which way we would go, it should be consistent across the API. I
> would say that private key should always be in session, public key eventually.
> Except for the key exchange, of course.
Ack.
Could you get a chance to review my patch series as well ?
Thanks,
Gowrishankar
Add modexp tests for groups 5, 14, 15, 16, 17 and 18.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 48 +
app/test/test_cryptodev_mod_test_vectors.h | 989 -
2 files changed, 1036 insertions(+), 1 deletion(-)
diff --git a/app
Add SG copy support in dma-perf application.
v4:
- improvement in buffer allocation for perf validation.
Gowrishankar Muthukrishnan (2):
app/dma-perf: validate copied memory
app/dma-perf: add SG copy support
app/test-dma-perf/benchmark.c | 251 ++
app/test
Validate copied memory to ensure DMA copy did not fail.
Fixes: 623dc9364dc ("app/dma-perf: introduce DMA performance test")
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test-dma-perf/benchmark.c | 24 ++--
app/test-dma-perf/main.c | 16 +++-
Add SG copy support.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test-dma-perf/benchmark.c | 243 +-
app/test-dma-perf/config.ini | 17 +++
app/test-dma-perf/main.c | 34 -
app/test-dma-perf/main.h | 5 +-
4 files changed, 260 insertions
p.
Ack. I will send next version of this series with this modification.
Reason we had in xform is to stop app not to process enq if session creation
itself
would fail (without required capability).
In the next version of patch, you would see (2/7), you keys moved into session.
Thanks,
Gowris
This patch series fixes SM2 algorithm implementation to
support digest message as input along with plain message
as today.
v2:
- private and pubic keys stored per session.
Gowrishankar Muthukrishnan (7):
crypto/openssl: include SM2 in asymmetric capabilities
cryptodev: set private and
Include SM2 algorithm in the asymmetric capabilities supported
by OpenSSL PMD.
Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2")
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Arkadiusz Kusztal
---
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 14
Set EC private and public keys into xform so that, it can be
maintained per session.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 121 ++
drivers/common/cnxk/roc_ae.h | 18 ++
drivers/common/cpt/cpt_mcode_defines.h
Elliptic curve based asymmetric operations use cryptographically
secure random number in its computation. If PMD supports RNG
for such ops, the application could skip computing on its own.
This patch adds new field in asymmetric capability to declare
this capability.
Signed-off-by: Gowrishankar
already
supports it.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 1 +
lib/cryptodev/cryptodev_trace.h | 9 +
lib/cryptodev/cryptodev_trace_points.c | 3 +++
lib/cryptodev/rte_cryptodev.c| 16
SM2 curve could use generic EC xform as it is yet another EC.
This would also require SM2 curve ID enumerated
along with other curves, as listed in:
https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Arkadiusz Kusztal
Check asymmetric capabilities such as SM3 hash support and
internal RNG and accordingly choose op params for SM2 test.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Arkadiusz Kusztal
---
app/test/test_cryptodev_asym.c | 78 --
app/test
Add SM2 asymmetric algorithm support in cnxk PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
doc/guides/cryptodevs/features/cn10k.ini | 1 +
doc/guides/rel_notes/release_23_11.rst| 6 +
drivers/common/cnxk/hw/cpt.h | 3 +-
drivers/common/cnxk/roc_ae.c
/oasis-tcs/virtio-spec/blob/master/device-types/crypto/description.tex#L736
To support VirtIO asymmetric op, this would be required.
Thanks,
Gowrishankar
27;ll check a bit closer.
Gowrishankar Muthukrishnan (6):
cryptodev: move RSA padding information into xform
cryptodev: fix RSA xform for ASN.1 syntax
vhost: add asymmetric RSA support
crypto/virtio: add asymmetric RSA support
examples/vhost_crypto: add asymmetric support
app/test
creation. Hence, moving this info from
crypto op into xform structure.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 4 --
app/test/test_cryptodev_rsa_test_vectors.h | 2 +
drivers/common/cpt/cpt_ucode_asym.h | 4 +-
drivers/crypto/cnxk
VirtIO to benefit from
the xform as per ASN.1 syntax.
Signed-off-by: Gowrishankar Muthukrishnan
---
lib/cryptodev/rte_crypto_asym.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h
index f0996816b9..afc5bdc874
Support asymmetric RSA crypto operations in vhost-user.
Signed-off-by: Gowrishankar Muthukrishnan
---
lib/cryptodev/cryptodev_pmd.h | 6 +
lib/vhost/rte_vhost_crypto.h | 14 +-
lib/vhost/vhost.c | 11 +-
lib/vhost/vhost.h | 1 +
lib/vhost/vhost_crypto.c | 551
Asymmetric RSA operations (SIGN, VERIFY, ENCRYPT and DECRYPT) are
supported in virtio PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
.../virtio/virtio_crypto_capabilities.h | 19 +
drivers/crypto/virtio/virtio_cryptodev.c | 388 +++---
drivers/crypto/virtio
Add symmetric support.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/vhost_crypto/main.c | 50 +---
1 file changed, 29 insertions(+), 21 deletions(-)
diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
index 02987ebd76..f9e2732d18
Add asymmetric tests for Virtio PMD.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 36 --
app/test/test_cryptodev_rsa_test_vectors.h | 26
2 files changed, 60 insertions(+), 2 deletions(-)
diff --git a/app/test
>
> The cnxk changes should be in patch [v2,7/7] crypto/cnxk: add SM2 support.
>
Thanks Ciara. Minor issue in patches rebase. I'll send next version fixing it.
Regards,
Gowrishankar
Remove unused stats in test setup.
Coverity issue: 373869
Fixes: 2c6dab9cd93 ("test/crypto: add RSA and Mod tests")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 5 -
1 file changed, 5 deletions(-)
diff --git
ned-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_asym.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 3802cf8022..1d88832146 100644
--- a/app/test/test_cryptodev_asym.c
+++
Fix comparison function used by modex test to check from
first non-zero value itself.
Coverity issue: 430125
Fixes: 2162d32c1c3 ("test/crypto: validate modex from first non-zero")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_cryptodev_a
Announce the additions in cryptodev ABI to support EDDSA algorithm.
Signed-off-by: Gowrishankar Muthukrishnan
--
RFC:
https://patches.dpdk.org/project/dpdk/patch/0ae6a1afadac64050d80b0fd7712c4a6a8599e2c.1701273963.git.gmuthukri...@marvell.com/
---
doc/guides/rel_notes/deprecation.rst | 4
Announce cryptodev changes to offload RSA asymmetric operation in
VirtIO PMD.
Signed-off-by: Gowrishankar Muthukrishnan
--
RFC:
https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-2-gmuthukri...@marvell.com/
https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-3
Announce vhost ABI changes to modify few functions to support
asymmetric crypto operation.
Signed-off-by: Gowrishankar Muthukrishnan
--
RFC:
https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-4-gmuthukri...@marvell.com/
---
doc/guides/rel_notes/deprecation.rst | 7 +++
1
Sure Jerin. I’ll drop this proposal as ABI versioning could help. Thanks.
Looks like in this case adding new arguments to function. Could you
check ABI versing helps here? It seems like it can be easy manged with
ABI versioning.
te and public keys are secured and
in catastrophe,
only that session could be destroyed.
Thanks,
Gowrishankar
Though padding schemes could be same
> +* cryptodev: The rte_crypto_rsa_xform struct member to hold private key
> + in either exponent or quintuple format is changed
> +struct
> + data type. This change is to support ASN.1 syntax (RFC 3447 Appendix
> A.1.2).
> + This change will not break existing applications.
This one I agree. RFC 8017 obsoletes RFC 3447.
Thanks,
Gowrishankar
> --
> 2.21.0
. If you think DPDK spec should not be modified, we will try to
amend the virtIO spec to match DPDK, but since we do not know if the virtIO
community would accept, can we merge the deprecation notice?
Thanks,
Gowrishankar
ZjQcmQRYFpfptBannerEnd
>>> +* cryptodev: The struct rte_crypt
> It means we are not able to add an algo without breaking ABI.
> Is it something we can improve?
>
Sure Thomas, we will address it in our patch, ensuring the long term solution
as well.
Regards,
Gowrishankar
Hi Arek,
> I do not have any particular security issues in mind here, and if PMD need to
> copy keys internally, for alignment or padding purposes, redundancy problems
> can be overcome. My concern was, that it is the more natural way of handling
> the API; we have one key, multiple padding scheme
> -Original Message-
> From: David Marchand
> Sent: Tuesday, June 7, 2022 3:32 PM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; Fan Zhang ; Brian
> Dooley ; Gowrishankar Muthukrishnan
> ; Brandon Lo
> Subject: [EXT] [PATCH] examples/fips_validation: fix link to
Hi David,
Do you mean this patch ? -
https://patches.dpdk.org/project/dpdk/patch/20220607100203.1611166-1-david.march...@redhat.com/
I have acked this. @Akhil Goyal could this be merged ?.
Thanks,
Gowrishankar
> -Original Message-
> From: David Marchand
> Sent: Monday, June 1
Allocate atleast onebyte to handle empty payload in a test vector
when defined.
Fixes: 3d0fad56b74 ("examples/fips_validation: add crypto FIPS application")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation.c | 2 +-
1 file
Added function to parse algorithm for AES XTS test.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation.c| 4 +-
examples/fips_validation/fips_validation.h| 17 ++-
.../fips_validation/fips_validation_xts.c | 126 ++
examples
Allocate at least onebyte to handle empty payload in a test vector
when defined.
Fixes: 3d0fad56b74 ("examples/fips_validation: add crypto FIPS application")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
---
v2:
- commit message corrections.
---
examples/fips_
Added function to parse algorithm for AES XTS test.
Signed-off-by: Gowrishankar Muthukrishnan
---
v2:
- build failure fixed if no jansson lib available.
---
examples/fips_validation/fips_validation.c| 4 +-
examples/fips_validation/fips_validation.h| 16 +-
.../fips_validation
Added function to parse algorithm for SHA test. Verified with SHA 1 and 256
vectors. SHA 384 and 512 has some issues with the way jansson objects are
created, which could be addressed separately.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation.c| 2
Thanks David, I ack and have added your suggestions in V3.
Regards,
Gowrishankar
Hi Fan,
> > --- a/examples/fips_validation/main.c
> > +++ b/examples/fips_validation/main.c
> > @@ -1693,19 +1693,24 @@ fips_mct_sha_test(void)
> > #define SHA_EXTERN_ITER100
> > #define SHA_INTERN_ITER1000
> > #define SHA_MD_BLOCK 3
> > - struct fips_val val = {NULL, 0}, md[SHA
Add support in fips_validation to parse AES_XTS and SHA json vectors.
v3:
- individual patches for xts and sha are clubbed in this new series.
Gowrishankar Muthukrishnan (3):
examples/fips_validation: add aes_cbc specific enum
examples/fips_validation: add parsing for xts
examples
Add algorithm enum specifically for AES_CBC instead of relying on
AES as such.
Fixes: 8b8546aaedf ("examples/fips_validation: add parsing for AES-CBC")
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Fan Zhang
---
examples/fips_validation/fips_validation.c | 2 +-
examples/fips_
Added function to parse algorithm for AES XTS test.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Fan Zhang
---
v3:
- CBC related changes moved to 1/3 patch.
---
examples/fips_validation/fips_validation.c| 2 +
examples/fips_validation/fips_validation.h| 15
Added function to parse algorithm for SHA test.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Fan Zhang
---
v3:
- added a comment on flat array of fips_val for parse_writeback callback.
---
examples/fips_validation/fips_validation.c| 2 +
examples/fips_validation/fips_validation.h
Add support in fips_validation to parse AES_XTS and SHA json vectors.
v4:
- doc updates
Gowrishankar Muthukrishnan (3):
examples/fips_validation: add aes_cbc specific enum
examples/fips_validation: add parsing for xts
examples/fips_validation: add parsing for sha
doc/guides
Add algorithm enum specifically for AES_CBC instead of relying on
AES as such.
Fixes: 8b8546aaedf ("examples/fips_validation: add parsing for AES-CBC")
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Fan Zhang
---
examples/fips_validation/fips_validation.c | 2 +-
examples/fips_
Added function to parse algorithm for AES XTS test.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Fan Zhang
---
v4:
- doc update
---
doc/guides/sample_app_ug/fips_validation.rst | 1 +
examples/fips_validation/fips_validation.c| 2 +
examples/fips_validation/fips_validation.h
Added function to parse algorithm for SHA test.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Fan Zhang
---
v4:
- doc update
---
doc/guides/sample_app_ug/fips_validation.rst | 1 +
examples/fips_validation/fips_validation.c| 2 +
examples/fips_validation/fips_validation.h
There is wrong size used for allocation of digest buffer which in
some cases cause memory corruption. Also, fixed places where memory
leak is observed.
Fixes: 93d797d94f1 ("examples/fips_validation: add parsing for sha")
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_
r sha")
Signed-off-by: Gowrishankar Muthukrishnan
---
v2:
- doc update to support 384 and 512 sha.
---
doc/guides/sample_app_ug/fips_validation.rst | 2 +-
examples/fips_validation/fips_validation_sha.c | 10 --
examples/fips_validation/main.c| 1 +
3 files changed, 10
r sha")
Signed-off-by: Gowrishankar Muthukrishnan
---
Depends-on: series-23828 ("example/fips_validation: add xts and sha json
parsing")
---
doc/guides/sample_app_ug/fips_validation.rst | 2 +-
examples/fips_validation/fips_validation_sha.c | 10 --
examples/fi
Please don't reintroduce some.
>
>
> > +
> > + vec.cipher_auth.digest.val = calloc(1,
> > + vec.cipher_auth.digest.len);
>
> Don't we need to check for allocation success?
>
Sure. I ll post fix for the above and thanks fo
There is wrong size used for allocation of digest buffer which in
some cases cause memory corruption. Also, fixed places where memory
leak is observed. This fix would enable sha 384 and 512 NIST vectors
be supported fully.
Signed-off-by: Gowrishankar Muthukrishnan
---
v3:
- addes fixes for
ned-off-by: Gowrishankar Muthukrishnan
---
lib/ethdev/rte_ethdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index e03e669c31..3484aa2b32 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -6465,8 +6465,6 @@ eth_dev_handle
;common/cnxk: support NIX TM debug and misc utils")
Fixes: df405df95ee ("common/cnxk: add NIX TM helper to alloc/free resource")
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/common/cnxk/cnxk_telemetry_nix.c | 3 +++
drivers/common/cnxk/roc_irq.c| 5 -
driv
This patch fixes unintended sign extensions reported in coverity
scan.
Fixes: 8ca851cdc59 ("common/cnxk: support dual VLAN insert and strip actions")
Coverity issue: 373258
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/common/cnxk/roc_npc.c | 4 ++--
1 file changed, 2 insert
Fix uninitialized pointer read reported in coverity scan.
Fixes: c34ea71b878 ("common/cnxk: add NPC parsing API")
Coverity issue: 370214, 370217, 370219, 370220, 370221, 370223,
370224, 370225, 372065
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/c
Fix incompatible casting on variables reported by coverity scan.
Fixes: 6223ede2036 ("event/cnxk: add event port link and unlink")
Coverity issue: 370582 370584
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/event/cnxk/cn10k_eventdev.c | 4 ++--
drivers/event/cnxk/cn9k_eventd
Fix memory leaks reported in coverity scan.
Fixes: 8a3d58c189f ("event/cnxk: add option to control timer adapters")
Coverity issue: 374990 374991
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/event/cnxk/cnxk_tim_evdev.c | 6 --
1 file changed, 4 insertions(+), 2 deletion
Fix uninitialized local variable as reported in coverity scan.
Fixes: 300b796262a ("event/cnxk: add timer arm routine")
Fixes: 300b796262a ("event/cnxk: add timer arm routine"
Coverity issue: 370578, 370579, 370587
Signed-off-by: Gowrishankar Muthukrishnan
---
Fix uninitialized local variable as reported by coverity scan.
Fixes: 6af19a9d89b ("net/cnxk: support meter action to flow destroy")
Coverity issue: 373630
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/net/cnxk/cnxk_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
19251 ("mempool: add telemetry endpoint for mempool info")
v10:
- added list endpoints for pool and aura (npa)
Gowrishankar Muthukrishnan (4):
common/cnxk: add telemetry endpoints to npa
common/cnxk: add telemetry endpoints to nix
mempool/cnxk: add telemetry endpoints mempool
net
Add telemetry endpoints to npa.
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/common/cnxk/cnxk_telemetry.h | 26 +++
drivers/common/cnxk/cnxk_telemetry_npa.c | 260 +++
drivers/common/cnxk/meson.build | 5 +
drivers/common/cnxk/roc_platform.h
Add telemetry endpoints to nix.
Signed-off-by: Gowrishankar Muthukrishnan
Reviewed-by: Harman Kalra
---
drivers/common/cnxk/cnxk_telemetry_nix.c | 849 +++
drivers/common/cnxk/meson.build | 3 +-
drivers/common/cnxk/roc_nix.c| 3 +
drivers/common
Adding telemetry endpoints to cnxk mempool driver.
Signed-off-by: Gowrishankar Muthukrishnan
Reviewed-by: Harman Kalra
---
drivers/mempool/cnxk/cnxk_mempool_telemetry.c | 57 +++
drivers/mempool/cnxk/meson.build | 1 +
2 files changed, 58 insertions(+)
create
Add telemetry endpoints to ethdev.
Signed-off-by: Gowrishankar Muthukrishnan
Reviewed-by: Harman Kalra
---
drivers/net/cnxk/cnxk_ethdev_telemetry.c | 93
drivers/net/cnxk/meson.build | 1 +
2 files changed, 94 insertions(+)
create mode 100644 drivers/net
Remove garbage entries for bypassed tests in response file.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/main.c | 74 -
1 file changed, 35 insertions(+), 39 deletions(-)
diff --git a/examples/fips_validation/main.c b/examples
Reset IV generation in every test group.
Signed-off-by: Gowrishankar Muthukrishnan
---
v2:
- rebase on latest main.
---
examples/fips_validation/fips_validation_gcm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/fips_validation/fips_validation_gcm.c
b/examples
101 - 200 of 895 matches
Mail list logo
