net/bnxt: wrong link status when lsc_intr is used

2023-01-20 Thread Edwin Brossette
TUP ) Switch name: :02:00.0 Switch domain Id: 0 Switch Port Id: 32768 Device error handling mode: proactive This shows link status is seen as up, even although link speed is None. I was wondering if patching the code to move this line which sets lsc interrupt on somewhere else might be reasonable, or if this could cause further trouble. Maybe having a parameter to trigger it ON/OFF might be a good addition. May I have your opinion on this matter? Sincerely, Edwin Brossette

[PATCH] bnxt: fix unwanted interrupt config on link state change

2023-02-06 Thread edwin . brossette
From: Edwin Brossette When getting the device's info via bnxt_dev_info_get_op(), the device enables interrupts on link state changes because of the following line: > eth_dev->data->dev_conf.intr_conf.lsc = 1; Enabling this mode might not be wanted by the user. The flag RTE_ET

Re: net/bnxt: wrong link status when lsc_intr is used

2023-02-08 Thread Edwin Brossette
ent number of RX queues: 2 > Max possible RX queues: 117 > Max possible number of RXDs per queue: 8192 > Min possible number of RXDs per queue: 16 > RXDs number alignment: 1 > Current number of TX queues: 2 > Max possible TX queues: 117 > Max possible number of TXDs per queue: 4096 > Min possibl

[ixgbevf] Problem with RSS initial config after device init on X550 nic

2024-02-15 Thread Edwin Brossette
Hello, We recently ran into an issue with our product when working with an X550 nic with stable dpdk-23.11. We observed that all the incoming traffic was directed only into a single queue. The issue became evident after displaying the RSS reta which was fully zeroed after device init, thus direct

[PATCH] net/ixgbevf: fix RSS init for x550 nics

2024-02-15 Thread edwin . brossette
From: Edwin Brossette Different Intel nics with the igxbe pmd do not handle RSS in the same way when working with virtualization. While some nics like Intel 82599ES only have a single RSS table in the device and leave all rss features to be handled by the pf, some other nics like x550 let the vf

net/virtio: duplicated xstats

2023-11-24 Thread Edwin Brossette
Hello, I noticed a small inconsistency in the virtio pmd's xstats. The stat "rx_q0_errors" appears twice. I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets" and "tx_q0_bytes" are duplicates of "rx_q0_good_packets", "rx_q0_good_bytes", "tx_q0_good_packets" and "tx_q0_good_bytes"

Re: net/virtio: duplicated xstats

2023-11-24 Thread Edwin Brossette
Hello again, The flag is already set during the device init, so it should be removed, not added. I can confirm removing it fixed my issue. I will submit a patch for this bug. Regards, Edwin Brossette. On Fri, Nov 24, 2023 at 11:39 AM Maxime Coquelin wrote: > Hi Edwin, > > T

[PATCH] net/virtio: fix duplicated rxq xstats

2023-11-24 Thread edwin . brossette
From: Edwin Brossette The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set while moving queue stats from 'struct rte_eth_stats' to the individual pmds, as explained in commit f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats"). This flag wa

net/e1000: Test issues following change in max rx/tx queues

2023-11-30 Thread Edwin Brossette
gards, Edwin Brossette.

net/ixgbe: all interrupt disabled after enabling lsc on X552/X557-AT card

2024-04-18 Thread Edwin Brossette
Hello, I have found a bug in the ixgbe pmd, concerning this model of nic in particular: -> Intel Corporation Ethernet Connection X552/X557-AT 10GBASE-T I was able to detect this bug after enabling the use of Link state change interrupt in the card via the following flag: - port->rte_conf

[PATCH] net/ixgbe: don't create a delayed interrupt handler if one already exists

2024-04-18 Thread edwin . brossette
From: Edwin Brossette Since link state may need some time to stabilize after a link state change, we cannot update the link state right after one occurs. So link state change interrupts (lsc) are handled after a delay. To do this, an alarm to call a delayed handler is programmed. This delayed

Crash in tap pmd when using more than 8 rx queues

2024-09-05 Thread Edwin Brossette
rks for me: if (dev->data->nb_tx_queues + dev->data->nb_rx_queues > RTE_MP_MAX_FD_NUM) return -1; I've made the changes on my local branch to fix my issue. This mail is just to bring attention on this problem. Thank you in advance for considering it. Regards, Edwin Brossette.

net/failsafe: segfault happens on hotplug alarm.

2024-09-05 Thread Edwin Brossette
and if sdev->state == DEV_PROBED, we call them in the opposite order. Perhaps someone could look into it? Regards, Edwin Brossette.

Re: Crash in tap pmd when using more than 8 rx queues

2024-09-06 Thread Edwin Brossette
Hello, I created a Bugzilla PR, just as you requested: https://bugs.dpdk.org/show_bug.cgi?id=1536 As for the bug resolution, I have other matters to attend to and I'm afraid I cannot spend more time on this issue, so I was only planning to report it. Regards, Edwin Brossette. On Fri,

net/netvsc: problem with configuring netvsc port after first port start

2024-10-01 Thread Edwin Brossette
e(), and is called when the mtu is changed. I suspect the operations described in comment above might also be needed when running rte_eth_dev_configure(). Is this a known issue ? In my application case, this bug causes issues when I need to restart and configure the port. Thank you for considering this issue. Regards, Edwin Brossette.

Re: net/mlx5: wrong Rx/Tx descriptor limits when DevX is off

2025-02-12 Thread Edwin Brossette
Hello, Sorry for bothering you again. May I inquire if this issue is still being worked on ? If so, when can I expect to see a fix ? Best regards, Edwin Brossette On Mon, Dec 23, 2024 at 2:09 PM Slava Ovsiienko wrote: > Confirm, it’s a bug, IIUC was introduced by reporting function upd

net/mlx5: wrong Rx/Tx descriptor limits when DevX is off

2024-12-20 Thread Edwin Brossette
info->tx_desc_lim.nb_max = + 1 << priv->sh->cdev->config.hca_attr.log_max_wq_sz; + } if (priv->sh->cdev->config.hca_attr.mem_rq_rmp && priv->obj_ops.rxq_obj_new == devx_obj_ops.rxq_obj_new) info->dev_capa |= RTE_ETH_DEV_CAPA_RXQ_SHARE; Thanks in advance for your help. Regards, Edwin Brossette.

Re: net/mlx5: wrong Rx/Tx descriptor limits when DevX is off

2025-03-17 Thread Edwin Brossette
Hello, Thank you for your answer. The short patch I joined with my first mail was just a rough example to report what I tested. I believe you know the driver's code better than I do, so I wouldn't be opposed to see you fix this issue. Thank you in advance. Regards, Edwin Brossette. O