Hi Ferruh,
I will mark the new APIs as experimental, and sent out a v4 patchset.
Thanks & Regards,
Zijie
-- Original --
From: "Ferruh Yigit";
Date: Thu, Apr 19, 2018 09:34 PM
To: "Zijie Pan"; "dev";
Cc: "remy.horto
res.rst.
- Fix checkpatch warnings regarding long lines.
- Update function pcmd_module_eeprom_callback().
v3 changes:
- fix compilation when dpdk is compiled with shared libs.
v4 changes:
- add RTE_ prefix for the macros defined in rte_dev_info.h.
- mark the new APIs as experimental.
- som
add new APIs:
- rte_eth_dev_get_module_info
- rte_eth_dev_get_module_eeprom
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: john.mcnam...@intel.com
Cc: marko.kovace...@intel.com
Cc: tho...@monjalon.net
doc/guides/nics/features.rst| 11
Add new callbacks for eth_dev_ops of i40e to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: beilei.x...@intel.com
Cc: qi.z.zh...@intel.com
drivers/net/i40e/i40e_ethdev.c | 147
1 file
Add new callbacks for eth_dev_ops of e1000 to get the information and
data of plugin module EEPROM.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: wenzhuo...@intel.com
drivers/net/e1000/base/e1000_phy.h |8
drivers/net/e1000/igb_ethdev.c | 86
Add a new command "module-eeprom" to get the data of plugin
module EEPROM.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: or...@mellanox.com
Cc: bruce.richard...@intel.com
Cc: pablo.de.lara.gua...@intel.com
Cc: radu.nico...@intel.com
Cc: akhil.go...@
Add new callbacks for eth_dev_ops of ixgbe to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: wenzhuo...@intel.com
Cc: konstantin.anan...@intel.com
drivers/net/ixgbe/ixgbe_ethdev.c | 79
Hi Thomas,
> > +/**
> > + * Placeholder for accessing plugin module eeprom
> > + */
> > +struct rte_dev_module_info {
> > + uint32_t type; /**< Type of plugin module eeprom */
> > + uint32_t eeprom_len; /**< Length of plugin module eeprom */
> > +};
>
> I am not sure "plugin module" is descriptive
other minor fixes.
v5 changes:
- insert the new APIs in alphabetical order in rte_ethdev_version.map.
Zijie Pan (5):
ethdev: add access to eeprom
examples/ethtool: add a new command module-eeprom
net/ixgbe: add module EEPROM callbacks for ixgbe
net/e1000: add module EEPROM callbacks for
Add a new command "module-eeprom" to get the data of plugin
module EEPROM.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: or...@mellanox.com
Cc: bruce.richard...@intel.com
Cc: pablo.de.lara.gua...@intel.com
Cc: radu.nico...@intel.com
Cc: akhil.go...@
Add new callbacks for eth_dev_ops of ixgbe to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: wenzhuo...@intel.com
Cc: konstantin.anan...@intel.com
drivers/net/ixgbe/ixgbe_ethdev.c | 79
add new APIs:
- rte_eth_dev_get_module_info
- rte_eth_dev_get_module_eeprom
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: john.mcnam...@intel.com
Cc: marko.kovace...@intel.com
Cc: tho...@monjalon.net
doc/guides/nics/features.rst| 11
Add new callbacks for eth_dev_ops of e1000 to get the information and
data of plugin module EEPROM.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: wenzhuo...@intel.com
drivers/net/e1000/base/e1000_phy.h |8
drivers/net/e1000/igb_ethdev.c | 86
Add new callbacks for eth_dev_ops of i40e to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: beilei.x...@intel.com
Cc: qi.z.zh...@intel.com
drivers/net/i40e/i40e_ethdev.c | 147
1 file
Hi Thomas,
> > v5 changes:
> > - insert the new APIs in alphabetical order in rte_ethdev_version.map.
>
> I think there is a misunderstanding.
> I was asking to rename rte_dev_module_info as rte_eth_dev_module_info.
I will update the patch right now.
Thanks & Regards,
Zijie
other minor fixes.
v5 changes:
- insert the new APIs in alphabetical order in rte_ethdev_version.map.
v6 changes:
- rename rte_dev_module_info as rte_eth_dev_module_info.
Zijie Pan (5):
ethdev: add access to eeprom
examples/ethtool: add a new command module-eeprom
net/ixgbe: add module
add new APIs:
- rte_eth_dev_get_module_info
- rte_eth_dev_get_module_eeprom
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: john.mcnam...@intel.com
Cc: marko.kovace...@intel.com
Cc: tho...@monjalon.net
doc/guides/nics/features.rst| 11
Add a new command "module-eeprom" to get the data of plugin
module EEPROM.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: or...@mellanox.com
Cc: bruce.richard...@intel.com
Cc: pablo.de.lara.gua...@intel.com
Cc: radu.nico...@intel.com
Cc: akhil.go...@
Add new callbacks for eth_dev_ops of ixgbe to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: wenzhuo...@intel.com
Cc: konstantin.anan...@intel.com
drivers/net/ixgbe/ixgbe_ethdev.c | 79
Add new callbacks for eth_dev_ops of i40e to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: beilei.x...@intel.com
Cc: qi.z.zh...@intel.com
drivers/net/i40e/i40e_ethdev.c | 147
1 file
Add new callbacks for eth_dev_ops of e1000 to get the information and
data of plugin module EEPROM.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: wenzhuo...@intel.com
drivers/net/e1000/base/e1000_phy.h |8
drivers/net/e1000/igb_ethdev.c | 86
other minor fixes.
v5 changes:
- insert the new APIs in alphabetical order in rte_ethdev_version.map.
v6 changes:
- rename rte_dev_module_info as rte_eth_dev_module_info.
v7 changes:
- add module EEPROM dump feature in default.ini
- add module EEPROM dump feature in .ini files for the three PM
Add a new command "module-eeprom" to get the data of plugin
module EEPROM.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: or...@mellanox.com
Cc: bruce.richard...@intel.com
Cc: pablo.de.lara.gua...@intel.com
Cc: radu.nico...@intel.com
Cc: akhil.go...@
add new APIs:
- rte_eth_dev_get_module_info
- rte_eth_dev_get_module_eeprom
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
Acked-by: Thomas Monjalon
---
Cc: remy.hor...@intel.com
Cc: john.mcnam...@intel.com
Cc: marko.kovace...@intel.com
Cc: tho...@monjalon.net
doc/guides/nics/features.rst
Add new callbacks for eth_dev_ops of ixgbe to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: wenzhuo...@intel.com
Cc: konstantin.anan...@intel.com
doc/guides/nics/features/ixgbe.ini |1 +
doc
Add new callbacks for eth_dev_ops of e1000 to get the information and
data of plugin module EEPROM.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: wenzhuo...@intel.com
doc/guides/nics/features/igb.ini |1 +
drivers/net/e1000/base/e1000_phy.h |8
drivers/net/e1000
Add new callbacks for eth_dev_ops of i40e to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: beilei.x...@intel.com
Cc: qi.z.zh...@intel.com
doc/guides/nics/features/i40e.ini |1 +
doc/guides/nics/features/i40e_vec.ini |1
Add a new API rte_pmd_i40e_set_lldp_cmd to control LLDP agent for i40e.
It supports the following i40e debug lldp commands:
- start/stop of the LLDP agent.
- get local/remote of the LLDP MIB (Management Information Base).
Signed-off-by: Laurent Hardy
Signed-off-by: Zijie Pan
ff-by: Laurent Hardy
> > Signed-off-by: Zijie Pan
>
> Does it mean that this feature is enabled by default in i40e devices?
> Should it be disabled by default?
The new API is just an interface to control the LLDP agent. No functions of
i40e call it by default. It is only used to
Add a new API rte_pmd_i40e_set_lldp_cmd to control LLDP agent for i40e.
It supports the following i40e debug lldp commands:
- start/stop of the LLDP agent.
- get local/remote of the LLDP MIB (Management Information Base).
Signed-off-by: Laurent Hardy
Signed-off-by: Zijie Pan
Acked-by
Thanks for the review.
I added a comment to explain why lldp is disabled in the code, and sent the v2
patch.
Thanks,
Zijie
-- Original --
From: "Zhang, Qi Z";
Date: Tue, May 22, 2018 09:00 PM
To: "Zijie Pan"; "dev@dpdk.org";
...
1e0:
1f0: 0003 0100
Both DPDK's my-module-eeprom.bin and Kernel's meeprom-kernel.bin
are the same.
Zijie Pan (5):
ethdev: add access to eeprom
examples/ethtool
Add a new command "module-eeprom" to get the data of plugin
module EEPROM.
Signed-off-by: Zijie Pan
---
doc/guides/sample_app_ug/ethtool.rst |2 ++
examples/ethtool/ethtool-app/ethapp.c | 61 +
examples/ethtool/lib/rte_ethtool.c
add new APIs:
- rte_eth_dev_get_module_info
- rte_eth_dev_get_module_eeprom
Signed-off-by: Zijie Pan
---
doc/guides/nics/features.rst | 11 +++
lib/librte_ether/rte_dev_info.h| 18 ++
lib/librte_ether/rte_ethdev.c | 26 ++
lib
Add new callbacks for eth_dev_ops of e1000 to get the information and
data of plugin module EEPROM.
Signed-off-by: Zijie Pan
---
drivers/net/e1000/base/e1000_phy.h |8
drivers/net/e1000/igb_ethdev.c | 83
2 files changed, 91 insertions
Add new callbacks for eth_dev_ops of i40e to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
---
drivers/net/i40e/i40e_ethdev.c | 141
1 file changed, 141 insertions(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b
Add new callbacks for eth_dev_ops of ixgbe to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 76 ++
1 file changed, 76 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b
res.rst.
- Fix checkpatch warnings regarding long lines.
- Update function pcmd_module_eeprom_callback().
Zijie Pan (5):
ethdev: add access to eeprom
examples/ethtool: add a new command module-eeprom
net/ixgbe: add module EEPROM callbacks for ixgbe
net/e1000: add module EEPROM callbacks for
add new APIs:
- rte_eth_dev_get_module_info
- rte_eth_dev_get_module_eeprom
Signed-off-by: Zijie Pan
---
doc/guides/nics/features.rst | 11 +++
lib/librte_ether/rte_dev_info.h| 18 ++
lib/librte_ether/rte_ethdev.c | 26 ++
lib
Add a new command "module-eeprom" to get the data of plugin
module EEPROM.
Signed-off-by: Zijie Pan
---
doc/guides/sample_app_ug/ethtool.rst |2 ++
examples/ethtool/ethtool-app/ethapp.c | 64 +
examples/ethtool/lib/rte_ethtool.c
Add new callbacks for eth_dev_ops of ixgbe to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 79 ++
1 file changed, 79 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b
Add new callbacks for eth_dev_ops of e1000 to get the information and
data of plugin module EEPROM.
Signed-off-by: Zijie Pan
---
drivers/net/e1000/base/e1000_phy.h |8
drivers/net/e1000/igb_ethdev.c | 86
2 files changed, 94 insertions
Add new callbacks for eth_dev_ops of i40e to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
---
drivers/net/i40e/i40e_ethdev.c | 147
1 file changed, 147 insertions(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b
res.rst.
- Fix checkpatch warnings regarding long lines.
- Update function pcmd_module_eeprom_callback().
v3 changes:
- fix compilation when dpdk is compiled with shared libs.
Zijie Pan (5):
ethdev: add access to eeprom
examples/ethtool: add a new command module-eeprom
net/ixgbe: add
add new APIs:
- rte_eth_dev_get_module_info
- rte_eth_dev_get_module_eeprom
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: john.mcnam...@intel.com
Cc: marko.kovace...@intel.com
Cc: tho...@monjalon.net
doc/guides/nics/features.rst| 11
Add a new command "module-eeprom" to get the data of plugin
module EEPROM.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: or...@mellanox.com
Cc: bruce.richard...@intel.com
Cc: pablo.de.lara.gua...@intel.com
Cc: radu.nico...@intel.com
Cc: akhil.go...@
Add new callbacks for eth_dev_ops of ixgbe to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: wenzhuo...@intel.com
Cc: konstantin.anan...@intel.com
drivers/net/ixgbe/ixgbe_ethdev.c | 79
Add new callbacks for eth_dev_ops of e1000 to get the information and
data of plugin module EEPROM.
Signed-off-by: Zijie Pan
---
Cc: wenzhuo...@intel.com
drivers/net/e1000/base/e1000_phy.h |8
drivers/net/e1000/igb_ethdev.c | 86
2 files
Add new callbacks for eth_dev_ops of i40e to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
---
Cc: beilei.x...@intel.com
Cc: qi.z.zh...@intel.com
drivers/net/i40e/i40e_ethdev.c | 147
1 file changed, 147 insertions
49 matches
Mail list logo
